This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 25, 2024
-
-
Nick Fitzpatrick authored
-
Oleg Gromov authored
* Mark parameter on the dashboard with * * Require default value for a required template tag * Add reset to native queries * Remove unused WidgetStatusIcon * Add reset button for native queries only * Rewrite FieldSet in TS to fix typing * Update e2e helper to click "Always require a value" insted of previously "Required?" * Switch to MLv2 * Add e2e tests for required filters * Update e2e tests * Update another test * Fix required untoggling bug * Fix parenthesis in t * Reset to default on input blur * Show correct icons & update behavior for reqiured parameters in native queries * Don't reset default value when toggling required * Update the widgetstatusicon types * Set parameter value when toggling default * Update TagEditorParam unit tests * Add native query tests for number, string and date * Fix re-setting to default from empty state for field widgets * Add e2e tags for field tags
-
Sloan Sparger authored
-
Nemanja Glumac authored
* Add section about `Lodash` * Fix typo * Expand the standard development flow section * Expand the running options section * Expand running on Docker section * Add section for tests that require SMTP server * Clarify the viewport resizing options * Javascript -> JavaScript * Delete redundant README section * Explain `contains` vs `find` vs `get` better
-
Sloan Sparger authored
-
Raphael Krut-Landau authored
-
Jeff Bruemmer authored
-
Kyle Doherty authored
-
Kyle Doherty authored
-
Nicolò Pretto authored
-
Alexander Solovyov authored
-
Noah Moss authored
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Nick Fitzpatrick authored
* Load tables when dbid is present in data permissions pages, e2e test * run prettier * cleanup. Fixing #37811 * remove undeeded awaits
-
Nemanja Glumac authored
* Revert "Remove internal query check (#37587)" This reverts commit 16aa9974. * Add a comment Explains why the guard against `internal` queries is needed here.
-
Oleg Gromov authored
* Convert Sidebar to TSX * Move remove button to the sidebar footer * Change styles to styled components * Fix tests
-
Kamil Mielnik authored
Repro #36122 - Table Metadata having 2 foreign keys from the same table pointing to the same key cause implicit joins to only show 1 (#38085) * Add a repro for 36122 * Improve assertions
-
Uladzimir Havenchyk authored
-
Nicolò Pretto authored
* console log snowplow events * wraps it in a env var to not spam the console * remove try catch now that's under a flag * moved reading the env to env.js
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard parameter values in embed preview not working * Fix iframe rerendering unnecessarily * Add E2E reproduction test * Prevent iframe from rerendering unnecessarily
-
Kamil Mielnik authored
Split QueryBuilder.unit.spec.tsx into QueryBuilder.beforeunload-events.unit.spec.tsx, QueryBuilder.unsaved-changes-warning.unit.spec.tsx & test-utils.tsx (#38032)
-
- Jan 24, 2024
-
-
bryan authored
* adds info about what value validate got to the exception message * test fixups * fix the other test * remove inline def
-
Raphael Krut-Landau authored
* Port BrowseHeader to tsx * Use generic type with useSearchListQuery * Allow the query to be specified in setupDatabasesEndpoints * Port EmptyState to tsx * Correct type in FilterableTree * Remove unneeded props
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
This regressed in 48 - it only works when either none of the several filters has a value, or when all of them do. This PR restores the 47 behavior: whatever subset of the filters have values (including defaults) will be used, and the others are ignored. The fix is on the BE but the change actually occurred in the FE - previously only those parameters with values were sent in the request. We might want that FE behavior back, but the new BE logic should work either way. Fixes #38012.
-
Jerry Huang authored
* add personal-only to collection endpoint * address some comments * fix test * fix select-collections test * Update src/metabase/api/collection.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * Update src/metabase/api/collection.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * address comments --------- Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Oleg Gromov authored
-
Denis Berezin authored
* Migrate EmbedModalContent to TS * Add basic UI changes to Embed modal * More styling * Add more styling * Self review fixes * Self review fixes * Fix action button * Fix unit tests * Fix e2e tests * Fix e2e tests * Code review and design fixes * Fix unit test * Add Parameters tab text diff and switch to preview * Add code diff display logic for appearance tab * Self review fixes * Fix e2e tests * Button text hotfix * Move state to component, fix diff * Review fixes, action buttons refactor * Implement new code diff * Fix text highlight, fix unit tests * Code review fixes * Design review fixes * New code diff highlight UX * Remove folding * Change code diff logic, add automatic client code switch * Fix code highlight logic * Add unit tests * Fix some e2e tests * Fix e2e tests * Fix code highlight, parameters diff * Add code highlight on locked parameter value change * Add more tests * Review fixes * Refactor unit tests * Rollback preview tab remove, add utm tags * Fix prettier * Add interactive modal header with hover * Review fixes * Review fixes
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Move _lastAutocomplete to a variable in closure * Debounce the initial autocomplete * Add e2e tests * Fix typo in test case Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Remove async from 2e2 tests * Fix wording of comment * Avoid casting in lastAutoComplete * Clarify comment in skip condition for initial autocomplete * Remove outdated comment in e2e test * Describe problem in filename, not assertion * Use early return instead of skip variable * Pass results from last autocomplete to ace * Actually use last autocompletions result * Detect the first autocomplete without looking at the actual prefix * Add test for backspacing to one character in native editor * Rename resultsForAce to prepareResultsForAce * Avoid running autocompleter with prefix of length 1 * Remove unnecessary fallback Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Ryan Laurie authored
Co-authored-by:
Vladimir Zaytsev <vladimir@trunk.io>
-
Chris Truter authored
This reverts commit d78f324c, which reverted 7b0a906a.
-
Uladzimir Havenchyk authored
[QB] Add e2e test for previously broken `SumIf` and `CountIf` functions in custom expressions (#38082) * Add repro for aggregation with SumIf and CountIf * Decrease typing delay * Update e2e/test/scenarios/question/notebook.cy.spec.js Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Nemanja Glumac authored
* Migrate structured query isEditable method to MLv2 * Migrate all `isQueryEditable` references to MLv2 * Remove `isEditable` methods altogether * Fix failing unit test * [MLv2] Rewrite `QuestionDataSoruce` FE unit test (#38058) * Rewrite `QuestionDataSoruce` FE unit test * Remove unused parameter * Construct empty metadata instance as a fallback
-
Anton Kulyk authored
-
Kamil Mielnik authored
* Add Unit Test Stress Test Flake Fix workflow * Add "frontend" prefix to the workflow to disambiguate between backend and frontend
-
Nemanja Glumac authored
This is a follow-up after #38011. See this comment: https://github.com/metabase/metabase/pull/38011#discussion_r1462885451
-