Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 31, 2022
    • Anton Kulyk's avatar
      Convert `ClickBehaviorSidebar` to TypeScript (#25090) · c565e0b3
      Anton Kulyk authored
      * Extend dashboard types
      
      * Add click behavior types
      
      * Convert `ClickBehaviorSidebar` to TypeScript
      
      * Convert `SidebarItem` to TypeScript
      
      * Convert `TypeSelector` to TypeScript
      
      * Convert `TableClickBehaviorView` to TypeScript
      
      * Convert `ActionOptions` to TypeScript
      
      * Convert main sidebar view to TypeScript
      
      * Convert `LinkOptions` to TypeScript
      
      * Fix types
      
      * Convert utils to TypeScript
      
      * Remove redundant `div`
      
      * Extract `ClickBehaviorSidebarHeaderContent`
      
      * Extract `ClickBehaviorSidebarContent`
      
      * Swap conditionals
      Unverified
      c565e0b3
    • Anton Kulyk's avatar
      Refactor `ClickBehaviorSidebar` components (#25089) · b3a868c0
      Anton Kulyk authored
      * Untangle `ClickBehaviorSidebarHeader`
      
      * Untangle `ClickBehaviorSidebarMainView`
      
      * Untangle `Column`
      
      * Move `LinkOptions` to its own directory
      
      * Untangle `LinkOptions`
      
      * Move `TableClickBehaviorView` to its own directory
      
      * Untangle `TableClickBehaviorView`
      
      * Untangle `QuestionDashboardPicker`
      
      * Extract `SidebarItem` component
      
      * Remove `SidebarItemClasses` and `SidebarItemStyle`
      
      * Fix `QuestionDashboardPicker` sidebar item component
      
      * Move components into their own folders
      
      * Extract more code into `SidebarItem`
      
      * Extract styled components
      
      * Untangle main content rendering
      
      * Remove redundant div
      
      * Fix padding
      
      * Clean up `ClickBehaviorSidebar` props
      
      * Fix missing prop
      
      * Fix incorrect `disabled` condition
      
      * Convert sidebar into functional component
      
      * Fix `hasSelectedColumn` used before define
      Unverified
      b3a868c0
    • Alexander Polyankin's avatar
    • Anton Kulyk's avatar
      Remove `redux-logger` (#25084) · 133647b5
      Anton Kulyk authored
      * Remove `redux-logger` usage
      
      * Remove related lib file
      
      * Uninstall `redux-logger`
      Unverified
      133647b5
    • Anton Kulyk's avatar
      Extract `ClickBehaviorSidebar` components (#25088) · 64d40f28
      Anton Kulyk authored
      * Extract straightforward styled components
      
      * Extract `SidebarItem` bits
      
      * Remove not used props
      
      * Sort imports
      
      * Extract `ValuesYouCanReference` component
      
      * Extract `CustomLinkText` component
      
      * Extract `LinkOption` component
      
      * Extract `Column` component
      
      * Extract utils
      
      * Extract `TypeSelector` component
      
      * Extract `ActionOptions` component
      
      * Extract `QuestionDashboardPicker` component
      
      * Extract `CrossfilterOptions` component
      
      * Extract `LinkOptions` component
      
      * Extract `TableClickBehaviorView` component
      
      * Extract `ClickBehaviorSidebarHeader` component
      
      * Extract `ClickBehaviorSidebarMainView` component
      
      * Fix `this` references in functional components
      64d40f28
    • Anton Kulyk's avatar
      9c152124
    • Ryan Laurie's avatar
      redirect to new action on create (#25122) · 771cb0e9
      Ryan Laurie authored
      Unverified
      771cb0e9
    • Ngoc Khuat's avatar
      Fix incorrectness issue for advanced FieldValues when sandboxing use native question (#24967) · ffa2302c
      Ngoc Khuat authored
      
      * use login-attributes when hash advanced field-values if sandbox use native query
      
      * add a e2e test
      
      * Add repro for #24966
      
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      ffa2302c
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Show data point values on static viz (followed-up PR) (#24938) · b8f4c6ef
      Mahatthana (Kelvin) Nomsawadi authored
      * Handle negative bar data point value
      
      * Migrate static line chart values to Values component
      
      * Migrate static bar chart values to using Values component
      
      * Migrate static area chart values to using Values component
      
      * Fix stroke rendering
      
      * Fix multiseries value collision
      
      * Fix bar + y axis collision
      
      * Fix x-axis collision
      
      * Fix collision bug
      
      * Render chart last so it's above the Y axises
      
      * Fix value stroke collide with X-axis
      
      * Tidy up <Values /> and make it more readable
      
      * Fix auto compact formatting for stacked chart
      
      * Handle overlapping value with left Y-axis
      
      * `serie` -> `series`, and `series` -> `multipleSeries`
      
      So, it's grammatically correct.
      
      * Move some types to where they should belong
      
      * Add OutlinedText for static viz
      
      This is for <Text /> that has a stroke and has `pain-order: stroke`.
      Unverified
      b8f4c6ef
  2. Aug 30, 2022
  3. Aug 29, 2022
Loading