* sunburst improvements

* fix dimension picker styles

* simplify styles

* update e2e test

* add loki specs

* add missing newlines

* refactor: sort import members inside destructuring

* Show an error message when the temporal unit is not applicable to a dashboard card (#46983)

* Fix tests

* Add tests

* Add tests

* Fix types

* Fix types

---------

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

* Upgrade eslint-plugin-import

* Configure import/order rule for consistent, predictable imports

* Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"

* Ensure imports are in a single block

* Move or remove informative comments between import statements

* Remove imports-grouping comments

* Configure groups
- the difference between the default setting is the presence of "internal" group

* Manually fix imports order and disable "import/order" rule in files with possible circular dependencies

* Move comment to the same line as import

* Run "yarn eslint-fix" 5 times
- Remaining: 16 problems (16 errors, 0 warnings)

* Manually fix imports order in remaining files

* Run "yarn prettier"

* Fix import

* Fix circular dependency

* Fix circular dependency

* Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)

* Re-add accidentally removed code

* Fix typing

* ESLint

* move component files into directories

* fix tests

* check how much is broken after redux upgrade

* fix popovers could not use connected components

* fix a unit spec failure

* fix accessing a connected component ref which is a class instance

* supress typescript errors caused by better type inference of the newer react-redux

* enforce import order

* reorder all imports

* more import updates

* Adding text-overflow to ChartSettingsFieldPicker

Co-authored-by: gitstart <gitstart@users.noreply.github.com>

* Triggerable accept a custom tag for trigger

* Remove group trigger for ActionsPopover updated to use li tag

* Normalised padding for ActionsPopover triggers

* Misc

* Remove padding-top for UserActionsSelect

* Align padding with other UserActionsSelect

* Misc

* Forward form field ref

* Focus "display_name" when selecting a new field

* Hide query editor in metadata mode

This will remove it from the "tab-flow"

* Pass tabIndex prop to form text inputs

* Add basic tab flow for metadata editor

* Allow passing more props to SelectButton

* Allow passing props to AccordionList's search input

* Use numbers for tab indexes

* Fix SelectButton's props type

* Add special type picker to tab flow

* Fix initial field focusing

* Add "tab" icon

* Add basic TabHintToast component

* Show tab hint toast in metadata editor

* Export wrapped CustomFormField

* Forward SelectButton ref

* Add react-virtualized scrollToColumn prop to Table

* Don't open SemanticTypePicker on focus

* Open SemanticTypePicker on "Enter" key press

* Improve tabbing experience

* automatically scroll the InteractiveTable while tabbing through columns
* focus the first column on hitting "Enter" on the last column

* Remove failed experiment

It was my last hope to combine both props, but no lucj

* Animate sidebar when focused field changes

* Minor rename

* Fix mapped field picker component

* Pass visibility callbacks to trigger elements

* Handle focus for mapped field picker

* Pass searchPlaceholder to Select

* Pass triggerable's onClose prop to Select

* Add onClose prop to DataSelector

* Use Select from special type picker

* Handle focus for MappedFieldPicker

* Add :focus style for essential select inputs

* Fix jump from last to first column on tab key

* Separate Join unit tests with newlines

* Refactor Join's unit tests

* Add join type getters (by conditions count)

* Add getter and setter for join conditions by index

* Remove old comment

* Extract method converting dimensions

* Update setParentDimension

* Update setJoinDimension

* Update joinDimensions method

* Update joinDimensions method

* Update join alias setter

* Update default condition setter

* Update isValid method

* Add getConditions method

* Add addEmptyDimensionsPair method

* Render multiple join conditions

* Fix JoinStep align-items

* Fix join dimension methods usage

* Fix join dimensions alignment

* Temporary disable auto opening pickers

* Test adding a new dimensions pair

* Fix "add" join icon visibility

* Add "on" label between join conditions

* Remove redundant `else`

* Add `removeCondition` method for `Join`

* Fix JoinDimensionPicker's prop types

* Allow removing empty dimension pairs

* Add space between join dimensions

* Simplify JoinStep tests setup

* Automatically open dimension pickers

* Test JoinStep updates `Join` instance correctly

* Display dimensions source name

* Allow overwriting NotebookCell's padding

* Fix JoinStep layout

* Allow to clear a selected dimension

* Disable "no-unused-vars" for Join file

* Fix parentDimension usage

* Fix StructuredQuery's `Join` usage

* Update notebook visual test

* Fix E2E test

* Fix JoinStep look when no dimensions selected

* Extract JoinDimensionsRightControl component

* Extract JoinDimensionCellItem component

* Increase JoinStep's tests timeout

* Extract `_getExplicitJoinsSet` from StucturedQuery

* Fix unused variables in Join class

* Add a comment about setTimeout

* Fix join condition label

* Fix dimensions picker opens when dimension is set

* Make table icon container clickable

* Hide fields picker tooltip on picker open

* Fix Preview button overflowing JoinStep

* Fix table picker click area

* Test can't share dashboard without cards

* Fix can't share dashboard with markdown cards only

* Fix public dashboard crash while loading

* Remove duplicated test

* Add `aria-disabled` prop to Triggerable

* Subscribe to dashboards only if it has data cards

* Fix `eslint-react/no-string-refs` errors (#15427)

* Handle errors in `AdminLayout.jsx`

* Rmove unused ref from `MetadataEditorApp.jsx`

* Remove unused ref from `EditBar.jsx`

* Handle errors in `Confirm.jsx`

* Handle errors in `Header.jsx`

* Handle errors in `NewsletterForm.jsx`

* Handle errors in `ColorPicker.jsx`

* Remove unused ref from `PasswordReveal.jsx`

* Handle errors in `Triggerable.jsx`

* Handle errors in `TokenField.jsx`

* Handle errors in `DashboardHeader.jsx`

* Handle errors in `RefreshWidget.jsx`

* Handle errors in `DatabaseEditApp.jsx`

* Handle errors in `FieldRemapping.jsx`

* Handle errors in `ObjectActionsSelect.jsx`

* Handle errors in `ObjectRetireModal.jsx`

* Remove unused ref from `UserGroupSelect.jsx`

* Handle errors in `PermissionsGrid.jsx`

* Handle errors in `ParameterTargetWidget.jsx`

* Handle errors in `ParameterValueWidget.jsx`

* Handle errors in `PulseEdit.jsx`

* Handle errors in `PulseEditName.jsx`

* Handle errors in `DataSelector.jsx`

* Remove unused ref from `FieldWidget.jsx`

* Handle errors in `NativeQueryEditor.jsx`

* Handle errors in `SearchBar.jsx`

* Handle errors in `ExpressionEditorTextfield.jsx`

* Remove unused ref from `FieldWidget.jsx`

* Remove unused ref from `SpecificDatePicker.jsx`

* Handle errors in `RevisionMessageModal.jsx`

* Handle errors in `Setup.jsx`

* Handle errors in `LeafletMap.jsx`

* Handle errors in `TableSimple.jsx`

* Handle errors in `PieChart.jsx`

* Handle errors in `Progress.jsx`

* Remove unused refs from `QueryBuilder.jsx`

* Remove unused ref and methods from `MetadataHeader.jsx`

* Remove unused ref from `DashboardActions.jsx`

* Handle errors in `DatabaseListApp.jsx`

Note: dynamic refs

* Handle errors in `LegendHorizontal.jsx`

Note: dynamic refs

* Disable linting rule `react/no-string-refs` in `LegendVertical.jsx`

Note: dynamic refs

* Partially handle errors in `GuiQueryEditor.jsx`

* Disable linting rule `react/no-string-refs` in `GuiQueryEditor.jsx`

Note: dynamic refs

* Revert "Remove unused ref from `DashboardActions.jsx`"

This reverts commit 5facb9d60ecb561093af15efcfc99b29ff96980e.

* Handle errors in `DashboardActions.jsx`

* Remove redundant `ReactDOM.findDOMNode` from `Setup.jsx`

* Revert "Handle errors in `DashboardActions.jsx`"

This reverts commit b3d64b8f7a982e0371d225d0d624ecbeaf776b76.

* Disable linting for `DashboardActions.jsx`

* Fix prettier error

* Delete non-existing prop `getTarget`

* Fix typo

* Fix typos in more places

* Fix `footerRef` check

* Turn on `react/no-string-refs` lint rule

* Disable `react/prop-types` in files that are breaking the build

* Fix broken refs

Co-authored-by: alxnddr <alxnddr@gmail.com>

* Fix `react/no-children-prop` error (#15122)

* Turn on `react/no-children-prop` lint rule

* Switch the rule to "error"

* Disable linting for `prop-types` in unit tests

* Disable linting for `prop-types` in all affected files

* Remove .jsx extension from imports

* Use color() function instead of colors[...]

* Remove depreacted MBQL from frontned

* Remove more deprecated MBQL

* Revert a couple removals of .jsx due to flow conflict with .css files

* Fix reference/utils tests

* Fix color conflict

Notebook Mode + View Mode + Joins + etc