This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 08, 2024
-
-
lbrdnk authored
* Move collect-source-tables to util * Add table prefetching * Add test comparing call counts of select * Update comment * Add exception handling * Add nil handling * Handle possibye empty table-ids * Update exception handling and test case * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Nick Fitzpatrick authored
* use useClickOutside, add repro test * adjusting aria label
-
Tim Macdonald authored
(Cleans up [#45137])
-
Nemanja Glumac authored
* Do not colide "no results" with "running the query" Fixes #41464 * Add E2E reproduction for #41464
-
Mahatthana (Kelvin) Nomsawadi authored
* Document how to reload Metabase embedding SDK components * Improve readme clarity on useEffect block
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
-
- Jul 05, 2024
-
-
Cal Herries authored
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* lint: add stylelint support for emotion components * drop comment * fix pattern order * Use one version of typescript * use :focus not :outline * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:" * Use mb-color-focus for focus color * Drop dead code --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Case Nelson authored
* fix: limit xrays on agg models to source fields Fixes #43793 1. `table-like?` was checking aggregations but not breakouts. This meant that legacy metric definitions would try to apply to the second stage which is generally illegal and would cause things like implicit joins to come in where they make no sense. 2. Trying to bin a `count` metric-like model would give a bin span of 0.0 which would blow up those questions. 3. Trying to self reference breakout fields, in the precense of a question's aggregation meant that most fields would not be exposed to the next stage and should be ignored. (similar to 1.) * Fix tests
-
Cal Herries authored
-
Cal Herries authored
-
Anton Kulyk authored
* Show alert sending time in alert form * F
-
Alexander Polyankin authored
-
Alexander Solovyov authored
-
Romeo Van Snick authored
* Add csv-stringify package * Split values at comma WIP: Parse values using json * Add label to ParameterValue and add ParameterValue to value config * Use custom label in FieldValuesWidget * Allow passing displayValue from outside of RemappedValue * Allow passing displayValue in ParameterFieldWidgetValue * Get custom value label in FormatterParameterValue * Allow rendering custom displayValue in FieldValuesWidget * Add custom ParameterValue types * Fix ParameterValuePicker type * Fix jest import for csv-stringify * Add missing RTKQ exports for paramters * Use direct implementation of useGetParameterValues * Fix ValueSourceModal tests * Add tests for value parsing and stringifying * Use custom label in list too * Render the custom label in a parameter value * Setup parameter mocks in embed test * Add info about splitting values with comma * Add model hint when user is using labels * Add test for cusom labels on dashboards * Handle label-value pairs in test * Test custom labels in parameter search input * Use the label to parse the value for text inputs * Fix comma's to commas Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Use strong instead of styling link * Use getInput instead of ignoring eslint rule * Use arrow function * Add newlines between tests * Use uppercase for test value * Name value * Use getLabel and getValue helpers to avoid indexing confusion * Pull out confusing condition * Move out getLabel helper * Be more explicit about non-existent config values Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Move setupParameterValuesEndpoints to setup * Add loading state * Do not use alert to implement info box * Fix formatting * Remove undefined from getValue signature * Use getLearnUrl * Remove dependency on column * Make custom field labels work in the absence of fields * Support custom values for non-field parameters * Add test for native question parameters * Add newline in test * Add test case for when show-metabase-links is false * Just fall back to rendering value when fetching label, or in case it failed * Add test for loading state of FormattedParameterValue * Do not fetch custom label for FormattedParameterValue * Add table with ip addresses * Add test for IPAddress filter with custom labels * Add test for custom labels on type/Quantity fields * Remove getInput helper in test * Remove unused hasCustomLabel value * Split up into common and premium tests * Make fieldValues a map for performance --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
- Jul 04, 2024
-
-
Elton Okawa authored
-
Nemanja Glumac authored
-
Case Nelson authored
* fix: param-fields when native model is aggregated Fixes #42829 The param-field lookup required result_metadata to match filterable-columns in order to find parameter targets. This adds a fallback where if the param field is missing from result_metadata, then we look at filterable-columns. * Unskip test
-
adam-james authored
Per discussion in Slack, I made a mistake with the migration IDs as I wanted to backport to 50 but used 51 IDs. This PR uses 50 IDs and places the migrations in the correct place. Not sure if it's mergable in this state because Stats has run with the PR containing the incorrect migration IDs.
-
Alexander Polyankin authored
-
Romeo Van Snick authored
Refine the reproduction for " Entity picker surfaces recent questions that are not valid joins" (#44974) (#45091) * Refine the reproduction for 44794 * Move skip to top-level again * Remove superflouous click * Verify wether or not the recents tab exists and is open * Make the test description more descriptive Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Move question details to a variable --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Braden Shepherdson authored
This works on master, but this reproduction will prevent #38265 from reoccurring.
-
Alexander Polyankin authored
E2E repro for "Editing Column description of Model is confusing if it contains aggregations" (#45113) * Fix checks and tests * Fix checks and tests
-
Uladzimir Havenchyk authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
Reproduce #27643: Field filter linked to Boolean column causes an error when used in Embedding (#45038) * Add a repro for #27643 * Clarify the race condition behavior in the comment
-
- Jul 03, 2024
-
-
Noah Moss authored
-
adam-james authored
* User Parameter Values Are Unique Per Dashboard Fixes: #43001 Might be related: #44858 User Parameter Values previously stored just the `parameter-id` and `user-id` as data to look up the last used parameter value. This isn't sufficient as the parameter id is not guaranteed to be unique, in particular this is true when a dashboard is duplicated: the parameters are copied to the new dashboard without changing the parameter id at all. This means that we need to also store the dashboard-id in the user_parameter_value table and use that to update/get the last used value. The migration removes existing entries to the user_parameter_value table because I want a non-nullable constraint on the dashboard_id column, and existing entries will not have a value. The only way to backfill those values would be to look through every dashboard containing parameters, and for every parameter check for a matching ID. Even if you can do this, there's no way to disambiguate if the same paramter exists on 2 dashboards anyway, so one of them will be wrong. I think it's not worth the trouble considering that removing the entries in this table doesn't break anything; it just becomes a mild inconvenience that a user has to select a filter value again (since the dashboard will use the default value). * alter test to check for uniqueness across dashboard This test makes 2 dashboards with parameters of the same ID and asserts that changing the value on dashboard-a does not change the value on dashboard-b. * adjust migration to pass linter rules * remove the extra rollback on migration * Update src/metabase/models/user_parameter_value.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * Update src/metabase/models/user_parameter_value.clj Co-authored-by:
bryan <bryan.maass@gmail.com> * adjust parameters in test so we don't get logged warnings * put update!/insert! in a transaction to avoid any race conditions --------- Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Cam Saul authored
* Support compiling SQL with inlined parameters directly * Test fix * Make `format-honeysql` a multimethod * Add test for #32543 * Test also fixes #44915 * Add explicit test for #44915 * Better test for #44915 * More test fixes
* Fix Kondo error -
bryan authored
-
github-automation-metabase authored
-
Kamil Mielnik authored
* Optimize: compute chart title href only on mouseenter and focus * Improve comment * Improve comment * Format code * Update existing tests * Extract helpers * Update unit tests * Make getHref argument-less
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* include dark background to PNG exports when night theme is enabled * fix css * override border for png downloads
-
Ngoc Khuat authored
-
Noah Moss authored
-
Braden Shepherdson authored
`Lib.diagnoseExpression` is stricter about this than the QP or FE expression parser, making it reject expressions that tried to compare datetimes to strings like `2024-07-02 14:34:17Z`. Those used to work in 49.x, but a new `Lib.diagnoseExpression` call while editing expressions caused it to regress. Fixes #44916.
-