This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 23, 2024
-
-
Oisin Coveney authored
-
- Oct 22, 2024
-
-
Nemanja Glumac authored
* Add `use-temp-storage` hook * Remove try/catch * Add reducer * Add tests * Use RTK to create a new slice and reducer
-
Aleksandr Lesnenko authored
* improve pie-sunburst chart labels visibility algo * specs, docs * Update Loki Snapshots * handle big arcs > PI with small inner cord --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Alexander Polyankin authored
* Fix native query preview for mongo * Add tests * Add tests * Do not rely on join identity
-
Alexander Polyankin authored
-
Kyle Doherty authored
* add athena and databricks logos + update paths * Add fallback for `druid-jdbc` --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Romeo Van Snick authored
* Fix reference in deprecation notice * Add lock_filled icon * Add view-only tag to the question header for questions with hidden source tables * Simplify the useHasHiddenSourceTables helper * Add typings to useHasHiddenSourceTables * Show 'view-only' badge when the question is not editable * Set up card endpoints * Add test for hidden tables * Add e2e test for View-only tag * Add visibilityType to TableDisplayInfo * Use unfiltered table display info to determine which tables are hidden * Rename util to hooks * Use rem for border-radius * Sign in in beforeEach * Add tests for more visibility types * Fix unit tests * Remove empty file * Add test for unavailable cards * Remove unnecessary card endpoint * Add unit test for inaccessible card * Move ViewOnlyTag to it's own file * Add more unit tests for ViewOnly tag * Use MBQL to create queryies where possible
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Increase the size of the overlay spacer * Increase the delay of the popover opening * Hard-code the popover delays * Remove delay props from info components * Fix unit test * Shorten popover timeout to 500ms * Make popover delay configurable again * Increase openDelay for header info
-
- Oct 21, 2024
-
-
Aleksandr Lesnenko authored
* tweak sunburst chart styles * Update Loki Snapshots * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Oisin Coveney authored
-
Alexander Polyankin authored
* Reset the question's viz settings when converting to a model * Update e2e/test/scenarios/models/reproductions.cy.spec.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Test model metadata * Test model metadata * Test model metadata * Test model metadata --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Kamil Mielnik authored
* Fix #48878 by avoiding to use entity framework which can serve incomplete card objects * Make sure canWrite is a boolean * Remove redundant optional chaining * Add repro for #48878 * Optimize * Improve comment * Fix test setup
-
Romeo Van Snick authored
* Add helper to add utm params to url * Add utm param to getDocsUrl * Allow passing utm to docs url * Add utm parameters to expression widget docs url * Add useUrlWithUtm hook * Make more utm props optional * Use the utm hook and docs hook instead of adding utm tags manually to urls * Simplify getDocsUrl * Update unit tests for expression editor to contain utm params * Only add parameters if they have a value * Fix unit test * Fix unit test * Simplify docs url * Use useDocsUrl on embedding page * Use named arguments in useDocsUrl
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
- Oct 18, 2024
-
-
Cam Saul authored
* Modularize metabase.pulse; add metabase.pulse.core API namespace * Rename metabase.pulse.send-test * Split email result attachment stuff into its own namespace * Update dashboard-subscription-test * Allow metabase.email.result-attachment externally... for now * More code cleanup * Decouple models.card and email.messages * Decouple models.collection and metabase.email.messages * Hopefully the last fix
* Fix #48647 * Fix event handler * :render/text, not :pulse/text * Test fixes * Test fix * RESPECT the modules * Remove unused namespace -
Uladzimir Havenchyk authored
-
Kyle Doherty authored
-
Uladzimir Havenchyk authored
* rework ChartSettings to typescript * lint
-
Aleksandr Lesnenko authored
* hide formatted export description when unformatted * add unformatted copy
-
Anton Kulyk authored
-
Nick Fitzpatrick authored
* cleaning up links, adjusting tests * guard rails * linter fix
-
Aleksandr Lesnenko authored
-
- Oct 17, 2024
-
-
Phoomparin Mano authored
* debug pdf export styling * apply sdk theme background overrides * add overflow override * tweak style overrides * move WithThemeBackground outside of data-metabase-theme selector * move EmbedFrame css rule up * remove fallback mb-color-background
-
Phoomparin Mano authored
* remove defaultProps from Modal * bump patch version of react-markdown * fix isOpen prop
-
Nick Fitzpatrick authored
* adding webhook counter to AlertListItem * PR feedback
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Kamil Mielnik authored
-
- Oct 16, 2024
-
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Don't open sidesheet on SDK dashboards * Add E2E test * Fix `className` not passed * Fix unit tests * Fix E2E tests
-
- Oct 15, 2024
-
-
Raphael Krut-Landau authored
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Add default value for `hiddenIndices` * Add e2e test
-
Uladzimir Havenchyk authored
* fix circular deps in query_builder/components * js -> ts
-
adam-james authored
* Incremental Pivot Processing for Exports WIP Fixes pivot exports for CSV and xlsx. The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row data right away, so the memory overhead becomes only as large as the total pivot result. In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data, but it should behave much better now in most cases. The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a time, and just post-process the sheet to add the pivot table in one shot at the end. * WIP adding row totals. * aggregate totals as rows are added Row, column, section, and grand totals are all aggregated as each row is added. This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further aggregation is needed. * CSV pivot works per-row, export respects formatting This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into the pivot datastructure, which only holds onto: - unique values for each pivot-row in a sorted set - unique values for each pivot-col in a sorted set - grand total for each measure N values, where N is number of measures, ususally 1 or 2 - row totals for each combination of each pivot-row * N measures - col totals for each combination of each pivot-col * N measures - totals for each 'section', determined by unique values of first pivot-row * N measures - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the dataset. We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move forward anyway: - there's now visible feedback in the app that the download is running (or if it's failed) - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to - use/less effective, and will likely be something the user doesn't want (as often). * some test fixes * now, if we export 'raw pivot rows', they don't show pivot-grouping and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0). This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz to a regular table. * remove old test * re-incorporate some changes from master * fix csv for non-pivots due to oversight in my changes This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not. * start moving format_rows to POST bod, add pivot_results too There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions. The tests will not pass on this commit, but fixes will be incoming * native pivot tables in xlsx * add precondition to pass migration linter * try to get migrations fixed * pasing pivot-results through api and attachments * fix tests for format_rows in BODY vs query param * tests! * might have the tests all fixed now * the pivoted export now respects col/row totals settings * add test coverage for public questions and dashboards * col and row totals work as expected * build-pivot refactor for clarity * docstring change + tiny refactor in helper fn * see if dashcard download works with format_rows * csv pivot handles nil values * pass format_rows and pivot_results in :params not :body * fix some other tests * pivot-grouping col filtered out of xlsx * pivot-grouping-col removed for all rows * configurable pivot exports and attachments (#47880) * exports fe * specs * ui * specs * format/unformatted now works for xlsx * format test changes for xlsx formatting * embedding endpoints accept pivot_results * cljfmt and eslint fix * empty * embedding test should have formatting defaulted to true * embed test fixes * Use `Chip` for export settings widget * downloads e2e test fix * fix public download limit test * public card download defaults * fix public download defaults in some tests * Fix visual test --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Romeo Van Snick authored
* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question * Allow visitQuestion to work for metrics * Use visitQuestion in metric test * Add test for #48555 (showing the 'Save as new?' ui for metrics) * Add issue info to repro * Use visitMetric, visitModel and visitQuestion helpers in createQuestion * Move check to make it more clear what the save ui does * Use cy.button for Done button * Remove unnecessary .within * Sign in as normal user * Add missing dataset alias
-
Romeo Van Snick authored
* Rename Common Metrics to Metrics * Rename Basic Metrics to Summaries * Update chill mode button copy to 'Add a summary or metric' * Rename 'Pick the metric you want to see' button to include summary * Fix type in test * Rename Summaries to Basic functions * Fix test * Undo cross-version test changes
-
- Oct 14, 2024
-
-
Raphael Krut-Landau authored
-