* first pass at LDAP setup improvements

* fix lint errors

* fix LDAP api tests

* WIP test for new setting setter

* fix setting test

* set ldap-enabled to true in ldap server macro

* try to fix java11 tests

* Update src/metabase/integrations/ldap.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* add transaction

* remove ldap-ever-enabled? setting and revert some of the logic that is no longer necessary

* set ldap-enabled via the ldap api and add tests

* fix tests and lint

* fix error on settings save

* fix cypress test

* actually fix cypress

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Allow slugs in question template tags, like `{{#123-a-question}}`

* Update CardTagEditor to add slug names to the query text, instead of IDs

* Fix dispatchApiErrorEvent prop for entity object loader

* Ignore errors loading names of referenced questions

* Fix e2e tests

* Implement autocomplete for model slugs

* Prioritize models above questions

* Make the ace_autocomplete popup slightly wider to account for longer question names

* Reorder requires

* Remove unnecessary ? from endpoint string

* Add e2e test for card tag autocomplete

* Fix NativeQueryEditor not swapping back to standard completers

* Refactor replaceCardSlug

* Add e2e test for updating tags when card name is changed

* Refactor updateReferencedQuestionNames

* Add slug method to Question class

* Use map for autocomplete API results

* Rename endpoint path

* Rename for consistency

* Add docstrings

* Update slug() to guard against undefined names

* Fix read permissions for the endpoint

* Add backend test

* Fix unit tests

* Fix permissions error

* Make regex simpler

* Undo change of value on QuestionPicker

* Fix tests

* Fix models e2e test

* Simplify updateReferencedQuestionNames

* Fix bugs in updateReferencedQuestionNames

* Rename variable

* Move NativeQuery methods to new native-query utils module

* Fix typescript errors

* Fix e2e tests

* Fix e2e test

* Fix BE tests

* Actually fix BE test

* Refactor updateQuestionTagNames

* Align comments

* Reorder autocomplete results

* Refactor: move all query text tag utils in one place

* Add tests for regex

* Add unit tests for cardIdFromTagName

* Add schema to autocomplete_suggestions endpoints

* Add perms checks to autocomplete tests

* Add unit test for updateCardTagNames

* Rename updateQuestionTagNames -> updateCardTagNames

* Tidy card-autocomplete-suggestions-test

* Rename questionReference-> cardTag for consistency

* Rename card-reference -> card-tag for consistency

* Use ternary operator for comprehension

* Fix broken swapCompleters

* Use prefix match on name for 123-foo case

* add support for required fields and default values in action forms

* handle missing settings better

* save default numbers as numbers

* Preserve model column metadata in the QUERY_COMPLETED action

* Update metadata everywhere in redux

* Unskip repro

* Tweak isSameField default to get rid of some dup code

* Fix Visualization component handling of mode prop

* Pass mode prop in and give it a gross name

* remove unused static chart types

* add visual tests for single series charts

* support field placeholder customization

* update tests

* Move Variable in its own package

* TemplateTagVariable package created

* memoizeClass return type

* Renaming Query to QueryInner to follow standards

* Constants added to TemplateTagVariable

* Fixed Query typing

* Misc

* Allow overwriting `SidebarLink` name styles

* Add `DataAppPageSidebarLink` component

* Render data app sidebar page tree

* Hide pages marked as hidden

* Add `getParentDataAppPageId` helper

* Highlight parent page when hidden page is selected

* Extract `getSelectedItems` and add tests

* Fix messed up ordering bug

* Remove `DataAppNewButton`

* Add new item menu

* Fix missing click handler

* Use "pencil" icon for new page

* Fix action buttons look

* Extract `DataAppDataPicker` component

* Rename `scaffold` action

* Add `scaffoldNewPages` action

* Add `ScaffoldDataAppPagesModal` component

* Add `DataAppNavItem` type

* Allow building page URLs out of nav items

* Implement "Add data" flow

* Add implicit action click behavior types

* Add `isImplicitActionButton` helper

* Extract `ActionButtonView` component

* Separate implicit and default action buttons

* Use `DashboardOrderedCard` instead of `DashCard`

* Use `Value` type for PK argument

* Fix type error

* Extract `ImplicitActionClickBehavior` type

* Add `ImplicitInsertModal`

* Add `DashCardDataMap` type

* Add dashboard selectors for implicit update/delete

* Add `ImplicitUpdateModal`

* Add `ImplicitDeleteModal`

* Validate implicit actions in `clickBehaviorIsValid`

* Reload page on action instead of a single dash card

* Tweak successful insert toast message

* Fix eslint error

* allow user-defined select options

* Update frontend/src/metabase/writeback/components/ActionCreator/FormCreator/utils.ts

* update input type when changing field type

* handle unset field type

* Exclude implicit joins when virtual card table has an explicit join

* Add unit tests

* Handle small number format

* Hide bar chart values on small bars

This matches the app viz behavior

* [Apps] Add scaffolded pages to existing apps

Reuse app scaffolding in order to add to existing apps. This will not
check that the tables you choose have not been previously added to the app.

Also update scaffolding:
- Add back to list button
- Update list question to order by newest row on top.
- Use linkType: "page" instead of linkType: "dashboard"

* Fix H2 test, no need to add app-id to name

* Remove unused require

* Addressing review comments - suggested test uncovered an ordering bug

* Put priority back to ascending

* Implement navigation between data app pages (#25366)

* Add `DataAppPagePicker`

* Rename `QuestionDashboardPicker`

* Add page to `EntityCustomDestinationClickBehavior`

* Fix comment

* Use ellipsis character

* Fix custom destination type

* Add "page" custom destination to pickers

* Pass router props to dashboard click actions

* Remove not used function arguments

* Implement "page" custom destination click behavior

* Fix "page" click behavior isn't treated as valid

* Reorganize `LinkedEntityPicker`

* Fix drills from the homepage

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

* enforce import order

* reorder all imports

* more import updates

* derive parameter types from form settings on save

* update template tag types with parameter types

* improve tests

* pass action visualization settings to actionParametersInputForm

* Update FieldSchema to store virtual card table fields using both table_id and field id

* Update the metadata selector to look use field's uniqueId property

* Add tableId arg to Metadata.prototype.field method

* Normalize fields in sample_database_fixture

* Fix incorrect e2e test

* Make the second arg of field optional

* Pull out small fn

* Refactoring + clean up + mocks & tests

* Update metadata.field(...) usage in a few places

* Revert FieldDimension change

* Move complex FieldDimension `field` logic to the instantiation of "virtual" fields by the associated query's `table` method (#25109)

* Add merge method to Field

* add new virtual table utils + tests

* Use new utils in implementation of Structured/NativeQuery table methods + remove unneeded Dimension logic

* let all Questions return dependentMetadata

* Fix types related to query.table() potentially returning null

* Fix updateQuestion tests

* Remove unused Dimension imports

* Fix issue resolving rootTable on queries based on virtual tables

* Fallback to the nested card table stored in the Metadata instance

* Make the nested card Table the main driver in returning fields for nested cards + other misc fixes

* more tweaks related to cloned Tables, source queries

* Don't clobber metadata if something is already there (like a method named 'metadata')

* Fix for nested native query

* Don't use real table for source query

* Update table code to use the actual nested card table fields instead of doing merge logic

* Skip an e2e test

* Workaround for getting Dimensions from joins

* Update arg name

* Try removing the Table fetch from Question's dependentMetadata method

* Don't rerun query when converting question to model

* Fix for source query not showing 'previous results'

* Fix unit tests

* Update models e2e tests not to wait on query

* Unskip repro for #23449

* make sure a join's joinedQuery is not a dataset/model

* use createQuestion in e2e test

* don't use Question redux dispatch method for updating

* split test cases

* Add comment

* Move `DataAppNavbar` to its own directory

* Move `MainNavbarContainer` to its own directory

* Move `BookmarksList` to `MainNavbarContainer`

* Extract `getSelectedItems`

* Extract `DataAppActionPanel`