Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 08, 2024
    • Alexander Polyankin's avatar
      Default to `=` operator when `Filtering on this field` is set to `A list of... · f03e6d8c
      Alexander Polyankin authored
      Default to `=` operator when `Filtering on this field` is set to `A list of all values` or `Search box` (#48412)
      
      Unverified
      f03e6d8c
    • Kamil Mielnik's avatar
      [Epic] Search in selection in entity picker (#47755) · f6aab536
      Kamil Mielnik authored
      
      * Maintain selected folder state in Entity Picker (#47309)
      
      * Keep tabs mounted
      
      * Rename TablePicker onChange to onItemSelect to match QuestionPicker and also call it for folders
      
      * Inline small functions
      
      * Remove unused type
      
      * Rename
      
      * Remove TODOs
      
      * Remove duplication
      
      * Reduce diff
      
      * Rename
      
      * Lift state from TabsView
      
      * Remove redundant callback
      
      * Store folder state in DataPickerModal
      
      * Refactor computing tabs
      
      * Consolidate search tab definition with recents tab definition
      
      * Simplify computeInitialTab interface
      
      * Extract RECENTS_CONTEXT
      
      * Store tab state in DataPickerModal
      
      * Propagate initial tab state
      
      * Fix a flicker
      
      * Keep tab state in EntityPickerModal
      
      * Fix typing computeInitialTab
      
      * Remove Notebook prefix
      
      * Pass onItemSelect to individual tabs from EntityPickerModal
      
      * Auto select folder
      
      * Fix types
      
      * Adjust remaining tabs definitions to use render
      
      * Adjust tabs definitions to use render in tests
      
      * Fix inverted condition
      
      * Fix TS error
      
      * Fix types
      
      * Rename EntityTab to EntityPickerTab, TabId to EntityPickerTabId
      
      * Rename EntityTabRenderProps to EntityPickerTabRenderProps
      
      * Separate tab models from tab ids
      
      * ESLint
      
      * ESLint
      
      * Recognize folders inside EntityPickerModal
      
      * Add missing prop
      
      * Remove console.log
      
      * Simplify handleFolderSelect
      
      * Revert changes that will go to a different PR
      
      * Fix unit tests
      
      * Refactor
      
      * Remove keepMounted prop
      
      * Fix type
      
      * Remove useMemo from tabs computation (#47505)
      
      * Extract getTabs for DataPickerModal
      
      * Extract getTabs for EntityPickerModal
      
      * Add explicit return type
      
      * Revert "Add explicit return type"
      
      This reverts commit feb3f58c.
      
      * Revert "Extract getTabs for EntityPickerModal"
      
      This reverts commit 4e875a1f.
      
      * Revert "Extract getTabs for DataPickerModal"
      
      This reverts commit cdda8ea1.
      
      * Remove useMemo
      
      * Maintain tab state in Entity Picker (#47794)
      
      * Store picker path state in data picker modal
      
      * Adjust remaining QuestionPicker usages
      
      * Store collection picker state
      
      * Use dedicated onPathChange prop
      
      * Store dashboard picker state
      
      * Improve naming
      
      * Fix unit tests
      
      * Remove accidental code
      
      * Return to previously opened tab when search input is cleared in Entity Picker (#47798)
      
      * Restore previous tab when clearing search input
      
      * Add a unit test for new behavior
      
      * Update comment
      
      * Don't use effect
      
      * Add more tests
      
      * Reduce diff
      
      * Fix flakes
      
      * Change search input placeholder depending on selected folder & tab in Entity Picker (#47801)
      
      * Make TabFolderState generic, pass folder to EntityPickerSearchInput
      
      * Simplify interface
      
      * Extract getSearchInputPlaceholder
      
      * Reduce diff
      
      * Remove TODO
      
      * Implement it
      
      * Shorten code
      
      * Reduce diff
      
      * Use database to scope search if there's only 1 schema
      
      * Add scoped search in the Search tab in Entity Picker (#47839)
      
      * Cleanup entity picker search types (#48098)
      
      * Add e2e tests for local search in the entity picker (#48122)
      
      * Sync the value back into selectedItem when it changes
      
      * Await element
      
      * Handle empty tabs
      
      * Pick everywhere tab
      
      * Click Everywhere in unit tests
      
      * Use deep equality to sync value
      
      * Sync back the path value to the dashboard too
      
      * Run test as admin to avoid (unrelated) permissions issues
      
      * Filter scoped results too
      
      * Fix post-merge issues
      
      * Fix type issues
      
      * Fix null scoped search results
      
      * Sign in as admin to appease the tests
      
      * Use useDeepCompareEffect when syncing back state
      
      * Add default value for searchResultFilter to avoid double condition
      
      * Avoid using useEffect to sync selectedItem
      
      * Avoid overwriting path in useEnsureCollectionSelected
      
      * Fix e2e test
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Co-authored-by: default avatarRomeo Van Snick <romeo@romeovansnick.be>
      Unverified
      f6aab536
  2. Oct 07, 2024
  3. Oct 05, 2024
  4. Oct 04, 2024
  5. Oct 03, 2024
  6. Oct 02, 2024
    • appleby's avatar
      Add tests for exporting self-joined renamed columns (#48244) · e2b74d79
      appleby authored
      * Add BE test for exporting self-joined renamed columns
      * Add e2e test for exporting self-joined renamed columns
      
      See also
      
      - Not renamed fields in a same table join inherit the renamed name in exports #48046
      - backport: Support both name & field ref-based column keys in viz settings on read and upgrade on write #48243
      Unverified
      e2b74d79
    • Emmad Usmani's avatar
      add sunburst to pie chart (#47208) · 61e610b3
      Emmad Usmani authored
      * add sunburst to pie chart
      
      * fix type errors
      
      * consider all slice percent values for formatting percent on chart
      
      * fix lint error
      
      * refactor nested functions outside of parent
      
      * create and use getArrayFromMapValues helper
      
      * fix bug with percent significant digits
      
      * improve color picker
      
      * fix total visibility in small dashcards
      
      * fix missing field remappings
      
      * use aggregated value for click behavior
      
      * update minimum slice percentage logic
      
      * fix total text truncation
      
      * remove colors from tooltip for middle and outer slices
      
      * update e2e spec
      
      * update snapshot
      
      * update ring setting titles
      
      * address feedback
      
      * update comment
      Unverified
      61e610b3
    • Aleksandr Lesnenko's avatar
    • Emmad Usmani's avatar
      fix aggressive legend truncation (#48207) · 7764892c
      Emmad Usmani authored
      * fix aggressive legend truncation
      
      * add e2e test
      
      * revert LegendVertical changes
      
      * update legendTitles calculation in PieChart
      
      * restore size prop in LegendVertical
      
      * fix e2e test
      Unverified
      7764892c
    • Romeo Van Snick's avatar
      Disable value column on Browse metrics page (#48217) · 3a3785d2
      Romeo Van Snick authored
      * Remove value column from Browse metrics page
      
      * Remove tests for metric values
      
      * Fix markdown test
      Unverified
      3a3785d2
  7. Oct 01, 2024
  8. Sep 30, 2024
  9. Sep 27, 2024
  10. Sep 26, 2024
  11. Sep 25, 2024
Loading