Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 17, 2023
  2. Jul 14, 2023
  3. Jul 13, 2023
  4. Jul 12, 2023
  5. Jul 11, 2023
    • Aleksandr Lesnenko's avatar
      776e9006
    • Kyle Doherty's avatar
      add CODENOTIFY + kdoh entry for design system dir (#32306) · c3a53697
      Kyle Doherty authored
      * add CODEOWNERS + kdoh entry for design system dir
      
      * use CODENOTIFY [ci skip]
      c3a53697
    • Braden Shepherdson's avatar
    • Braden Shepherdson's avatar
      Mechanism for internal use of premium features (#32240) · 793577c8
      Braden Shepherdson authored
      Some premium features (and in theory even non-premium EE features) use
      parts of others, and the token might not have those other features
      enabled.
      
      This mechanism allows dynamically overriding the set of features the
      token is considered to have, enabling eg. `:audit-app` code to use
      `:serialization` internally even if the user's token doesn't support
      `:serialization`.
      
      ```clojure
      (premium-features/with-premium-feature-overiddes [:foo :bar]
        (has-feature? :foo)) ;=> true
      ```
      793577c8
    • Nemanja Glumac's avatar
      [E2E] Fix failing audit tests (#32289) · 8338a86e
      Nemanja Glumac authored
      The failure was caused by the change in the token activation logic in E2E tests.
      Most likely because #32186 was longer in queue than #32212.
      
      By the time #32212 landed, E2E tests were still starting with the full premium token active by default.
      #32186 changed that and that's when we see the first failure for this test.
      8338a86e
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Allow downloading native query results even after the query has changed (#32251) · 26b1a6b6
      Mahatthana (Kelvin) Nomsawadi authored
      * Organize tests to make them easier to follow
      
      * Allow downloading query result even after the native query has changed
      
      * Add ad-hoc question test
      
      * Address review: Group rendering tests together
      
      * Addrsess review: Add comment regarding tests living in different files
      26b1a6b6
    • Ngoc Khuat's avatar
      Expose new feature flags (#32250) · d39a6d4f
      Ngoc Khuat authored
      * expose new feature flags: :official_collections, :snippets_collections, :disable_password_login
      d39a6d4f
    • Nemanja Glumac's avatar
      Overhaul E2E tests token activation logic (#32186) · a54b3dc6
      Nemanja Glumac authored
      
      * Start all tests without a token
      
      * Update tests
      
      * Fix tests in `admin` group
      
      * Fix tests in `dashboard-filters` group
      
      * Fix tests `visualizations` group
      
      * Batch fixes
      
      * Fix database banner snowplow test
      
      * Fix full-app mobile view banner test
      
      * Simplify and remove `isPremiumActive` check
      
      * Fix the helper
      
      * Fix helper to fail fast
      
      * Fix tests
      
      * Ensure token scope is set
      
      * Ensure CYPRESS_ env tokens are present
      
      * Set token only if running Metabase ee
      
      * Improve JSDoc
      
      * Slightly tweak log message
      
      * Update E2E dev guide
      
      * Update cross-version tests
      
      * Remove premium token from Cypress backend setup
      
      * Improve a comment
      
      * Fix test
      
      * Update embedding copy
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      a54b3dc6
    • Diego Rocha's avatar
      Fix dashboard scroll jank when there are no filters (#32245) · 2fe7b83b
      Diego Rocha authored
      * Fix dashboard scroll jank is some cases
      
      The behavior defined by stickyParameters.js was updating the dashboard's parametersWidgetOffsetTop state with undefined at every scroll event, causing jank. This was caused by mistakenly assuming that a dashboard component always has its parametersWidgetRef set to something other than an empty React ref, when in fact it can be null when the dashboard has no filters. This changes also fix how a React ref is used to make parametersWidgetRef reference the HTMLElement the parameters widget.
      
      * Remove initializeWidgetOffsetTop altogether
      2fe7b83b
  6. Jul 10, 2023
Loading