This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 13, 2022
-
-
Cam Saul authored
-
Cam Saul authored
* Unrelated fix: app DB data source should assume default host/port for MySQL/Postgres * Remove stray println
-
Noah Moss authored
-
Ikko Ashimine authored
enviornment -> environment
-
- Oct 12, 2022
-
-
Cam Saul authored
* Add CLI SerDes command for seeding entity IDs (#25655) * Remove stray comment * Fix Kondo error * Fix Eastwood error * Update identity-hash-fields to multimethod for ModelAction * Fix identity-hash-fields for Dimension and DashboardCardSeries
-
metamben authored
* Return models used in scaffolding in GET /app/:id * Return models added to an app page * Return models referenced by queries on app pages
-
Case Nelson authored
* [Apps] Small scaffolding bug fixes Detail Object should use dimension target List link should use pk-field-name * Fix test - ordered_cards behaving oddly * source id should be pk-field name
-
Braden Shepherdson authored
These changes resulted from the effort to serialize and deserialize some collections from our internal Stats instance, which did not (de)serialize correctly out of the box. The main improvement is more robust "escape" analysis - making sure that all dashboards, cards, models, etc. required by the curated collections actually belong to those curated collections. (Many cards on Stats were actually in people's personal collections and publicly readable - that doesn't work with the curated git workflow.) This adds some new tests, trying to capture some complex MBQL queries and make sure they're correctly (de)serialized.
-
- Oct 11, 2022
-
-
Case Nelson authored
* [Apps] Scaffolding cleanup * Make the back to list button bigger so it doesn't wrap on some screens * Remove the Query prefix from cards * Increase size of list and detail cards to 18x12
-
Case Nelson authored
When scaffolding, we should be automatically adding the insert,update,delete implicit actions. * Add order by on test Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Case Nelson authored
* [Apps] Model Actions Adding migration and endpoints for model_action. * model action execution Changing the execution endpoints again, still working on implicit action execution tests. Need to also test the parameters fetch. * Re-add execution route for dashcard action_id until Front End catches up * Add name to model_action GET * Hydrate model-action on dashcards * Rename and combine hydration of model_action to action * Implicit action execution support. Use slug columns as parameter ids * Go through model-action when using GET /action * FE integration fixes * Move action execution to use new parameter shape Now, parameters should be a map of parameter-id to value Parameter-id should be mapped on the FE. So the action parameter-id not the unmapped dashboard parameter-id. * Bring ModelAction into copy code * Generate target of implicit actions to match http actions * Update action test to place action on model * Add unique constraint to model_action for (card_id, slug) * Add missing require * model_action.slug needs to be varchar for mysql constraint * Fix test from unique constraint * Consistent ordering for tests * Addressing Code Reviews and Scaffold changes * Add type: implicit to implicit model actions * Update src/metabase/api/model_action.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Allow changing card_id with PUT to dashcard for model-actions * Update tests after merge * Fix implicit delete and add better test coverage * Addressing review changes Add PUT test Add schema for dashboard-id and dashcard-id params Fix select ordering in test * Model Actions: Frontend (#25646) * save actions in models * list model actions on detail page (#25648) * Link Dashcards to model-based actions (#25770) * Link dashcards to model-based actions * address review comments * Data apps model actions implicit creator (#25807) * Link dashcards to model-based actions * address review comments * Link dashcards to model-based actions * Allow implicit actions to be used like explicit ones * address review comments Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Aleksandr Lesnenko authored
* support static row chart on the backend * update and add types * update types * add chart columns helper, dataset grouping * add viz settings helpers * fix text measuring * add generic row chart component for static and dynamic rendering * update deps * fix jest config for d3 * allow importing cljs in static viz * add a hook for getting chart columns and series * add a static row chart * build cljs before static viz * specs * add stories, moved isomorphic row chart component to the shared folder * update import * fix backend merge * remove an extra line * one more extra line * exclude unused props from the row chart * cleanup * review * fix types * fix log scale * add visual spec, fix goal label truncate * review * fix mock path * fix specs
-
- Oct 07, 2022
-
-
metamben authored
* Implement per group and per db app permissions
-
metamben authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Basic static gauge chart * Add gauge segment min max labels * Add gauge segment label * Cleanup code * Fix React list key error * Remove hard-coded colors * Make the everything calculates at the gauge center * Make gauge segment data easier to understand * Example scaling chart to avoid label overflow * Avoid long labels overflow by scaling the gauge chart down * Match gauge needle color with the design * Fix hard coded gauge segment label anchor calculation * Fix static gauge chart not rotate gauge needle correctly * Add E2E for static gauge chart * Fix `transform-origin: center` not working with BE static chart * Truncate long segment label so charts can never be too small * Fix gauge segment not connected to each other * Static chart refactor part 1 * Final static gauge chart refactoring * Simplify clojure chart render function * Fix relative imports * Make overlapping gauge labels more legible * Make GaugeLabelData property orders consistent * Make a function easier to read * Make the calculation more correct though the behavior would still be the same * Separate presentational component out of the Gauge component * Remove unused tap> * Fix gauge chart not working on chart tester in internal static viz page * Fix gauge chart not rendered with Lato font * Improve internal page static chart tester option clarity * Support column settings in gauge charts * Add unit tests for static gauge chart utils * Address review * Fix unittest failure
-
Braden Shepherdson authored
The value is reconstructed on the deserialization side based on the time of deserialization. For the git workflow, `updated_at` makes for a lot of diffs of unrelated files.
-
- Oct 06, 2022
-
-
Noah Moss authored
* draft fix * test * revert change to email testing helper to fix tests
-
Noah Moss authored
* disable following redirects * add type hint
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix static viz not rendering Lato font * Move function re font registering to metabase.pulse.render.style namespace
-
- Oct 05, 2022
-
-
Noah Moss authored
* Add UUID param to version info checks * add test and minor tweaks * Update test/metabase/task/upgrade_checks_test.clj Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * add is-prod check Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Tim Macdonald authored
[Fixes #25704]
-
- Oct 04, 2022
- Oct 03, 2022
-
-
Cal Herries authored
* Remove the title from all panes and put it in the sidebar header component, next to the back button * Return cards with db metadata * Load all questions into DatabaseTablesPane * Only load questions from the selected database * Create ModelPane * remove mapDispatchToProps * Style ModelPane and reuse FieldPane for model fields * Use FieldList for TablePane and ModelPane * Load connected tables * Create ConnectedTablesList * Restyle DatabaseTablesPane * Adjust styles * smaller ModelPaneIcon * ModelPaneText font weights * description spacing * icon colors and spacing * appease the linter for real * Only load models for a given database * Add model ID next to each model * Remove TODO * Undo changes to database api * Refactor files * Add _target="blank" for model "See it" link * Pluralize copy * Fix i18n * Change back TablePane from tsx -> jsx * Tidy * Don't show models if there aren't any * Tidy (consistency) * Add BE tests * Do a read-check for the database * Revert "Add BE tests" This reverts commit 8d18f4e12636e32fda2b5b670124d69237fce5bd. * Revert "Only load models for a given database" This reverts commit 028ba43f20d55fef0aaf484d3557e75ae5501758. * Change endpoint to database/:id/models * Tidy * Use name in SQL, not display name * Add e2e test for models pane * Tidy * Fix e2e test - no more "back" text after redesign * Convert SchemaPane to tsx * Revert "Do a read-check for the database" This reverts commit 550fc0eb31268d204b6dc7c853b9d2fc7ad50ecc. * Fix endpoint for nil edit info * Fix listQuestions path * Rename test * Remove prn * Batch of suggested changes * Convert ModelPane to typescript * Convert to tsx * Replace any * Tidy * Add permissions tests for GET api/database/:id/models * Remove redundant code * Fix typecheck error for getQuestionFromCard * Rename models -> sortedModels * Remove comment * Use useMemo * Remove /api/database/:id/models endpoint, use api/search instead * Correct docstring * Remove separate listModelsForDatabase endpoint Co-authored-by:
Maz Ameli <maz@metabase.com>
-
- Sep 30, 2022
-
-
Bryan Maass authored
* untangled date time ranges (and filters) * more tests for relative dates * Update test/metabase/driver/common/parameters/dates_test.clj Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> * respond to review + remove an extra tap> * remove java time * with-clock is not allowed inside parallel tests. Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Cam Saul authored
-
Tim Macdonald authored
-
- Sep 29, 2022
-
-
Cam Saul authored
* Make Database details NOT NULL; add defaults for Database created_at and updated_at * Add default value for `:details` to SerDes load-xform * Fix MySQL UTF-8 test
-
Cam Saul authored
* Reset changes and go thru everything again to make sure it makes sense * Test fixes
-
Cam Saul authored
Destroy open connections when resetting app DB; add `ReentrantReadWriteLock` around app DB `getConnection` (#21664) * Destroy open connections when resetting app DB * Use no-op dummy app DB * Ok, don't shut down the app DB because it breaks in-memory app DBs * Stop/start task scheduler * Test fix ? * Another test fix
* Simplified impl * Revert task changes * Fix connection-pool destroying code * Use ReentrantReadWriteLock for simpler implementation * More doc -
dpsutton authored
* indentation only * Fix creation check for mysql * Test that all persisting dbs can persist * Erran tap> (whoops)
-
Cam Saul authored
* `POST /api.ee/serialization/serialize/data-model` endpoint * Sort namespaces * Don't use `tru` for endpoint params validation
-
Ngoc Khuat authored
-
- Sep 28, 2022
-
-
Ngoc Khuat authored
* Implement advanced date/time/zone manipulation, part 1 Incorporate new functions into MBQL and add tests: - get-year - get-quarter - get-month - get-day - get-day-of-week - get-hour - get-minute - get-second * Fix BigQuery implementations to call extract Mark as not supported in legacy driver * Add date extraction fns for Postgres * Disable in MongoDB (for now at least) Disable in BigQuery (legacy driver) Add implementations for presto-jdbc * Misc cleanup from Jeff's PR * Update Jeff's implementation of bigquery-cloud-sqk * Reorganized tests * Mongo * Oracle * Sqlserver * Sqlite * Add casting supports for presto * Remove Jeff's implementation of presto-jdbc because its parent is sql-jdbc * Update presto-jdbc tests to use the same catalog for all datasets * Add date extraction functions to the expression editor (#25382) * make sure the semantic type of aggregated columns are integer * no recursive call in annotate for date-extract func * get-unit -> temporal-extract(column, unit) * desguar nested datetime extraction too
-
- Sep 27, 2022
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor static waterfall chart to use a single entrypoint * Consolidate static watetrfall chart * Update waterfall chart text size to match combo-chart * Move `<Values />` from XYChart/ to be under components/ Since it'll be used by waterfall chart * Fix `<Values />` key error (forgot to add key attribute) * Show data point values on waterfall chart * Fix failed BE tests * Fix test -> wrong `waterfall-type` used. And test both types The waterfall component was changed to take a type argument, instead of having 2 functions for nearly identical output. The failing test just passed the wrong string to the key argument. * Change waterfall keys from strings to Clojure keys * Remove redundant test. Categorical also handled in `waterfall-test` * Fix clj-kondo lint error * Cleanup conditional statements * Miscellaneous code cleanup * Update waterfall test to render data point values * Fix waterfall chart data point values not center in the bar * Make some API for static waterfall chart with total saner Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
- Sep 26, 2022
-
-
metamben authored
* Implement DB specific execution permissions Separate execution permissions from data permissions as a new dimension like application features. Create a new endpoint for getting and setting these permissions.
-
dpsutton authored
* Substitute persisted queries in parameter card references ```sql select o.total, o.quantity, model_p.category, model_p.title from orders o left join {{#14-pg-products}} model_p -- reference to products model on o.product_id = model_p.id limit 4 ``` Testing: I'm unhappy with how verbose the test is. At some point we're going to need a better, standardized way to test persistence. But the test makes a persisted table of the test-data.categories table (test/metabase/test/data/dataset_definitions/test-data.edn). It runs some sql to update the values in the table to turn `"Winery"` -> `"Winery from cached table"`, joins the two tables together to have both at once. There's a lot of moving pieces and the setup is a bit verbose. There's also no obvious place where these types of tests should go. We'll need to consolidate them in the future (and extend them). * persisted macro * docstring for `persisted-info-native-query` * alignments and small nits * Reuse persistence macro * clj-kondo cleanups * remove clj-kondo change before rebase
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
- Sep 23, 2022
-
-
metamben authored
* Introduce /execution/ permission
-