Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 11, 2022
  2. Jul 09, 2022
    • Howon Lee's avatar
      22732 rework (#23722) · b6158cf2
      Howon Lee authored
      Pursuant to reopening of #22732.
      
      Proximate cause is occasional Java bigints getting in where the types assume it'll only be Clojure bigints. On the current reproduction I have it fixes the bug but I am still determining ultimate cause and if there are other phenomena. There was also differential behavior of backport vs. on-master implementation which I still don't understand.
      
      This one needs some sync to have gone through, or else it will prehistoric empetuses towards decelization
      b6158cf2
  3. Jul 08, 2022
  4. Jul 07, 2022
    • Nemanja Glumac's avatar
    • Maz Ameli's avatar
      change column selection icon (#23764) · 17b78885
      Maz Ameli authored
      17b78885
    • dpsutton's avatar
      Include a link to cloud ip address docs in database admin screen (#23767) · 0e34105f
      dpsutton authored
      When `(premium-features/is-hosted?)` is true (IE, in the cloud) we
      display some information about whitelisted ip addresses on the database
      admin screen.
      
      > If your database is behind a firewall, you may need to allow connections from our Metabase Cloud
      > IP addresses: 18.207.81.126 - 3.211.20.157 - 50.17.234.169
      
      A previous change interpreted this text as markdown so now we can
      include the link here.
      
      One problem is that this markdown is a translated string. So we're gonna
      need this markdown duplicated into all of our other languages. And those
      will point to english documentation. Not sure if there's a great
      solution there.
      
      For testing:
      
      If you want to see this in the app, edit public settings cloud-gateway-ips:
      
      ```clojure
      (defsetting cloud-gateway-ips
        (deferred-tru "Metabase Cloud gateway IP addresses, to configure connections to DBs behind firewalls")
        :visibility :public
        :type       :json
        :setter     :none
        :getter     (fn []
                      (when #_(premium-features/is-hosted?) true
                        (fetch-cloud-gateway-ips-fn))))
      ```
      
      And then go to admin > databases and edit a db or start to create a new one
      0e34105f
Loading