Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 10, 2023
  2. Nov 09, 2023
    • Cam Saul's avatar
    • Cam Saul's avatar
    • Mark Bastian's avatar
      Fix slow back button x-ray flakes (#35387) · 8e9f0289
      Mark Bastian authored
      * Attempting to fix x-ray back timeout issues with smaller card count
      
      It looks like the flakes on https://www.deploysentinel.com/ci/analysis?tab=flake for "dashboard back navigation should display a back to the dashboard button in table x-ray dashboards" and "dashboard back navigation should display a back to the dashboard button in model x-ray dashboards" frequently fail at the `cy.wait("@dataset")` stage. I'm guessing this is because the dashboard code is so slow. This PR limits the number of cards produce to `MAX_CARDS` (5) in order to speed up card generation and help with the flakes.
      
      * Adding a timeout to slow x-rays for back button. Hopefully, the small number of max cards makes this unnecessary, though.
      
      * Bumped timeout to 15s instead of 5s. Looks like it was already 5. Again, hopefully the change to minimized the number of generated cards will fix this flake and not take as long.
      
      * Fixing the `show` query param for x-rays
      
      `show` in `core` can be either `:all` or an integer. However, the API layer only exposes the `:all` or `nil` options. This PR exposes the integer path as well.
      
      Note that this is incremental to get flakes working faster. I'll still need to add API tests for this.
      
      * Adding API unit tests to `metabase.api.automagic-dashboards-test` for `show` cases.
      
      * Fixed deftest name to be unique.
      
      * Fixing reference to new card in flaky test
      8e9f0289
    • Cam Saul's avatar
      Test for #11210 (#35520) · 1852be04
      Cam Saul authored
      1852be04
    • Cal Herries's avatar
  3. Nov 08, 2023
  4. Nov 07, 2023
  5. Nov 06, 2023
  6. Nov 04, 2023
  7. Nov 03, 2023
    • Mark Bastian's avatar
      Fixing x-rays with custom columns (#16680) (#35336) · 5f02f323
      Mark Bastian authored
      * Fixing x-rays with custom columns (#16680)
      
      Queries with custom columns were broken for two reasons:
      - When names were computed for display, the humanization code expected fields
      - The generated dashcard queries did not preserve the base query's custom expression definitions
      
      For the first point, the code in `metabase.automagic-dashboards.names` was generalized for both fields and expressions.
      
      For the second, the logic that was formerly `preserve-joins` in `metabase.automagic-dashboards.core` has been generalized to `preserve-entity-element` and applied to both joins and expressions.
      
      * Renamed innner `splice-joins` to `splice-elements`
      
      * Updating `preserve-entity-element` to retain any existing element that is already present in the old query.
      
      * Reinstated inline tru strings such as "is less than" so they can be internationalized.
      
      * Added e2e test
      
      * Adding .click() to e2e test.
      5f02f323
    • Oisin Coveney's avatar
  8. Nov 02, 2023
    • Ngoc Khuat's avatar
    • Nick Fitzpatrick's avatar
      Add remove columns panel (#34087) · c593fecd
      Nick Fitzpatrick authored
      
      * temp
      
      * Mostly functional. Still needs cleanup
      
      * cleanup
      
      * hide from table header
      
      * resolving type disputes. adding icon prop to column item
      
      * e2e tests passing
      
      * temp
      
      * branch cleanup
      
      * Fe linter and unit tests
      
      * e2e adjustments
      
      * PR Feedback
      
      * fix unit test
      
      * Hide Viz Settings Buttons in Column Headers in Raw Table Mode (#35114)
      
      * e2e adjustments
      
      * don't show viz settings actions on raw table view
      
      * better prop handling
      
      * Adding e2e test
      
      * updating selector
      
      * more e2e adjustments
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      
      * e2e updates
      
      * removing comment
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      c593fecd
    • Mark Bastian's avatar
      Preserve join aliases in dashcard queries (fixes 25278 & 32557) (#35267) · a5a98a59
      Mark Bastian authored
      * Preserve join aliases in dashcard queries (fixes 25278 & 32557)
      
      In `query-based-analysis` the final stage was to `maybe-enrich-joins`
      to add in joins defined in the query being x-rayed into the dashcard
      query. In some cases (e.g. cell queries), the trigger to detect this
      addition isn't known as the filters are added downstream.
      
      This PR always adds in the join aliases if they are present since
      they should be harmless if not needed and you can't know if they are
      needed downstream as the code is currently designed.
      
      The tests assert not only that the cards are created, but that the
      filter is present and executable (these previously errored out).
      
      * lint fix
      
      * Squashing `splice-in` into `preserve-joins` and adding some better test criteria for `generate-dashboard-pipeline-test`.
      a5a98a59
  9. Nov 01, 2023
  10. Oct 31, 2023
    • Ngoc Khuat's avatar
    • Cam Saul's avatar
    • Cam Saul's avatar
      Implement geo zoom drill (#34822) · 0e09ac7a
      Cam Saul authored
      0e09ac7a
    • John Swanson's avatar
      Make `SESSION_COOKIE_SAMESITE` a setting (#35021) · baa5d2d4
      John Swanson authored
      * Make `SESSION_COOKIE_SAMESITE` a setting
      
      Considerations here:
      
      - I didn't want to break the existing behavior, which allows the env var to be case insensitive. This required a bit
      of weirdness in the getter/setter - we get the *raw* value, then normalize it to a keyword, then make sure it's one of
      the valid options.
      
      - I'm not sure what the best practice is regarding i18n - I just went off the existing code, but I'm not entirely sure
      whether I need to also add translations to the `locales/*.po` files, and how I get those translations if
      so (err... chatGPT?).
      
      - permissions: I'm not exactly sure how we decide between the `:settings-manager` and `:admin` settings. I went with
      `:settings-manager` here.
      
      - I'm not sure whether the frontend has its own definitions of possible values for set-based settings, or if I need to
      expose that somehow?
      
      The existing tests were good, easily adapted to the new behavior, and caught the above-mentioned backwards
      incompatibility issue with case insensitivity.
      baa5d2d4
    • Nicolò Pretto's avatar
      Move card to tab - analytics event (#35151) · c10a995f
      Nicolò Pretto authored
      * move cards analytics event, closes #35123
      
      * change test to check specific analytics event
      
      * fix version in schema
      
      * update src/metabase/analytics/snowplow.clj with 1-1-2 schema version
      
      * update all dashboard schema events to use version 1-1-2
      
      * refactor: exctracted "DASHBOARD_SCHEMA_VERSION" variable
      
      * refactor: use camelCase for local constant
      c10a995f
    • Cal Herries's avatar
      1c69bc24
Loading