This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 10, 2023
-
-
John Swanson authored
When a card or dashboard is pinned, the entity itself is not changing, so let's not send the `:event/card-update` or `:event/dashboard-update` events in these cases.
-
Alexander Solovyov authored
Cards are not touched, just DashboardCards and DashboardTabs are synchronized with loaded data
-
Cal Herries authored
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
Cal Herries authored
-
Alexander Solovyov authored
keys in serialization are be sorted by historical order first and alphabetically if they are not mentioned
-
- Nov 09, 2023
-
-
Cam Saul authored
-
Cam Saul authored
-
Mark Bastian authored
* Attempting to fix x-ray back timeout issues with smaller card count It looks like the flakes on https://www.deploysentinel.com/ci/analysis?tab=flake for "dashboard back navigation should display a back to the dashboard button in table x-ray dashboards" and "dashboard back navigation should display a back to the dashboard button in model x-ray dashboards" frequently fail at the `cy.wait("@dataset")` stage. I'm guessing this is because the dashboard code is so slow. This PR limits the number of cards produce to `MAX_CARDS` (5) in order to speed up card generation and help with the flakes. * Adding a timeout to slow x-rays for back button. Hopefully, the small number of max cards makes this unnecessary, though. * Bumped timeout to 15s instead of 5s. Looks like it was already 5. Again, hopefully the change to minimized the number of generated cards will fix this flake and not take as long. * Fixing the `show` query param for x-rays `show` in `core` can be either `:all` or an integer. However, the API layer only exposes the `:all` or `nil` options. This PR exposes the integer path as well. Note that this is incremental to get flakes working faster. I'll still need to add API tests for this. * Adding API unit tests to `metabase.api.automagic-dashboards-test` for `show` cases. * Fixed deftest name to be unique. * Fixing reference to new card in flaky test
-
Cam Saul authored
-
Cal Herries authored
-
- Nov 08, 2023
-
-
Braden Shepherdson authored
This greatly improves the performance of `ML.display_info`, which is taking a lot of the cumulative time in the various MLv2 slowdown bugs recently: #35205, #25296.
-
Noah Moss authored
-
Mark Bastian authored
* Fixing dropdown filter value GET #32126 When GET "/:id/params/:param-key/values" is invoked, the endpoint looks for valid values to populate for the filter dropdowns using the resolved field-ids for the underlying item in the dashboard. In some cases, such as nested queries, the field is not referenced by id, but using the field name. This PR adds a branch that will look for fields by field ref (e.g. `[:field "SOURCE" {:base-type :type/Text}]`) if the field cannot be resolved by id. Fixes #32126 * lint fix
-
Noah Moss authored
Co-authored-by:
Ryan Laurie <iethree@gmail.com> Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Braden Shepherdson authored
-
Serge Klochkov authored
* Add ->temporal-unit multimethod * Change the method name and add a test * Fix substitution.clj indentation
-
- Nov 07, 2023
-
-
Cam Saul authored
-
Cal Herries authored
-
Ngoc Khuat authored
-
Case Nelson authored
* [MLv2] Format brush filter display names Also better localize and handle any passed in offset date times. * Update shared/src/metabase/shared/util/internal/time.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update shared/src/metabase/shared/util/internal/time.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Address PR feedback, shared.util.time requires public-settings so have to require common directly --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Nov 06, 2023
-
-
Cam Saul authored
-
Case Nelson authored
* [MLv2] Add card-or-table-id Fixes #35257 * Address pr comments, rename to legacy-card-or-table-id
-
Braden Shepherdson authored
Fixes #35152
-
Cal Herries authored
-
- Nov 04, 2023
-
-
metamben authored
-
- Nov 03, 2023
-
-
Mark Bastian authored
* Fixing x-rays with custom columns (#16680) Queries with custom columns were broken for two reasons: - When names were computed for display, the humanization code expected fields - The generated dashcard queries did not preserve the base query's custom expression definitions For the first point, the code in `metabase.automagic-dashboards.names` was generalized for both fields and expressions. For the second, the logic that was formerly `preserve-joins` in `metabase.automagic-dashboards.core` has been generalized to `preserve-entity-element` and applied to both joins and expressions. * Renamed innner `splice-joins` to `splice-elements` * Updating `preserve-entity-element` to retain any existing element that is already present in the old query. * Reinstated inline tru strings such as "is less than" so they can be internationalized. * Added e2e test * Adding .click() to e2e test.
-
Oisin Coveney authored
-
- Nov 02, 2023
-
-
Ngoc Khuat authored
-
Nick Fitzpatrick authored
* temp * Mostly functional. Still needs cleanup * cleanup * hide from table header * resolving type disputes. adding icon prop to column item * e2e tests passing * temp * branch cleanup * Fe linter and unit tests * e2e adjustments * PR Feedback * fix unit test * Hide Viz Settings Buttons in Column Headers in Raw Table Mode (#35114) * e2e adjustments * don't show viz settings actions on raw table view * better prop handling * Adding e2e test * updating selector * more e2e adjustments --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com> * e2e updates * removing comment --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Mark Bastian authored
* Preserve join aliases in dashcard queries (fixes 25278 & 32557) In `query-based-analysis` the final stage was to `maybe-enrich-joins` to add in joins defined in the query being x-rayed into the dashcard query. In some cases (e.g. cell queries), the trigger to detect this addition isn't known as the filters are added downstream. This PR always adds in the join aliases if they are present since they should be harmless if not needed and you can't know if they are needed downstream as the code is currently designed. The tests assert not only that the cards are created, but that the filter is present and executable (these previously errored out). * lint fix * Squashing `splice-in` into `preserve-joins` and adding some better test criteria for `generate-dashboard-pipeline-test`.
-
- Nov 01, 2023
-
-
Ngoc Khuat authored
-
lbrdnk authored
-
- Oct 31, 2023
-
-
Ngoc Khuat authored
-
Cam Saul authored
-
Cam Saul authored
-
John Swanson authored
* Make `SESSION_COOKIE_SAMESITE` a setting Considerations here: - I didn't want to break the existing behavior, which allows the env var to be case insensitive. This required a bit of weirdness in the getter/setter - we get the *raw* value, then normalize it to a keyword, then make sure it's one of the valid options. - I'm not sure what the best practice is regarding i18n - I just went off the existing code, but I'm not entirely sure whether I need to also add translations to the `locales/*.po` files, and how I get those translations if so (err... chatGPT?). - permissions: I'm not exactly sure how we decide between the `:settings-manager` and `:admin` settings. I went with `:settings-manager` here. - I'm not sure whether the frontend has its own definitions of possible values for set-based settings, or if I need to expose that somehow? The existing tests were good, easily adapted to the new behavior, and caught the above-mentioned backwards incompatibility issue with case insensitivity.
-
Nicolò Pretto authored
* move cards analytics event, closes #35123 * change test to check specific analytics event * fix version in schema * update src/metabase/analytics/snowplow.clj with 1-1-2 schema version * update all dashboard schema events to use version 1-1-2 * refactor: exctracted "DASHBOARD_SCHEMA_VERSION" variable * refactor: use camelCase for local constant
-
Cal Herries authored
-