Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 13, 2024
    • Phoomparin Mano's avatar
      feat(sdk): add visual cues in sdk around evaluation usage and feature flags (#47821) · c7bd308b
      Phoomparin Mano authored
      
      * add license problem hook
      
      * add warning banner
      
      * style cue component
      
      * update cue component
      
      * report issue to console
      
      * report issue to console
      
      * use sdk loader for pre-initialization
      
      * extract print problem method
      
      * use non-standard shadows
      
      * add unit tests
      
      * prevent console log spam during tests
      
      * mock the embedding token feature
      
      * mock the embedding token feature by default
      
      * add more test cases
      
      * add test case
      
      * add test cases
      
      * increase popover z-index
      
      * simplify test setup
      
      * simplify test setup
      
      * do not load individual component when a license error happens
      
      * move SdkLicenseProblemDisplay component out
      
      * replace colors with color-mix
      
      * replace colors with color-mix
      
      * make the text unthemed to ensure legibility
      
      * hard-code colors to prevent them from being themed
      
      * hard-code colors to prevent them from being themed
      
      * update border styles
      
      * make the chevron unthemed
      
      * unset console text color
      
      * only set stroke on errors
      
      * optimistic query settings
      
      * document the sdk license condition
      
      * remove redundant condition
      
      * add notes on api keys always being allowed on localhost
      
      * move the no auth method message to warning component
      
      * rename sdk license problem to usage problem
      
      * add eslint rule for stories
      
      * rename sdk license problem to usage problem
      
      * move sdk usage problem display out of the init controller
      
      * specify fallback font if instance is down or CORS error
      
      * add comments on conditions pending on the CORS PR
      
      * add notes on non-localhost checks
      
      * make test ids constant
      
      * add test case for neither provided
      
      * fix types
      
      * address code reviews
      
      * pass `embedding-sdk` flag in `token-features`
      
      * address code review
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * remove appName from console logs
      
      * rename embedding-sdk to embedding_sdk
      
      * add the embedding_sdk premium token feature
      
      * do not setup enterprise plugin in sdk test
      
      * do not localize visual cue messages
      
      * fix unit test in setup-sdk-auth
      
      * rename tests
      
      * remove unused eslint-disable
      
      * enable embedding_sdk premium feature for sdk unit tests
      
      * revert security_test.clj to use embedding instead of embedding-sdk
      
      * remove unneeded test
      
      * changes to support the style leak fixes
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      c7bd308b
    • Nicolò Pretto's avatar
      first iteration to scope sdk styles to our components (#47764) · e07e28ee
      Nicolò Pretto authored
      
      * first iteration to scope sdk styles to our components
      
      * basic css reset for buttons
      
      * clean up duplicated css
      
      * make sdk components use instance font if no font is passed
      
      * cleanin up and remove defaultProps not needed
      
      * fix tests
      
      * adds EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID
      
      * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx
      
      * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * fix import
      
      * prettier --write
      
      * we don't need theme.fontFamily, added a comment
      
      * rename EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID to EMBEDDING_SDK_PORTAL_ROOT_ELEMENT_ID
      
      * fix unit test
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      e07e28ee
    • Ryan Laurie's avatar
      Dashboard Info Sidebar (#47893) · 677afd79
      Ryan Laurie authored
      * Dashboard Info Sidebar
      
      * e2e test updates
      
      * add unit tests
      
      * e2e test updates
      
      * fix e2e tests
      
      * fix more e2e tests
      
      * update back behavior
      Unverified
      677afd79
  2. Sep 09, 2024
  3. Sep 05, 2024
  4. Sep 03, 2024
    • Anton Kulyk's avatar
      Toggle series visibility from chart legend (cartesian charts) (#47089) · 57fe9712
      Anton Kulyk authored
      
      * Move current click handler to legend title
      
      * Add `onToggleSeriesVisibility` prop to `Legend`
      
      * Update `LegendItemDot` component
      
      * Update `LegendItemTitle`
      
      * Toggle series visibility
      
      * Fix hover effect
      
      * Don't let to hide the last visible series
      
      * Add `visible` property to `BaseSeriesModel`
      
      * Fix dangling split axis label when hiding a series
      
      * Update `graph.series_order` viz setting widget
      
      * Fix can't toggle series visibility from legend popover
      
      * Fix legend dot clipped by `overflow: hidden`
      
      * Fix eslint error
      
      * Fix legend popover scroll
      
      * Add unit tests
      
      * Add e2e tests
      
      * Fix show/hide series for scatter charts
      
      * Default `LegendItemDot` to visible state
      
      * Only apply legend dot hover effect if there's a click handler
      
      * Don't allow to remove the last series in `ChartSettingSeriesOrder`
      
      * Fix tooltip performance drop
      
      * Fix e2e tests around `series_order` viz setting widget
      
      * Use `text-medium` for outer circle background
      
      * Update dot style
      
      * tweak inner circle color
      
      * Update copy
      
      * Use div instead of button if can't toggle visibility
      
      * Fix legend layout issue
      
      * Don't show trendlines for hidden series
      
      * Fix missing prop value
      
      * Disable visibility toggle outside of dashboard/qb view
      
      * Add public dashboard test
      
      * Add tooltip footer e2e helpers
      
      * Fix chart tooltip shows hidden series data
      
      ---------
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Unverified
      57fe9712
  5. Aug 30, 2024
  6. Aug 21, 2024
    • Ryan Laurie's avatar
      Create Question and Dashboard Sharing Menu (#46593) · 3964d71e
      Ryan Laurie authored
      * QuestionAlertWidget to FC + TS
      
      * update e2e tests
      
      * use regular alert for unsubscribes
      
      * Create Question and Dashboard Sharing Menu
      
      * Handle some edge cases
      
      * top notch unit tests
      
      * more testing and tweaking
      
      * fix imports
      
      * more tests
      
      * add alerts to question sharing menu
      
      * add tests for alerts
      
      * update e2e tests
      
      * use Oisin's toolbarbutton
      
      * fix rebase
      
      * prompt to save before sharing questions
      
      * show prompt to set up notification channels
      
      * fix import
      
      * update tests and hide on notebook screen
      
      * fixes
      
      * clean up pulse types
      
      * update e2e tests
      
      * fix a bunch more tests
      
      * more e2e test fixes
      
      * maybe green now? :fingers_crossed:
      
      * last one :pleading_face:
      
      * design updates
      
      * make channel setup modal nicer
      
      * simpler component props
      
      * lint fix
      
      * lint fixes
      Unverified
      3964d71e
  7. Aug 20, 2024
  8. Aug 16, 2024
  9. Aug 12, 2024
  10. Aug 08, 2024
  11. Aug 07, 2024
    • Phoomparin Mano's avatar
      feat(sdk): CLI to bootstrap an embedding-ready Metabase instance (#46080) · 4ce37a25
      Phoomparin Mano authored
      
      * add setup commands
      
      * fix settings definition
      
      * update environment variables for cli
      
      * handle instances not being ready
      
      * update error messages
      
      * add more specific loading messages
      
      * loading spinner state
      
      * improve error message
      
      * use a fixed demo setup token
      
      * remove extraneous spinner
      
      * update status checks
      
      * update container messages
      
      * update wait timing
      
      * create api keys
      
      * extract constants
      
      * remove manual steps
      
      * Add anonymous tracking + other things. will need to clean up
      
      * Modify SDK for better structure
      
      * remove line from print.ts
      
      * Update webpack.embedding-sdk-cli.config.js back to production
      
      * Add types and add quick note
      
      * Fix a typo
      
      * Add index file, simplify types, use an array
      
      * Add safer json parsing
      
      * use delay of 100ms between each setup call
      
      * Suggestions from review
      
      * ensure that cli works
      
      * Attempt to fix jest errors
      
      * Remove node-fetch from sdk code to hopefully get unit tests working again
      
      * fix yarn.lock file
      
      * revert capture groups change
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      Unverified
      4ce37a25
  12. Aug 06, 2024
  13. Aug 02, 2024
  14. Jul 31, 2024
  15. Jul 30, 2024
  16. Jul 25, 2024
  17. Jul 19, 2024
    • lbrdnk's avatar
      Remove `:foreign-keys` feature or convert to `:metadata/key-constraints` where appropriate (#44894) · 9c708c21
      lbrdnk authored
      
      * Post sync hook stub for implicit joins testing stub
      
      * Add join alias to field lvalues to enable sorting on joined fields
      
      * Disable :foreign-keys on Mongo
      
      * Require :left-join support for implicit joins instead of :foreign-keys
      
      * Update implicit joins tests
      
      * Adjust sync-fields-test
      
      * Update implicit joins feature check test
      
      * Transform post-sync-hook to normal function
      
      * Add foreign key relationships only for dbmses without :foreign-keys feature
      
      * Update test to handle Oracle correctly
      
      * Split convoluted fn
      
      * Avoid unnecessary computations for datasets with no fks
      
      * Update docstring
      
      * Fix driver usage
      
      * Transform :foreign-keys to :metadata/key-constraints in test data loading code
      
      * Update sync_test.clj
      
      * Update driver_test.clj
      
      * Update moviedb.clj
      
      * Update dataset_definition_test.clj
      
      * Update fetch_metadata.clj
      
      * Update fields_test.clj
      
      * Update driver.clj
      
      * Update driver/sql.clj
      
      * Set sql driver join support to true for all joins
      
      Deriving drivers are expected to set to false where applicable.
      
      * Update sqllite.clj
      
      * Remove foreign-keys from spark
      
      * Remove :foreign-keys from presto
      
      * Remove :foreign-keys from Athena
      
      * Remove foreign-keys from big query
      
      Reading docs it seems fk inference should be ok. Let's see the test results. Act based on that.
      
      * Update test_metadata.cljc
      
      * Set key-constraints to false for bigquery
      
      * Add foreign keys to sqlite manually until sync is fixed
      
      * Return driver require to Athena
      
      * Correct typo
      
      * Add naive primary key heuristic
      
      * Update pk fk logic to handle name components correctly
      
      * Add alias escaping to presto
      
      * Add ordering to test
      
      * Add order by to test
      
      * Update test
      
      * Remove use of rewrite-fields-to-force-using-column-aliases in order by fields
      
      * Add exception to alias forcing
      
      * Different approach to exception from alias forcing
      
      * Alternative approach for prefixing idents in bigq
      
      * All seelcted fields by desired alias
      
      * Rewrite only fields not from this source table
      
      * Update test
      
      * Enable breakout-on-fk-field-test for :left-join drivers
      
      * Add feature comment
      
      * Explicit joins tests foreign-keys removal
      
      * Update nested_queries_test.clj
      
      * Update remapping tests
      
      * Update tests
      
      * Update tests to handle sqlite results format
      
      * Disable metadata/key-constraints on sqlite during tests until
      
      * Address remarks
      
      * Remove mt/with-mock-fks-for-drivers-without-fk-constraints
      
      * Update bigquery test
      
      * Update tests
      
      * Adjust row level restrictions
      
      * Add parameterized-sql feature
      
      * Update comment
      
      * Update leftovers
      
      * Order keys
      
      * Remove foreign keys from frontend
      
      * Fix FE unit
      
      * Update driver changelog
      
      * Address review remark
      
      * Update test/metabase/query_processor/test_util.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update docs/developers-guide/driver-changelog.md
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update docs/developers-guide/driver-changelog.md
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update docs/developers-guide/driver-changelog.md
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update test
      
      * Update comment and reduce expression
      
      * Update comment
      
      * Address remarks
      
      * Fix merge
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      9c708c21
  18. Jul 18, 2024
    • Anton Kulyk's avatar
      Clean up dashboard URL management (#44639) · f4f71ea7
      Anton Kulyk authored
      * Fix falsy tabSelected/tabRenamed checks
      
      * Update URL management (WIP)
      
      * Fix tests failing because of whitespace changes
      
      * Fix tests failing because of parameter order
      
      * Use one hook for parameters and tab URL management
      
      * Fix tests failing because of parameter order
      
      * Fix test failing because of whitespace changes
      
      * Revert
      
      * Fix DashboardTabs tests
      
      * Fix tests failing because of parameter order
      
      * Fix test
      
      * Fix test failing because of whitespace changes
      
      * Remove unit tests that should be e2e tests now
      
      * Fix tab navigation
      
      * Fix string encoding/decoding
      
      * Revert test changes
      
      * Consistent question search params
      
      * Update DashboardTabs tests
      
      * Fix `SyncedParametersList`
      
      * Fix e2e tests
      
      * Fix nav usage
      
      * Fix types
      
      * Remove `useSyncedQueryString`
      
      * Fix test
      
      * Move slug utils to dashboard utils
      
      * Fix nav
      
      * Revert nav change
      
      * Fix e2e tests
      
      * Fix public/embedded dashboards, handle site url
      
      * Add repro test
      
      * Bring back and fix `PublicOrEmbeddedDashboardPage` tests
      
      * Move `SyncedParametersList` to qb
      Unverified
      f4f71ea7
  19. Jul 16, 2024
  20. Jul 12, 2024
  21. Jul 10, 2024
    • Nick Fitzpatrick's avatar
      Migrate Model Indexes to RTK (#43981) · cd53fa93
      Nick Fitzpatrick authored
      * Migrate Model Indexes to RTK
      
      * Sorting out types... I think?
      
      * remove unneeded comment
      
      * replacing the selector with an initiate to ensure that there is data
      
      * catching and throwing error
      
      * Updating unit tests
      Unverified
      cd53fa93
  22. Jul 09, 2024
  23. Jul 08, 2024
    • bryan's avatar
      Remove enable nested queries (#44447) · fdd75ffc
      bryan authored
      
      * update e2e test for command pallete to use a valid setting
      
      * remove the setting from the ui, make it always true, unless set false from env
      
      * remove enable-nested-queries from admin section on fe
      
      - fix unused oldValue -> _oldValue
      
      * tests aren't allowed to change enable-nested-queries
      
      * fix test + disallow setting nested queries from code
      
      * we cannot set enable-nested-queries
      
      - set the env var instead
      
      * add checks for the enable-nested-queries setting
      
      * make resolve-source-cards work with enable-nested-queries setting
      
      * fix recents uri interception
      
      * return enable_nested_queries setting to client
      
      * adjust fetchmock url matcher
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      fdd75ffc
  24. Jul 02, 2024
  25. Jun 27, 2024
  26. Jun 26, 2024
  27. Jun 20, 2024
    • Phoomparin Mano's avatar
      fix(sdk): font size, color and padding in viz (#44283) · dab2d852
      Phoomparin Mano authored
      * funnel start color should be text-dark
      
      * change pivot table font size unit to em for scaling
      
      * change funnel and legend item unit to em
      
      * change funnel font size to em
      
      * change object detail font size to em
      
      * change gauge font size to em
      
      * add cartesian chart padding config
      
      * update docs
      
      * remove isEmbeddingSdk prop
      
      * simulate the 0.875em base font size
      
      * chart padding override should apply in query builder
      
      * add cartesian padding to stories
      
      * update readme docs
      
      * fix collection browser option in readme docs
      
      * fix pivot table font size scaling
      
      * update loki
      
      * update loki
      
      * use em for smart scalar
      
      * update chart default padding
      
      * revert smart scalar font size scaling due to measurement
      
      * dynamic font family and font size as defaults
      
      * pivot table
      
      * add more properties to sdk docs
      
      * make FONT_SIZES constant local
      
      * link to discussion on query builder extra spacing
      
      * enforce that font is passed to getLeftHeaderWidths
      Unverified
      dab2d852
  28. Jun 19, 2024
  29. Jun 14, 2024
  30. Jun 13, 2024
  31. Jun 12, 2024
  32. Jun 11, 2024
    • bryan's avatar
      Make recents understand context (#43478) · 7b849da3
      bryan authored
      
      * adds the endpoint and a test
      
      * add recents endpoint, todo: tests
      
      * add post recents endpoint
      
      * return recent views for both lists, but make the endpoint work
      
      * Make recent-views context aware
      
      - pruning is context aware, only checks for the recently-inserted
        context
      - Adds endpoints:
          - POST to create selection recents,
          - GET activity/recents
            - requres context query param to be one of:
            - all, views, selections
      
      - Adds context arg to update-users-recent-views!
      - Cleans up arg schema for update-users-recent-views
      
      * impl GET api/activity/recents
      
      - return recent-selections and recent-views from
      - send context == collection from pinned card reads
      
      * update callsites of recent-views/update-users-recent-views!
      
      - to use :view param where necessary
      
      * fixes models/recent-view tests
      
      * adds more activity/recent-view tests
      
      * wip
      
      - fix whitespace linter
      
      * Fix command palette e2e test
      
      - reuse util snake-keys
      
      * updates fe to use new recents endpoints
      
      * fixes fe type issue
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * log selection events for created collections
      
      * mysql doesn't allow default values for TEXT types
      
      * log a recent view on data-picker selection
      
      * decouple view-log context from card-event view context
      
      * fix a doc typo
      
      * stop double logging recent-views on POST
      
      * maybe fixes some tests
      
      * some e2e fixes
      
      * fix mysterious divide by zero during score search
      
      * fix divide by zero possibilities everywhere in score-items
      
      metabase.api.activity/score-items used to throw when there weren't any
      items being scored (even though there's a `(when (seq items) ...)` check)
      
      * more test fixes
      
      * fix more e2e tests, + rename endpoint in tests
      
      * fix oopsie
      
      * fixes a few more tests
      
      * address review comments/questions
      
      * allow for a comma delimited list in qps like ?context=views,selections
      
      returns all recent view items with those contexts, most recent first
      under the `:recents` key.
      
      * refactors FE around new endpoint
      
      * fixes for unit tests
      
      * use ms/QueryVectorOf for context
      
      * fix models/recent_views tests
      
      * use multiple query params instead of comma delimited value on FE
      
      * ignore timestamp when deduping recents
      
      * review comments + test fixing
      
      * update docstring
      
      * fix api/activity_test s
      
      * actually dedupe
      
      * add test for deduping by context
      
      * e2e fix: shows up-to-date list of recently viewed items after another page is visited
      
      * e2e fix: should undo the question replace action
      
      * e2e fix: should replace a dashboard card question (metabase#36984)
      
      * e2e fix: should preselect the most recently visited dashboard
      
      * fix 6 more e2e tests
      
      * fixes fe type check and unit failure
      
      * renames unit test mocking function
      
      * fix a flaky e2e test
      
      * widen Item to accept str or kw where sensible
      
      - allow strings or keywords for moderated_status, and authority_level
      
      * simplify impl + add test
      
      * add view-log to events schema
      
      * add collection context to view log
      
      * fix the final 2 failing e2e tests
      
      * click dashboard tab when the user has can-read? on recent entities
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      Unverified
      7b849da3
  33. Jun 06, 2024
  34. Jun 04, 2024
Loading