This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 13, 2024
-
-
Phoomparin Mano authored
* add license problem hook * add warning banner * style cue component * update cue component * report issue to console * report issue to console * use sdk loader for pre-initialization * extract print problem method * use non-standard shadows * add unit tests * prevent console log spam during tests * mock the embedding token feature * mock the embedding token feature by default * add more test cases * add test case * add test cases * increase popover z-index * simplify test setup * simplify test setup * do not load individual component when a license error happens * move SdkLicenseProblemDisplay component out * replace colors with color-mix * replace colors with color-mix * make the text unthemed to ensure legibility * hard-code colors to prevent them from being themed * hard-code colors to prevent them from being themed * update border styles * make the chevron unthemed * unset console text color * only set stroke on errors * optimistic query settings * document the sdk license condition * remove redundant condition * add notes on api keys always being allowed on localhost * move the no auth method message to warning component * rename sdk license problem to usage problem * add eslint rule for stories * rename sdk license problem to usage problem * move sdk usage problem display out of the init controller * specify fallback font if instance is down or CORS error * add comments on conditions pending on the CORS PR * add notes on non-localhost checks * make test ids constant * add test case for neither provided * fix types * address code reviews * pass `embedding-sdk` flag in `token-features` * address code review Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * remove appName from console logs * rename embedding-sdk to embedding_sdk * add the embedding_sdk premium token feature * do not setup enterprise plugin in sdk test * do not localize visual cue messages * fix unit test in setup-sdk-auth * rename tests * remove unused eslint-disable * enable embedding_sdk premium feature for sdk unit tests * revert security_test.clj to use embedding instead of embedding-sdk * remove unneeded test * changes to support the style leak fixes --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Nicolò Pretto authored
* first iteration to scope sdk styles to our components * basic css reset for buttons * clean up duplicated css * make sdk components use instance font if no font is passed * cleanin up and remove defaultProps not needed * fix tests * adds EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx * Update enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * fix import * prettier --write * we don't need theme.fontFamily, added a comment * rename EMBEDDING_SDK_PORTAL_CONTAINER_ELEMENT_ID to EMBEDDING_SDK_PORTAL_ROOT_ELEMENT_ID * fix unit test --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Ryan Laurie authored
* Dashboard Info Sidebar * e2e test updates * add unit tests * e2e test updates * fix e2e tests * fix more e2e tests * update back behavior
-
- Sep 09, 2024
-
-
Ryan Laurie authored
* Question Settings Sidesheet (#47699)
-
- Sep 05, 2024
-
-
Alexander Polyankin authored
-
- Sep 03, 2024
-
-
Anton Kulyk authored
* Move current click handler to legend title * Add `onToggleSeriesVisibility` prop to `Legend` * Update `LegendItemDot` component * Update `LegendItemTitle` * Toggle series visibility * Fix hover effect * Don't let to hide the last visible series * Add `visible` property to `BaseSeriesModel` * Fix dangling split axis label when hiding a series * Update `graph.series_order` viz setting widget * Fix can't toggle series visibility from legend popover * Fix legend dot clipped by `overflow: hidden` * Fix eslint error * Fix legend popover scroll * Add unit tests * Add e2e tests * Fix show/hide series for scatter charts * Default `LegendItemDot` to visible state * Only apply legend dot hover effect if there's a click handler * Don't allow to remove the last series in `ChartSettingSeriesOrder` * Fix tooltip performance drop * Fix e2e tests around `series_order` viz setting widget * Use `text-medium` for outer circle background * Update dot style * tweak inner circle color * Update copy * Use div instead of button if can't toggle visibility * Fix legend layout issue * Don't show trendlines for hidden series * Fix missing prop value * Disable visibility toggle outside of dashboard/qb view * Add public dashboard test * Add tooltip footer e2e helpers * Fix chart tooltip shows hidden series data --------- Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
- Aug 30, 2024
-
-
Ryan Laurie authored
* add useDocsUrl hook and update lint rule * remove all uses of MetabaseSettings.docsUrl * update tests * revert non-docsurl change
-
- Aug 21, 2024
-
-
Ryan Laurie authored
* QuestionAlertWidget to FC + TS * update e2e tests * use regular alert for unsubscribes * Create Question and Dashboard Sharing Menu * Handle some edge cases * top notch unit tests * more testing and tweaking * fix imports * more tests * add alerts to question sharing menu * add tests for alerts * update e2e tests * use Oisin's toolbarbutton * fix rebase * prompt to save before sharing questions * show prompt to set up notification channels * fix import * update tests and hide on notebook screen * fixes * clean up pulse types * update e2e tests * fix a bunch more tests * more e2e test fixes * maybe green now?
* last one * design updates * make channel setup modal nicer * simpler component props * lint fix * lint fixes
-
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Aug 16, 2024
-
-
Denis Berezin authored
-
- Aug 12, 2024
-
-
Denis Berezin authored
-
- Aug 08, 2024
-
-
Nick Fitzpatrick authored
* useLogRecentItem * updating tests * unit tests * e2e test * PR Feedback * log questions / models * Accept :dataset instead of :model * Adding e2e test for recent activity datasets, reverting 'await' changes * Add e2e for collection moving error --------- Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Aug 07, 2024
-
-
Phoomparin Mano authored
* add setup commands * fix settings definition * update environment variables for cli * handle instances not being ready * update error messages * add more specific loading messages * loading spinner state * improve error message * use a fixed demo setup token * remove extraneous spinner * update status checks * update container messages * update wait timing * create api keys * extract constants * remove manual steps * Add anonymous tracking + other things. will need to clean up * Modify SDK for better structure * remove line from print.ts * Update webpack.embedding-sdk-cli.config.js back to production * Add types and add quick note * Fix a typo * Add index file, simplify types, use an array * Add safer json parsing * use delay of 100ms between each setup call * Suggestions from review * ensure that cli works * Attempt to fix jest errors * Remove node-fetch from sdk code to hopefully get unit tests working again * fix yarn.lock file * revert capture groups change --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Aug 06, 2024
-
-
Ryan Laurie authored
* allow edits to uers with empty name fields * add repro for 40750 * whoopsie
-
- Aug 02, 2024
-
-
Ryan Laurie authored
* properly handle SMTP environment variables * disable clear button when set by env var * allow the SMTP form to validate with any combination of environment variables * add unit tests for SMTP connection form * BONUS: fix console error for jt keys * fix types
-
- Jul 31, 2024
-
-
Uladzimir Havenchyk authored
-
- Jul 30, 2024
-
-
Uladzimir Havenchyk authored
* test: update testing-library packages * upgrade jest * drop useless types * drop babel-jest * fix types * fix canvas error
-
Uladzimir Havenchyk authored
-
- Jul 25, 2024
-
-
Anton Kulyk authored
* Don't show "Download" button until query complete * Fix `PublicOrEmbeddedDashboardPage` tests * Add tests * Remove redundant dataset error checks * Revert "Remove redundant dataset error checks" This reverts commit fc7810f0.
-
- Jul 19, 2024
-
-
lbrdnk authored
* Post sync hook stub for implicit joins testing stub * Add join alias to field lvalues to enable sorting on joined fields * Disable :foreign-keys on Mongo * Require :left-join support for implicit joins instead of :foreign-keys * Update implicit joins tests * Adjust sync-fields-test * Update implicit joins feature check test * Transform post-sync-hook to normal function * Add foreign key relationships only for dbmses without :foreign-keys feature * Update test to handle Oracle correctly * Split convoluted fn * Avoid unnecessary computations for datasets with no fks * Update docstring * Fix driver usage * Transform :foreign-keys to :metadata/key-constraints in test data loading code * Update sync_test.clj * Update driver_test.clj * Update moviedb.clj * Update dataset_definition_test.clj * Update fetch_metadata.clj * Update fields_test.clj * Update driver.clj * Update driver/sql.clj * Set sql driver join support to true for all joins Deriving drivers are expected to set to false where applicable. * Update sqllite.clj * Remove foreign-keys from spark * Remove :foreign-keys from presto * Remove :foreign-keys from Athena * Remove foreign-keys from big query Reading docs it seems fk inference should be ok. Let's see the test results. Act based on that. * Update test_metadata.cljc * Set key-constraints to false for bigquery * Add foreign keys to sqlite manually until sync is fixed * Return driver require to Athena * Correct typo * Add naive primary key heuristic * Update pk fk logic to handle name components correctly * Add alias escaping to presto * Add ordering to test * Add order by to test * Update test * Remove use of rewrite-fields-to-force-using-column-aliases in order by fields * Add exception to alias forcing * Different approach to exception from alias forcing * Alternative approach for prefixing idents in bigq * All seelcted fields by desired alias * Rewrite only fields not from this source table * Update test * Enable breakout-on-fk-field-test for :left-join drivers * Add feature comment * Explicit joins tests foreign-keys removal * Update nested_queries_test.clj * Update remapping tests * Update tests * Update tests to handle sqlite results format * Disable metadata/key-constraints on sqlite during tests until * Address remarks * Remove mt/with-mock-fks-for-drivers-without-fk-constraints * Update bigquery test * Update tests * Adjust row level restrictions * Add parameterized-sql feature * Update comment * Update leftovers * Order keys * Remove foreign keys from frontend * Fix FE unit * Update driver changelog * Address review remark * Update test/metabase/query_processor/test_util.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update docs/developers-guide/driver-changelog.md Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update test * Update comment and reduce expression * Update comment * Address remarks * Fix merge --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
- Jul 18, 2024
-
-
Anton Kulyk authored
* Fix falsy tabSelected/tabRenamed checks * Update URL management (WIP) * Fix tests failing because of whitespace changes * Fix tests failing because of parameter order * Use one hook for parameters and tab URL management * Fix tests failing because of parameter order * Fix test failing because of whitespace changes * Revert * Fix DashboardTabs tests * Fix tests failing because of parameter order * Fix test * Fix test failing because of whitespace changes * Remove unit tests that should be e2e tests now * Fix tab navigation * Fix string encoding/decoding * Revert test changes * Consistent question search params * Update DashboardTabs tests * Fix `SyncedParametersList` * Fix e2e tests * Fix nav usage * Fix types * Remove `useSyncedQueryString` * Fix test * Move slug utils to dashboard utils * Fix nav * Revert nav change * Fix e2e tests * Fix public/embedded dashboards, handle site url * Add repro test * Bring back and fix `PublicOrEmbeddedDashboardPage` tests * Move `SyncedParametersList` to qb
-
- Jul 16, 2024
-
-
Kamil Mielnik authored
* Get rid of tolerance * Use range rect and element rect instead of clientWidth/clientHeight/scrollWidth/scrollHeight * Fix types * Mock Range.prototype.getBoundingClientRect * Mock getBoundingClientRect in unit tests
-
- Jul 12, 2024
-
-
Alexander Polyankin authored
-
- Jul 10, 2024
-
-
Nick Fitzpatrick authored
* Migrate Model Indexes to RTK * Sorting out types... I think? * remove unneeded comment * replacing the selector with an initiate to ensure that there is data * catching and throwing error * Updating unit tests
-
- Jul 09, 2024
-
-
Denis Berezin authored
* feat(sdk): Add Dashboard loading event handlers * Refactor to redux state * Fix logic with load with cards data * Fix nasty e2e fails * Fix nasty e2e fails * Add global events * Fix issue with loading event * Fix issue with loading event * Review fixes * Add unit tests * Fix unit tests
-
Aleksandr Lesnenko authored
-
- Jul 08, 2024
-
-
bryan authored
* update e2e test for command pallete to use a valid setting * remove the setting from the ui, make it always true, unless set false from env * remove enable-nested-queries from admin section on fe - fix unused oldValue -> _oldValue * tests aren't allowed to change enable-nested-queries * fix test + disallow setting nested queries from code * we cannot set enable-nested-queries - set the env var instead * add checks for the enable-nested-queries setting * make resolve-source-cards work with enable-nested-queries setting * fix recents uri interception * return enable_nested_queries setting to client * adjust fetchmock url matcher --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
- Jul 02, 2024
-
-
Phoomparin Mano authored
* add default font family * use metabase provider internal component for tests
-
- Jun 27, 2024
-
-
Sloan Sparger authored
* highlights the trash link in the sidebar when viewing root trash collection or a trashed item * impls pr feedback * impls more pr feedback * fixes unit tests and logical mistake that allowed urls with invalid collection ids to match on undefined trash id due to it not being loaded yet
-
- Jun 26, 2024
-
-
Phoomparin Mano authored
-
- Jun 20, 2024
-
-
Phoomparin Mano authored
* funnel start color should be text-dark * change pivot table font size unit to em for scaling * change funnel and legend item unit to em * change funnel font size to em * change object detail font size to em * change gauge font size to em * add cartesian chart padding config * update docs * remove isEmbeddingSdk prop * simulate the 0.875em base font size * chart padding override should apply in query builder * add cartesian padding to stories * update readme docs * fix collection browser option in readme docs * fix pivot table font size scaling * update loki * update loki * use em for smart scalar * update chart default padding * revert smart scalar font size scaling due to measurement * dynamic font family and font size as defaults * pivot table * add more properties to sdk docs * make FONT_SIZES constant local * link to discussion on query builder extra spacing * enforce that font is passed to getLeftHeaderWidths
-
- Jun 19, 2024
-
-
Raphael Krut-Landau authored
* Use an indicator-agnostic testid * Run sed * Use correct testid
-
Denis Berezin authored
* Temp * Add support for saved questions * Try to fix question not found issue * Try to fix question not found issue * Fix unit tests * Add basic unit test * Fix unit tests * Fix unit tests, fix question not found issue * Review fixes * Review fixes * Refactor components structure, review fixes * Adjust readme
-
- Jun 14, 2024
-
-
Raphael Krut-Landau authored
-
- Jun 13, 2024
-
-
Phoomparin Mano authored
* apply cell background color * add id column overrides * do not add transparency to id column cell when overridden * fix static dashboard theming * update loki reference image * add style resets and regenerate loki snapshots * add style resets and regenerate loki snapshots
-
- Jun 12, 2024
-
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Move `syncColumnSettings` to metabase/visualization * Remove unused `SettingsSyncOptions` * Fix type errors
-
- Jun 11, 2024
-
-
bryan authored
* adds the endpoint and a test * add recents endpoint, todo: tests * add post recents endpoint * return recent views for both lists, but make the endpoint work * Make recent-views context aware - pruning is context aware, only checks for the recently-inserted context - Adds endpoints: - POST to create selection recents, - GET activity/recents - requres context query param to be one of: - all, views, selections - Adds context arg to update-users-recent-views! - Cleans up arg schema for update-users-recent-views * impl GET api/activity/recents - return recent-selections and recent-views from - send context == collection from pinned card reads * update callsites of recent-views/update-users-recent-views! - to use :view param where necessary * fixes models/recent-view tests * adds more activity/recent-view tests * wip - fix whitespace linter * Fix command palette e2e test - reuse util snake-keys * updates fe to use new recents endpoints * fixes fe type issue * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * log selection events for created collections * mysql doesn't allow default values for TEXT types * log a recent view on data-picker selection * decouple view-log context from card-event view context * fix a doc typo * stop double logging recent-views on POST * maybe fixes some tests * some e2e fixes * fix mysterious divide by zero during score search * fix divide by zero possibilities everywhere in score-items metabase.api.activity/score-items used to throw when there weren't any items being scored (even though there's a `(when (seq items) ...)` check) * more test fixes * fix more e2e tests, + rename endpoint in tests * fix oopsie * fixes a few more tests * address review comments/questions * allow for a comma delimited list in qps like ?context=views,selections returns all recent view items with those contexts, most recent first under the `:recents` key. * refactors FE around new endpoint * fixes for unit tests * use ms/QueryVectorOf for context * fix models/recent_views tests * use multiple query params instead of comma delimited value on FE * ignore timestamp when deduping recents * review comments + test fixing * update docstring * fix api/activity_test s * actually dedupe * add test for deduping by context * e2e fix: shows up-to-date list of recently viewed items after another page is visited * e2e fix: should undo the question replace action * e2e fix: should replace a dashboard card question (metabase#36984) * e2e fix: should preselect the most recently visited dashboard * fix 6 more e2e tests * fixes fe type check and unit failure * renames unit test mocking function * fix a flaky e2e test * widen Item to accept str or kw where sensible - allow strings or keywords for moderated_status, and authority_level * simplify impl + add test * add view-log to events schema * add collection context to view log * fix the final 2 failing e2e tests * click dashboard tab when the user has can-read? on recent entities --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- Jun 06, 2024
-
-
Alexander Polyankin authored
* adhoc-query-metadata * Get ad-hoc query metadata from the BE * Fix broken ad-hoc queries * Fix broken ad-hoc queries * Fix tests * Add a test * Add tests * Add tests * Fix whitespace * Fix whitespace * Fix tests
-
- Jun 04, 2024
-
-
Nicolò Pretto authored
* move parameters and dashboard reducers to the common ones as they're used everywhere * convert reducers-{common,main,public}.js to typescript, done with --no-verify * convert reducers to named exports
-