Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 13, 2024
  2. May 10, 2024
  3. May 09, 2024
  4. May 08, 2024
    • Cam Saul's avatar
      Cam's module linter 5000 (#42250) · 1e9e60a0
      Cam Saul authored
      * Cam's module linter 5000
      
      * Get Kondo passing
      
      * Revert changes to usage of mdb.setup/setup-db!
      
      * Check ns shapes
      
      * Add ns :require shape linter; PR feedback
      
      * Linter fixes :wrench:
      Unverified
      1e9e60a0
  5. May 07, 2024
  6. May 05, 2024
  7. May 01, 2024
  8. Apr 30, 2024
  9. Apr 29, 2024
    • Cam Saul's avatar
      Add `Offset()` expression (BE + FE) (Part 1) (#41346) · dd0f14a5
      Cam Saul authored
      * Fix add-alias-info matching for nominal field literal refs
      
      * Minor cleanup
      
      * Minimize diff
      
      * A bit more cleanup
      
      * Cumulative aggregations w/ multiple breakouts should reset counts (#2862)
      
      * Update dox
      
      * Do the nesting FIRST before adding alias info.
      
      * Remove unused
      
      * FE for Offset()
      
      * Cleanup stray code
      
      * Prettier
      
      * Kondo
      
      * Test fixes :wrench:
      
      * Better error message when no breakout
      
      * Support offset as an expression with no breakouts. Still require an ORDER BY tho.
      
      * Fix most stuff
      
      * Hack city??????
      
      * Revert nest-query changes and disable the offset-no-breakout test for now.
      
      * Appease TypeScript
      
      * Test fix :wrench:
      
      * Oracle & MySQL test fixes
      
      * Test fixes :wrench:
      
      * Remove maxWorkers for FE unit tests
      Unverified
      dd0f14a5
  10. Apr 22, 2024
  11. Apr 19, 2024
  12. Apr 17, 2024
  13. Apr 11, 2024
  14. Apr 10, 2024
  15. Apr 08, 2024
    • Cam Saul's avatar
      Legacy MBQL documentation (#40657) · 6c515648
      Cam Saul authored
      * Legacy MBQL documentation
      
      * Do not commit dox
      
      * Subject the legacy MBQL stuff to the same stricter linting rules as MLv2
      
      * PR feedback
      Unverified
      6c515648
    • Nemanja Glumac's avatar
      Preserve notebook native preview user preferences (#41064) · dd8e0728
      Nemanja Glumac authored
      * Add new user-local setting `notebook-native-preview-preferences`
      
      * Update user settings on FE
      
      * Use two distinct setting entries
      
      * Update FE types
      
      * More explicit `notebook-native-preview-sidebar-width` definition
      
      * Add selectors
      
      * Initialize QB uiControls based on the BE settings
      
      * Rename QB store entry
      
      `isNativePreviewSidebarOpen` -> `isShowingNotebookNativePreview`
      
      * Rename QB store entry
      
      `nativePreviewSidebarWidth` -> `notebookNativePreviewSidebarWidth`
      
      * Add Redux actions
      
      * Dispatch user settings on top of Redux store
      
      * Fix test title typo
      
      * Add E2E test to make sure sidebar is resizable
      
      * Expand the E2E test to cover persisting settings across sessions
      
      * Be more explicit that we're resizing along x axis
      
      * Store window breakpoint as a variable
      
      * Calculate handle's left position more explicitly
      Unverified
      dd8e0728
    • Cal Herries's avatar
  16. Apr 05, 2024
  17. Mar 26, 2024
  18. Mar 25, 2024
  19. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  20. Mar 20, 2024
  21. Mar 15, 2024
    • Cam Saul's avatar
      MLv2 normalization overhaul (#40142) · c27b6769
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      Unverified
      c27b6769
  22. Mar 14, 2024
  23. Mar 11, 2024
    • dpsutton's avatar
      Db api (#39731) · 1e7823d1
      dpsutton authored
      * first move to a db api
      
      * mdb.spec into mdb
      
      * mdb.u/isa -> mdb.query/isa
      
      * mdb.u/qualify -> mdb.query/qualify
      
      * last of mbql.u -> mbql.query and :gun:mbql.u:sparkler:
      
      * remove last of the mdb.connection/db-type and use from mdb/db-type
      
      * remove the last non-cmd usages of mdb.connection
      
      had some circularity in
      
      models.interface requires mdb/db-type for sql flavored "now"
      mdb requires db/setup
      which requires db/custom_migrations to ensure they are on cp
      custom migration requires json functions in models.interface
      
      so had to do a dynamic require for the db-type
      
      * get db-type from mdb not mdb.env
      
      * invoke `(mdb/app-db)` and not pass a var. lots of things fail
      
      * mdb.setup/migrate! into mdb with potemkin
      
      * remove get-connection. call .getConnection on the app-db
      
      perhaps invites clumsy usage outside of `with-open` if it's a top level
      function
      
      * namespace docstrings
      
      * last few and grab db.env/db-file into api ns
      
      * lint cleanup
      
      * addresses PR comments
      Unverified
      1e7823d1
  24. Mar 07, 2024
  25. Feb 29, 2024
    • bryan's avatar
      Tech Debt: teamzero (#39417) · b09db3b4
      bryan authored
      * [AS+BCM] fix first 3 todos
      
      * [AS+BCM] add issues
      
      * add jdbc proxy issue
      
      * driver/driver-features -> driver/features
      
      * killing more todos and remove `supports?`
      
      * add more issues
      
      * dont let people who dont have snippet perms access snippets
      
      * adding more issues
      
      * replace calls to support? in mongo driver
      
      * fix namespace sorting
      
      * whitespace
      Unverified
      b09db3b4
  26. Feb 28, 2024
    • Nemanja Glumac's avatar
      Persist user-local info about the last selected database in the native query editor (#38986) · 576e1511
      Nemanja Glumac authored
      * Add new user-specific setting `last-used-database-id`
      
      * Update user settings when user selects a database for a native query
      
      * Remember the last used database in the native query editor
      
      * Fix type error
      
      * Set database id when initializing new native question
      
      * Persist the database only for "New > Native query"
      
      * Persist last used database for native models
      
      * Mark `last-used-database-id` setting as potentially `undefined`
      
      * Reduce diff
      
      * Remove unused prop from QB
      
      * Lift dispatch logic up to the `View` component
      
      * Fix type errors
      
      * Make this setting work for all authenticated users
      
      * Add initial E2E tests
      
      * Add initial backend unit test
      
      * Expand the backend unit test to check for user-local only property
      
      * Fix E2E test and make it more explicit
      
      * Add mongo-related E2E test
      
      * Fix typo
      
      * Add permission-related E2E tests
      
      - Adds reproduction for #39053
      
      * Make sure no redundant requests are made
      
      This commit ensures no redundant requests are made when selecting
      the same, i.e. the previously selected, database.
      
      * Add E2E tests related to model actions
      
      * Clean up
      
      * Extract persist database logic into an action
      
      * Update the setting name as suggested in the code review
      
      * Make the setting description a bit more explicit
      
      * Add one more permissions-based E2E test
      
      * Store postgres database name in a variable
      Unverified
      576e1511
  27. Feb 21, 2024
  28. Feb 20, 2024
  29. Feb 15, 2024
    • Cam Saul's avatar
      Mega QP context and entrypoint overhaul. Reduce QP hairiness by 30% (#35465) · 80dcbdfb
      Cam Saul authored
      * QP enterprise middleware should use `defenterprise`
      
      * Test fix? :wrench:
      
      * Remove `:rff` from the Query Processor context map
      
      * Sort namespaces
      
      * Simplify QP entrypoints part 1
      
      * Test fixes :wrench:
      
      * Test fixes :wrench:
      
      * Make sure defenterprise dispatch is done for every QP run
      
      * B I G  QP context overhaul
      
      * WIP
      
      * Remove qp.context.default
      
      * Test fix :wrench:
      
      * PR feedback
      
      * QP context overhaul [WIP] [ci skip]
      
      * QP context overhaul [WIP] [ci skip]
      
      * Fix duplicate preprocesses
      
      * Some test fixes.
      
      * More test fixes [ci skip]
      
      * Source card resolution middleware should be preprocessing middleware, not around [ci skip]
      
      * Test fixes [WIP] [ci skip]
      
      * Remove `test-qp-middleware`
      
      * Remove `qp/compile`
      
      * Fix Kondo warnings/cleanup
      
      * Remove `mt/compile`
      
      * Fix most tests
      
      * Mostly everything working?
      
      * 4 failures, 1 error
      
      * Eliminate QP context `reducedf`
      
      * 3 failures, 0 errors <3
      
      * All tests are passing <3
      
      * Remove dead debug-qp code
      
      * Fix test failure
      
      * Remove async context
      
      * Remove raisef
      
      * Forget it, just remove context entirely [ci skip]
      
      * Fix Kondo errors
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Remove empty namespace
      
      * Fix some reflection warnings
      
      * Update dox [ci skip]
      
      * Test fix :wrench:
      
      * Fix pivot QP
      
      * Misc improvements
      
      * Test fix :wrench:
      
      * Improvements and test fixes
      
      * More test fixes :wrench:
      
      * Test fixes :wrench:
      
      * Address PR feedback
      
      * Test fixes :wrench:
      
      * More test fixes and docstring improvements
      
      * Appease Eastwood
      
      * Test fixes :wrench:
      
      * More test fixes
      
      * Test fixes :wrench:
      
      
      
      * Revert test parallelization in metabase.models.params.chain-filter-test
      
      * Update src/metabase/async/util.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      80dcbdfb
  30. Feb 13, 2024
  31. Feb 06, 2024
    • Cal Herries's avatar
      Unverified
      a9012596
    • lbrdnk's avatar
      Mongo java driver upgrade (#38017) · 113c0558
      lbrdnk authored
      
      * tmp: patched monger for 4.11.1 mongo java driver
      
      * tmp: Update monger utils
      
      Aggregation probably wont work now, but we are not using those from monger anyway. With this change in place I'm able to load needed namespaces and create test-data dataset successfully.
      
      Commit contains lot of condo errors that should be resolved while porting.
      
      * WIP: Monger removed in favor of java driver wrapper
      
      * Update java driver wrapper
      
      * Update srv test
      
      * Update comments
      
      * Use non keywordized run-command for `dbms-version`
      
      * Fix according to e2e tests
      
      * Cleanup
      
      * Separate `java-driver-wrapper` into multiple namespaces
      
      * Fix semantic type inference for serialized json
      
      * Fix options for run-command
      
      * Cleanup json namespace
      
      * Cleanup conversion namespace
      
      * Cleanup operators
      
      * Update kondo in operators ns
      
      * Cleanup connection namespace
      
      * Cleanup mongo namespace
      
      * Cleanup util namespace
      
      * Add todo
      
      * Move session related code to util
      
      * Cleanup database namespace
      
      * Update docstring for conn string generation
      
      * Update docstrings
      
      * Update tests
      
      * Update linter for with macros
      
      * Update modules/drivers/mongo/src/metabase/driver/mongo/connection.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update modules/drivers/mongo/src/metabase/driver/mongo/connection.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Use transient in from-document for building a map
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Update can-connect to use let form
      
      - Avoid nested `with-mongo-database` call.
      - Avoid creating a set used for searching for database name.
      
      * Remove redundant set use from describe-database
      
      * Change from-document keywordize default to false
      
      * Remove log message translation
      
      * Update maybe-add-ssl-context-to-builder! to always return builder
      
      * Indent from-document
      
      * Remove redundant ConvertToDocument extensions
      
      * Use oredered-map in do-find's sort
      
      * Use ex-info in details-normalized
      
      * Add imports and update comment in execute ns
      
      * Update fixme comment
      
      * Pass opts instead of a selection to from-document in do-find
      
      * Avoid unnecessary double dot call
      
      * Update connection test ns according to review remarks
      
      * Make tests parallel
      
      * Docstring update
      
      * Update docstring
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      113c0558
  32. Feb 05, 2024
  33. Jan 29, 2024
Loading