This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 19, 2023
-
-
Anton Kulyk authored
-
bryan authored
* remove a few defendpoint-schema calls * remove more defendpoint-schema calls - fix bug with enum of strings X route regexes * more defendpoint-schema rippin' * more weeding out defendpoint-schemae * cleanup * upgrade more routes to defendpoint * fix a bug with defendpoint route regex guards * remove comment * fix typo in malli schema * coerce action-id in DELETE api/action/:action-id * coerce timeline id's * coerce pulse ids * many fixes for upgrading to defendpoint * lsp clojure clean ns on api/pulse.clj * upgrade more endpoints off defendpoint-schema * fix some more + enhance boolean handling * remove custom transformer * fix the rest of the boolean string schema usages * fix error message in notify test * fix api embed * revert api/timeline * remove def * BooleanString -> BooleanValue - decode any boolean or "true" or "false" into `true` or `false`. * leave POST api/dataset/ alone * coerce ids in api/notify
-
Ngoc Khuat authored
-
- May 18, 2023
-
-
john-metabase authored
Formatting of BigQuery will use the MySQL dialect for now.
-
Braden Shepherdson authored
This drops the original `temporal-bucket` (which returned only the unit, eg. `:day-of-month`) and renames `temporal-bucket-option` to `temporal-bucket`. This returns a map with the `:unit` and `:lib/type`, so it plays nice with `display-info`. Also fixed some docs and a lurking infinite loop in `lib.js/available-binning-strategies` (it accidentally called itself rather than `lib.core/available-binning-strategies`).
-
Case Nelson authored
* [MLv2] Implement remove replace for aggregations and expressions * Cleanup * Fixing tests * Drop agg-uuid for source-uuid, add tests for agg and expr remove replace * Fix linter * Undo clean move * Address PR feedback
-
Ngoc Khuat authored
* ModerationReview to toucan2 * Revision to toucan2 * Secret to toucan2 * Session to toucan2 * Setting to toucan2
-
Cal Herries authored
* Migrate legacy field refs in result_metadata * Add expression and field_ref * Update testing description * Fix clj-kondo * Exclude empty result_metadata from the query
-
Ngoc Khuat authored
* Bookmarks to toucan2 * Timeline and TimelineEvent to toucan2
-
Ngoc Khuat authored
* Dimension to toucan2 * FieldValues to toucan2
-
- May 17, 2023
-
-
Ngoc Khuat authored
-
Cal Herries authored
-
Jerry Huang authored
* initial changes * add job + tests * add test for job * fix spacing * address comments * update variable
-
Cal Herries authored
* Fix subsitution of exclude- params * Rename fn to `not-single-date-type?` * Add docstring * Remove comment * Fix substitution * Fix errors when param values are not strings * Exclude bigquery from the test * Fix testing description * Use users table instead * Fix docstring
-
john-metabase authored
Data model and settings are now always exported unless --no-settings or --no-data-model are specified.
-
Braden Shepherdson authored
-
Cal Herries authored
* Remove dataset_query from search * More removal of dataset_query * Fix test * Remove test * Fix kondo * Fix kondo
-
Tim Macdonald authored
* instrumentation * PoC of fast CSV inserts for Postgres [ci skip] * Clean everything up * Add tests * Carriage return test * Clean up per PR comments * Cache NumberFormat fetching * Memoize number separators * Better caching of number separators * Add SQL injection tests
-
- May 16, 2023
-
-
Ngoc Khuat authored
remove the warning util.cljc:346 recur arg for primitive local: cumulative_byte_count is not matching primitive, had: Object, needed: long (#30768) Auto-boxing loop arg: cumulative-byte-count
-
Mark Bastian authored
Removed colloquial use of "your" in x-rays where appropriate.
-
- May 15, 2023
-
-
Ngoc Khuat authored
-
metamben authored
Fixes #30703.
-
metamben authored
* Keep original join-aliases in expected columns Fixes #30648. The root cause of the bug was that the result_metadata generated for MBQL queries returned escaped join-aliases, which in BigQueries case means that spaces are converted underscores (_). These wrong join aliases could not be resolved in later stages and resulted in incorrect references. Normally, the escaped aliases are replaced by original ones in the post processing step, but the post processing is not executed when calculating expected columns. This PR makes sure the original aliases are restored in the expected columns. * Keep source_alias and display_name intact too
-
Ngoc Khuat authored
* Database to toucan2 * Table to toucan2 * Field to toucan 2
-
- May 14, 2023
-
-
metamben authored
Implement MLv1 compatible display names for bucketed fields
-
- May 12, 2023
-
-
dpsutton authored
Before: ``` ❯ clj -M:"$ALIASES" WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs operator.clj:172 recur arg for primitive local: sum is not matching primitive, had: Object, needed: long Auto-boxing loop arg: sum Clojure 1.12.0-alpha2 user=> (do (dev) (start!)) Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/17.0.1-zulu/zulu-17.jdk/Contents/Home 2023-05-12 14:26:37,091 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB 2023-05-12 14:26:47,248 INFO util.encryption :: Saved credentials encryption is DISABLED for this Metabase instance.
For more information, see https://metabase.com/docs/latest/operations-guide/encrypting-database-details-at-rest.html ..instrumented #'metabase.util.malli/with-api-error-message ..instrumented #'metabase.util.honey-sql-2/identifier ..instrumented #'metabase.util.honey-sql-2/normalize-type-info ..instrumented #'metabase.util.honey-sql-2/with-database-type-info ..instrumented #'metabase.util.honey-sql-2/cast ..instrumented #'metabase.util.honey-sql-2/quoted-cast ``` After: ``` ❯ clj -M:"$ALIASES" WARNING: abs already refers to: #'clojure.core/abs in namespace: clojure.algo.generic.math-functions, being replaced by: #'clojure.algo.generic.math-functions/abs operator.clj:172 recur arg for primitive local: sum is not matching primitive, had: Object, needed: long Auto-boxing loop arg: sum Clojure 1.12.0-alpha2 user=> (do (dev) (start!)) Warning: environ value /Users/dan/.sdkman/candidates/java/current for key :java-home has been overwritten with /Users/dan/.sdkman/candidates/java/17.0.1-zulu/zulu-17.jdk/Contents/Home 2023-05-12 15:11:21,678 INFO metabase.util :: Maximum memory available to JVM: 8.0 GB 2023-05-12 15:11:30,806 INFO util.encryption :: Saved credentials encryption is DISABLED for this Metabase instance. For more information, see https://metabase.com/docs/latest/operations-guide/encrypting-database-details-at-rest.html util.cljc:346 recur arg for primitive local: cumulative_byte_count is not matching primitive, had: Object, needed: long Auto-boxing loop arg: cumulative-byte-count WARNING: infinite? already refers to: #'kixi.stats.math/infinite? in namespace: kixi.stats.core, being replaced by: #'clojure.core/infinite? 2023-05-12 15:11:55,615 INFO driver.impl :: Registered abstract driver :sql ``` -
bryan authored
* add column for marking the audit database * create audit db on app startup On app startup, in enterprise mode, always check that there is an up-to-date audit database with is_audit set to true. up-to-date means that it matches the app-db. If the audit db doesnt exist, or doesn't match up with the app-db, it will be created. otherwise no-op - refactor GET /api/database/ into defendpoint * add a few tests * add more tests + return kw for no-op * Merge branch 'master' into bcm-add-app-db-as-audit-db * fix migrations file * lint fix + remove def * keep the old audit db around - nil -> ::no-op * small macro fix * Merge branch 'master' into bcm-add-app-db-as-audit-db * Merge branch 'master' into bcm-add-app-db-as-audit-db * move ensure-db-exists! into its own namespace - avoids circlar dependency on app startup * fix tests * lint fix * inspect test values * use mdb.env/env to initialize audit db * try returning the app-db connection pool - instead of making a doppelganger in metabase database * get the is_audit column when looking up dbs in qp - this key is needed to return the appdb for the "Audit DB"'s connection * clean up audit-db install/update/noop logic * remove audit db from GET api/database/ * Merge branch 'master' of github.com:metabase/metabase into bcm-add-app-db-as-audit-db * fix linter + inline extra function * fix a test * Merge branch 'master' into bcm-add-app-db-as-audit-db * don't test actions on audit db
* Revert "don't test actions on audit db " This reverts commit 581ed1ab9495de7b46bccb8b1ab19f66a8fd106d. * for tests to work low IDs are basically reserved - use a higher id when installing audit db * use defenterprise for ensure-audit-db-installed! * Merge branch 'master' into bcm-add-app-db-as-audit-db -
Ngoc Khuat authored
* Dashboard Tab entity (#29802) * add dashboard tab entity * Dashboard tabs CRUD (#29861) * Dashboard tabs frontend (#30189) * rename `DashboardHeader.tsx` to `DashboardHeaderView` to avoid collision with `DashboardHeader.jsx` commit-id:7cdfd86a * add tabs to dash commit-id:d3c2fa74 * improve code structure and other fixes * rename `dashboardtab_id` to `dashboard_tab_id` * remove explicit `position` logic * improve code quality * add renaming functionality * add two new tabs when creating first tab * hide tabs if there is only one * add unit test for `DashboardTabs` component * refactor * fix type errors * add `tabId` to text cards * add `tabId` to link cards * add `tabId` to action button * use disabled state when only one tab remains * refetch cards with filter value when changing tabs * add e2e test * fix broken e2e tests * add horizontal scrolling * fix unit test * fix create tab button being on right * fix performance issue when switching tabs * add `ttag` to `tabs.ts` * use `aria-label` in e2e test helper * fix type error after rebasing * making ordered_tabs optional for tests purposes * fix failing unit tests * fix failing e2e tests * fix flaky revision history e2e test * fix type error after merging feature branch with master and rebasing * fix revisions unit test * fix `ActionParmatersInputsForm.tsx` to stop `actions-on-dashboards.cy.spec.js` from flaking --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
- May 11, 2023
-
-
Braden Shepherdson authored
No `metabase.lib.js` wrapping yet.
-
metamben authored
* Keep breakout and order-by columns as selectable Fixes #30568. The already selected columns are kept in the lists returned by breakoutable-columns and orderable-column, but they are marked with their position in the breakouts and order-bys list, respectively. * Add test for orderable-columns display-info * Add test for orderByPosition after a roundtrip * Cherry pick order-by cleanup fix * Fix breakoutable and orderable columns after round trip * Declare breakoutPosition in ColumnDisplayInfo * Address review feedback --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Mark Bastian authored
Removes display of underlying type of x-ray card (e.g. model, question) in title. Adds tests.
-
metamben authored
* Support expression options and fields only case and coalasce exprs Fixes #29938. Fixes #29950.
-
metamben authored
* Prevent fields hiding joined fields (#30644) Fixes #29904. * Resolve join columns in the join stages The original implementation got into infinite loops.
-
Cal Herries authored
* Add schemas driver feature flag * Add sql_jdbc schemas test * Add more general test * Make schemas feature default to true * Implement supports? for other drivers * Add feature to the driver changelog * Remove redundant schemas from h2 * Spelling fix Pre-rebase SHA: 8a2c7e0 or 5686b2f * MySQL does *not* support schemas * Bad rebase * Typo? Co-Authored-By:
Tim Macdonald <tim@metabase.com>
-
Ngoc Khuat authored
* Dashboard, DashboardCard, DashboardSeries to toucan2
-
Ngoc Khuat authored
* revert remove hydrate param values in #22836 * fix tests in ee ns * fix param field tests * Add e2e test * Add e2e tests * Add e2e tests * fix failed test and use t2 instead of db * fix wrong t2 call spec * fix failing tests * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * apply Tamas's suggestions and unskip e2e tests * delete the e2e tests that AlexP previously added in this PR but brought it into a seperated PR" " * create Field values if not found * add a tests for when field values is not existed, we create them * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * Fix the e2e test suite for remapping * revert the changes to create full values on demand * remove unused requires * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * fix tests * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values * Merge branch 'master' into ngoc-revert-remove-hydrate-param-values Co-Authored-By:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- May 09, 2023