This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 15, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Add show metabase links toggle admin setting * Hide Metabase links * Fix type error * Add selector tests * Hide a link in HomeHelpCard * Make test names more consistent with existing test suites * Add tests to `NewModelOptions` * Prepare `VisualizationError` for testing * Add tests to `VisualizationError` * Hide link and add tests to `PreviewQueryModal` * Extract components to make it easier to test * Move the new component into its own folder * Hide Metabase link in `ActionDashcardSettings` * Prepare `EmptyFormPlaceholder` for testing * Hide Metabase link in `EmptyFormPlaceholder` * Extract Metabase link from `FormCreator` for testing * Hide Metabase link in `FormCreator` * Extract link from `DashCardCardParameterMapper` to prepare for testing * Hide Metabase link in `DashCardParameterMapper` * Clean up the test setup function * Hide Metabase link in `ExpressionEditorHelpText` * Hide Metabase link in `TagEditorHelp` * Hide Metabase links in `MetricList` * Hide Metabase link in `SegmentList` * Prepare `CaveatMessage` for testing * Hide Metabase link in `CaveatMessage` * Hide Metabase link in `CustomMapFooter` * Hide Metabase link in `ImpossibleToCreateModelModal` * Hide Metabase link in `ExpressionWidget` * Hide Metabase link in `ExpressionWidget` * Add BE tests * Update sample database description * Fix TypeScript type-check * Fix failed unit tests * Fix wrong test names * Add missing translations * Make tests looks like tests from other components * Update enterprise/frontend/src/metabase-enterprise/whitelabel/components/MetabaseLinksToggleWidget/MetabaseLinksToggleWidget.tsx Co-authored-by:
Nicolò Pretto <info@npretto.com> * Simplify the change * Fix weird import directory * Fix wrapped translation copy * Fix test name * Move comment next to the component * Fix test names * Review: Make code easier to review * Fix wrong document link * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Update src/metabase/public_settings.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * Address review: BE changes --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Chris Truter authored
* Add tests and non-redact criteria for csv validation * Set redaction rules and test validation for remaining types * Test that our format test coverage has not slipped * Test we have defined the redaction logic
-
- Jan 13, 2024
-
-
Braden Shepherdson authored
The QP sometimes provides a `:source-alias` and no `:join-alias` for a joined column. Then its MLv2 ref would be missing a `:join-alias` and it would not match its own column under `lib.equality/find-matching-column`. Fixes #36861.
-
- Jan 12, 2024
-
-
Gustavo Saiani authored
-
Nick Fitzpatrick authored
* building out partial graphs * Set up change deteected modal, graph loading states * e2e tests. Load admin permissions * reset permissions from memory on cancel * fixing types and tests
-
Oleg Gromov authored
-
Jerry Huang authored
* add retry to password reset * fix error case * add to all emails * fix misc stuff * fix test * fix test * fix linter * fix retrying framework * fix linter * fix e2e test * add comment * adress comments * fix linter * fix linter * fix test * fix test * fix test * fix test * fix test * fix e2e test * fix e2e test * fix e2e test * fix test * fix e2e test and unit tests * remove paren * fix linter * fix e2e test * fix e2e test * finally actually fix e2e test
-
Aleksandr Lesnenko authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Use UTF8 encoding for dashboard preview page * Remove `nonce` Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
Jeff Bruemmer authored
-
Ryan Laurie authored
-
Uladzimir Havenchyk authored
-
Alexander Polyankin authored
-
Oleg Gromov authored
-
metamben authored
* Optimize canonicalization of MBQL clauses Fixes #37245.
-
Braden Shepherdson authored
This is at the `metabase.lib.js` level. Should help solve some performance issues where eg. `expressionable-columns` was getting called on every keystroke for autocomplete; see #37528. Powered by `metabase.lib.cache/side-channel-cache`, which attaches the cache in an Atom on a private property mutated onto the `query`. That means it is invalidated with any edit to the query (since a new object is returned) and becomes garbage at the same time the query does.
-
metamben authored
* Support replacing expressions changing types and names Part of #36211.
-
Ibe Dwi authored
Fix TypeError when changing click behavior to drill-through menu & default click behavior does not have selected state (#35863) * fix: type error on click behavior change * chore: add comments * chore: tidy up comments * chore: reset changes * add aria-selected & selected drill-through menu assertion * chore: update assertion comment * refactor: move aria-selected inside selectable item * remove 'menu' from click behavior option * test: add e2e test fro 35354 * chore: clean up demo and update assertion * refactor: move assertion to existing scenario * chore: add log on e2e test * feat: update name for actionMenu * fix: unknown type in 34845 * fix: test after rebase * fix: remove unused union type "menu" * fix: use master version of click-behavior * fix: readd the tests * fix: e2e test * fix: remove set type selector after unset column * fix: show type selector when click behavior is undefined * fix: show type selector when finalClickBehavior is default (actionMenu)
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Solovyov authored
-
Kamil Mielnik authored
* Get rid of Question.prototype.aggregate * Get rid of Question.prototype.breakout * Get rid of Question.prototype.filter
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Nicolò Pretto authored
-
Nemanja Glumac authored
This removes the `setDefaultQuery()` method for both - StructuredQuery and - Query Resolves #37506
-
Kamil Mielnik authored
* Migrate segments in getCardForBlankQuestion and... fix it * Separate parsing, use Metadata.prototype.segment * Extract filterBySegmentId * Migrate metrics in getCardForBlankQuestion * Rename filterByMetricId to aggregateByMetricId * Expose segment(query, segmentId) in MLv2, map it in metabase-lib, and use it in initializeQB * Expose metric(query, metricId) in MLv2, map it in metabase-lib, and use it in initializeQB * Update Lib.metric and Lib.segment return type * Break TemplateTag type down to ensure presence of snippet-specific and card-specific properties when dealing with respective snippet types * Begin migrating updateTemplateTagNames, migrate referencedQuestionIds, migrate updateCardTemplateTagNames * Migrate hasSnippets * Remove redundant conditioning * Migrate updateSnippetNames * Revert "Break TemplateTag type down to ensure presence of snippet-specific and card-specific properties when dealing with respective snippet types" This reverts commit f303122055ccf7f50ccf7571cec4c5e7a79c5255. * Migrate updateSnippetsWithIds & setTemplateTag * Format code * Use new updateTemplateTagNames implementation * Remove old updateCardTemplateTagNames, move and refactor relevant test to initializeQB unit test suite * Remove no-longer-used NativeQuery.prototype.hasSnippets * Fix TS issues * Update initializeQB unit tests * Revert NativeQuery-related changes in initializeQB * Rename segment to segmentMetadata & metric to metricMetadata
-
- Jan 11, 2024
-
-
Jerry Huang authored
* landing-page backend validation * fix spacing
-
adam-james authored
* Handle unknown column-settings keys instead of passing a `nil` key. The issue #27941 called out pivot table static-viz failing when a sort was added to the column-viz. This led to a null pointer exception in a formatter when the table render was attempted. Following the chain a bit, I noticed that there's a map of 'db' keys -> 'norm' keys defined in `metabase.shared.models.visualization-settings` ```clojure (def ^:private db->norm-column-settings-keys {:column_title ::column-title :date_style ::date-style :date_separator ::date-separator :date_abbreviate ::date-abbreviate :time_enabled ::time-enabled :time_style ::time-style :number_style ::number-style :currency ::currency :currency_style ::currency-style :currency_in_header ::currency-in-header :number_separators ::number-separators :decimals ::decimals :scale ::scale :prefix ::prefix :suffix ::suffix :view_as ::view-as :link_text ::link-text :link_url ::link-url :show_mini_bar ::show-mini-bar}) ``` Which doesn't contain the key `:pivot_table.column_sort_order`, which is the key added by the frontend when you sort the column via the viz settings. This would cause the transform to leave a `nil` key in its place which ultimately led to the NPE further down the line. I've made the change that any unknown key gets namespaced with `unknown`. So, `:pivot_table.column_sort_order` -> `:unknown/pivot_table.column_sort_order`. This prevents the NPE. * Use a simpler approach to achieve the same result!
-
Jeff Bruemmer authored
-
shaun authored
* API Keys: add auth card and manage page * update deletion copy * add groups data to snapshot * update e2e tests to work with backend * update strings and formatting * update e2e tests * remove e2e tests from other pr * update unit tests * e2e test update * mock api key endpoints in settingsEditor unit tests * remove console log * use dumb quotes * handle monospace better * better form validation * no need to wait * update test to work with validation * contrain table width * remove monospace variant * API Keys: Handle Groups UI (#37099) * API Keys: Show in Group members table * API Keys: Show count in Group listing * tweak and test group settings views for api keys * fix sad lint rebase sitch * update group manager tests * better loading behavior * handle all users api keys * update types and tests --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com> --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Mark Bastian authored
As a follow on to #37546, this fixes an issue in which the macroexpansion of `with-skip-if-empty-pulse-result` doesn't capture the scope of the arguments in `skip-if-empty-test`. The solution is just to _correctly_ wrap all of the `mt/id` functions in `mt/dataset`.
-
Sloan Sparger authored
-
metamben authored
-