This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 20, 2023
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
- Jan 19, 2023
-
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Jan 17, 2023
-
-
Ryan Laurie authored
* add PivotTable unit tests * obey the linter * measure leftHeader cell content * test cell data width detection * extract static properties * convert to functional component * cleanup refs * extract cellRenderers * extract size and position getter functions * replace item measurement * convert rowToggleIcon to typescript * convert PivotTable to typescript * remove unused hasCustomColors * update tests to typescript * fix rebase
-
Cal Herries authored
* Update dashboard save to save all dashcard data on create, not update * Remove repro e2e test * Add e2e test * Add series to POST request, missing by mistake * Formatting * Rename DashboardApi methods for consistent names and cases
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Add Fira Code * Add basic actions tab * Add "New action" flow * Fix actions tab width * Fix code doesn't show newlines * Add action editing flow * Fix console error * Use Monaco for code snippet * Add an empty state * List implicit actions * Make it possible to add implicit actions * Hide actions tab if actions are turned off * Handle read-only permissions * Fix loader * Sort actions * Add server mocks for action endpoints * Add `createMockImplicitCUDActions` helper * Add tests for the actions tab * Add E2E test for action create-read-update flows * Clean up * Move e2e test to models for now * Fix `EmptyState` usage * Fix action sorting * Avoid boolean casting * Ensure the page explicitly loads database * Use existing color for action query card * Use `space` function * Fix length check
-
Nick Fitzpatrick authored
* adding onlyText button variant * PR feedback
-
Anton Kulyk authored
* Move `PublicApp` to its own directory * Fix `renderWithProviders` for public environment * Clean up `PublicApp` and add tests * Extend coverage * Wasn't planning to commit this yet * Swap condition
-
- Jan 16, 2023
-
-
Ryan Laurie authored
* add PivotTable unit tests * obey the linter * measure leftHeader cell content * test cell data width detection * obey the linter * fix bad rebase
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Cherry-pick `ModelPicker` * Cherry-pick actions editor and form components * Migrate from entity forms * Remove `ModelPicker` * Temporarily add "New > Action" flow * Disable save button if query is empty * Fix utilities moved * Fix type errors * Address comments * Simplify `ActionForm` tests * Break down `ActionCreator` props * Add basic `ActionCreator` tests * update action creator header gap styling * Extract `convertActionToQuestionCard` * Fix `CreateActionForm` ignores action name * Fix `FormModelPicker` crash * Address comments * Remove "New > Action" flow Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Cherry-pick type changes * Cherry-pick action endpoints * Cherry-pick actions entity * Fix type errror * Fix type error * Define `WritebackActionId` type * Cherry-pick missing utilities * Merge action types * Update mocks * Use testing utils * Fix types * Export action mocks * Simplify `removeOrphanSettings` * Fix timestamp names
-
- Jan 13, 2023
-
-
metamben authored
-
Braden Shepherdson authored
- Use currency-specific decimals count (eg. 0 for JPY, 8 for BTC) - Use plural currency names in Java, matching JS - previously: singular proper name "7.23 US Dollar" - now: plural prose "7.23 US dollars" - "Small numbers" hack to treat min/max fraction digits as significant digits now applies to percentages under 1%, as well as the original |n| < 1
-
Braden Shepherdson authored
This adds a cross-platform date/time formatting library in CLJC, with (nearly) identical output in both JVM and JS environments. The only known difference is week numbers. CLJS (through Moment.js) has ordinal numbers, and renders the week number as "34th". Neither the JVM nor Clojure has a handy library for this (I'm sure it's out there somewhere, but it seems like a silly dep to add) so it renders week numbers as simply "34". Both platforms have date formatters that use pattern strings (eg. `"YYYY-MM-dd"`) to turn date/time objects into strings. There's a strong resemblance in how these work and what letters stand for what parts of the date and time, but they are far from identical. Rather than try to hackily convert one set of strings to another with regexes or other manipulations, this PR defines a set of names for fragments of dates (eg. `:year`, `:day-of-week-full`, `:hour-24-dd`) and includes functions to transform a list of these keys into a platform-specific format function. This is portable and transparent, and can be written in Clojure or JS code: ```clj [:year "-" :month-dd "-" :day-of-month-dd] ; 2022-04-08 [:month-full " " :day-of-month-d ", " :year] ; April 8, 2022 [:hour-12-dd ":" :minute-dd " " :am-pm] ; 7:52 AM ``` ```js [":year", "-", ":month-dd", "-", ":day-of-month-dd"] ; 2022-04-08 [":month-full", " ", ":day-of-month-d", ", ", ":year"] ; April 8, 2022 [":hour-12-dd", ":", ":minute-dd", " ", ":am-pm"] ; 7:52 AM ``` Note that the original code allowed an unrecognized `:date-style` string to be used directly as the formatting string. With the move to formatting data structures that no longer works. Instead there is a fixed map of format strings to the above data structures, that contains all the currently used `:date-style` inputs. If some caller needs a new format someday, we can either: (a) add the style to the map; or (b) pass the data structure form directly to the `:date-format` option, which if provided is used as the format. It's tempting to go to all the call sites and replace these `:date-style` strings with the new format structures. However, the strings are still embedded in the `:visualization_settings` in user appDBs, so we still need to recognize them. Most of the existing functions in the TS library have the same API. The set of allowed `:date-style` and `:time-style` values is turned into a type using `keyof`, so that we get precise type-checking of these values rather than simply `string`. One function has been dropped from the API: `getDateFormatFromStyle`. There was no practical way to implement it using the new format data structures. The only caller was the date format column settings, and it has been rewritten to use the formatted string for its sample date as its key instead.
-
- Jan 12, 2023
-
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
* revert new tooltips for non-stacked series * types
-
Ryan Laurie authored
* add PivotTable unit tests * allow dynamic pivot table header width * access settings using metabase/lib * fix comments
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Jan 11, 2023
-
-
Ryan Laurie authored
* make model detail work in master * bring basic model detail page in * Remove page URL helper leftovers * Rename `Urls.dataset` into `Urls.model` * Add tests to `Urls.model` * Move `Urls.model` to its own file * Add `Urls.modelEditor` * Use correct URL helpers in model detail page * Add link to query editor * Extract `ModelDetailHeader` component * Small readability fix * Clean up `QuestionMoveToast` * Fix model archiving * Add move and archive actions * Add border below tab controls * Fix import * Add page title * Extend server mocks * Fix console errors * Add `role: dialog` to `Modal` * Add tests * Add `ActionsContainer` to `PinnedItemCard` * Handle read-only model permissions * Remove data app leftovers * Don't add `result_metadata` to shared mocks * Fix spacing * Fix i18n * Remove `console.warn` block * Fix import * Fix type error * Add links to reach the model detail page (#27628) * Add `Urls.modelDetail` helper * Add `ModelDetailLink` component * Clean up `PinnedItemCard's` unit tests * Add model detail link to `PinnedItemCard` * Clean up `BaseItemsTable's` unit tests * Add model detail link to `BaseTableItem` * Add model detail link to model info sidebar * Fix tests * Fix spacing * Add tooltip Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Tim Macdonald authored
* Warn when cards used for filtering are archived * filter-values -> dropdown-widget-values * Better string concatenation * dropdown_widget_values_usage_count -> parameter_usage_count * Add end-to-end test
-
Alexander Polyankin authored
-
- Jan 10, 2023
-
-
Anton Kulyk authored
-
Anton Kulyk authored
* Delete `QuestionHistoryModal` * Delete `HistoryModal` * Delete `AdminEmptyText` * Delete `EditWarning` * Delete `Expandable` * Remove a bunch of question loaders * Delete `CandidateListLoader` * Delete `QuestionName` * Revert "Remove a bunch of question loaders" This reverts commit 209dbac68dec92083d6e3bdf34ff42ace76a3870. * Remove `QuestionAndResultLoader`
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Convert `VirtualizedList` to TypeScript * Add `VirtualizedSelectList` component * Virtualize raw table list * Virtualize model and question list * Fix rendering virtualized lists in tests
-
Anton Kulyk authored
* Move out `ArchiveQuestionModal` * Move out `QuestionMoveToast`
-
Anton Kulyk authored
* Install and enable plugins * Run eslint auto fix * Fix linter issues (part 1) * Fix Visualization test * Fix Pie Visualization test * Add `getIcon` and `queryIcon` helpers * Fix `VisibilityToggler` tests * Fix `QuestionActivityTimeline` tests * Fix formatting tests * Fix `EntityMenuItem` tests * Fix `ClampedText` tests * Fix `ObjectRelationships` tests * Fix `EmailAttachmentPicker` tests * Fix `SavedQuestionHeaderButton` tests * Fix `DatabaseEngineWarning` tests * Fix `Tooltip` tests * Fix `TippyPopoverWithTrigger` tests * Fix `TippyPopover` tests * Fix `TableLabel` tests * Fix `TableInfo` tests * Fix `ModerationStatusIcon` tests * Fix `Sidebar` tests * Fix `PermissionSelect` tests * Fix `PinnedItemCard` tests * Fix widget tests * Fix `DimensionSemanticTypeLabel` tests * Fix `ListSearchField` tests * Fix `ControlledPopoverWithTrigger` tests * Fix `FieldFingerprintInfo` tests * Fix `ErrorActionButton` tests * Fix `QueryValidationError` tests * Fix `LineAreaBarRenderer` tests * Fix `DataSelector` tests * Fix `PivotTable` tests * Fix `ItemPicker` tests * Fix `TokenField` tests * Fix `TagEditorParam` tests * Fix tests * Fix tests * Run prettier * Fix tests
-
- Jan 09, 2023
-
-
Aleksandr Lesnenko authored
* allow including weekday to formatted dates * specs
-
Ryan Laurie authored
* remove panning logic from map boundary calculation * add map viz percy tests * wait for map load in visual tests
-