* Extract `aceEditorStyle`

* Extract drag handle

* Port more `NativeQueryEditorRoot` class names

* Port editor root and resizable box

* Remove redundant class names

* Remove `.NativeQueryEditor` class

* Use CSS variable colors in `NativeQueryEditor.css`

* Add a comment on `NativeQueryEditor.css`

* Use named import for ErrorView

* Export ErrorView and ErrorViewProps from Visualization

* Define AddSeriesModalErrorView

* Make ErrorView component configurable in Visualization by introducing errorView prop

* Use AddSeriesModalErrorView thanks to new errorView prop

* Fix export type syntax

* Remove the dot for consistency with other error messages

* Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file

* Allow translating the custom error message

* Don't show custom ErrorView when there is only one series (or none)

* Add a test case for a single incomplete chart

* Inline: dashcardData

* Add a reproduction e2e test for #32231

* Add explicit assertion for the error message

* Add a test case for default error message when there is only 1 series

* Remove redundant setup functions

* Wait for series query endpoint

* Rename ErrorView to VisualizationErrorView

* Rename VisualizationErrorView to MultipleSeriesErrorView

* Improve assertions

* Use editDashboard helper

* Use data-testid for AddSeriesModal

* Refactor errorView prop into errorMessageOverride
- Do not export ErrorViewProps and Error out of Visualization

* Search by table description

[Fixes #25792]

* Fix initial values not reloading in the action modal

* Add a repro test for #33084

* Use cy.button helper

* Fix dashboard actions linked with filters don't work

* Add E2E test

* Make assertion clearer

Creating a collection when saving a question/dashboard should return to the question/dashboard save modal with the new collection selected (#32778)

From the Cypress docs
https://docs.cypress.io/guides/references/configuration#Global

The number of tests for which snapshots and command data are kept in memory. Reduce this number if you are experiencing high memory consumption in your browser during a test run.

The default value is 50.
We're dialing it down to 1.

* reproduce #32985

* don't crash fieldValuesWidget when we get null options

* Add reproduction test for #28756

* Reuse DASHBOARD_SLOW_TIMEOUT

* Reproduce #32963

* Don't lock display for models

* test custom column after aggregations

* skip repro

* Move dashboard bookmarks spec to `organization`

* Move dashboard filter related specs to appropriate group

* Create new `dashboard-cards` E2E group

* fix: cancel ongoing query when removing card from dashboard

* test: #12926 remove card test with xhr.abort stub

* test: use cy.on(fail instead, to specifically expect that request to be aborted

* Revert "test: use cy.on(fail instead, to specifically expect that request to be aborted"

This reverts commit 75e204e8e2c45cc490d79729ee12795ea10291fa.

* refactor: move cancelFetchCardData inside removeCardFromDashboard, which becomes a thunk

* doc jsdocs for should_wait param in visitDashboard

* "undo remove card" re-fetches the card

* test: test for undo -> re-fetch card

* refactor: removed unused param

* revert should_wait on visitDashboard in favor or manually using cy.visit

* artificially slow down requests via cy instead of using pg_sleep

* rename before block

* when undoing remove card, only refetch data if needed

* remove debug console log

* refactor: remove .within call with only one function call inside

* docs: add comment to req.continue

* test: adds assertion that the query data is actually loaded

* remove data already present check as it is already in the thunk

Introduced in #32598, even though it already exists.
https://github.com/metabase/metabase/blob/master/e2e/test/scenarios/embedding/embedding-smoketests.cy.spec.js#L317:L325

[ci skip]

* Add repro test

* Run MLv2 clean-up before running a query

* Clean redundant stages

* Fix test

* Use both clean ups

* Fully hydrate PUT-ed collections, which the FE depends on

[Fixes #30235]

* Add repro test for #30235

* Set token features properly

---------

Co-authored-by: Denis Berezin <denis.berezin@metabase.com>

* Add a repro

* Not hardcoding the question IDs

* Address review: Improve readability

* Reuse dashboard E2E util

* Add the repro

* Add UI assertion to avoid ambiguity

* dont hard code table ID in actions test

* simplify test

* break down and wait more, remove page loads

* Remove superfluous intercept and wait

* Make sure repaint happened

* Make sure virtualized table populates all rows

* Add grep tags

* Increase the request timeout

---------

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

* Add repro

* Correct new E2E helper behavior

* add parameter mapping to heading cards

* update unit tests for new props

* memoize parameter mapped content

* add heading card tests to text parameters spec

* update test descriptions

* add BE for params/substitute_tags

* fix tests

* fix test

* update FE parameter substitution to use optional flag

* heading cards should not escape characters

* add test for dashboard sub

* remove invalid specs -> desired behavior changed

- enabled parameter mapping for heading cards
  - in parameter editing mode, we should display the option to map a parameter to a heading text variable, so we should not display the original text

* fix react hook dependencies

* improve parameterValues type

* refactor E2E test to a unit test

* address nits

* fix spacing

* update types and add unit tests

* fix type errors

---------

Co-authored-by: Jerry Huang <jhuang37050@gmail.com>

* Add actions dropdown to object detail modal (#32331)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Avoid using Database constructor
- Use metadata.database() instead

* Add integration tests for basic cases when action menu is rendered and not

* Fix post-merge error

* Endpoint to fetch implicit actions param values (#32466)

* Add default update action to actions dropdown in object detail modal (#32433)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835

* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Log error to console

* Get rid of useLatest

* Fix post-merge build error

* Add default delete action to actions dropdown in object detail modal (#32556)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835

* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Add DeleteObjectModal

* Introduce useActionQuery

* Use useActionQuery in DeleteObjectModal

* Hook action execution

* Fix typo in copy

* Sort exports

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Fix object modal getting closed with Escape key when delete or update modals are open

* Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId

* Navigate to sibling row or close the modal on deletion

* Revert "Navigate to sibling row or close the modal on deletion"

This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845.

* Close object detail on deletion

* Add error handling

* Add error handling

* Greatly simplify DeleteObjectModal
- remove useActionQuery usage
- remove useActionQuery
- remove DeleteObjectModal.styled.tsx

* Improve diff

* Shorten code

* Always cast objectId to number
- See https://metaboat.slack.com/archives/C057T1QTB3L/p1690292706101109?thread_ts=1690279562.697669&cid=C057T1QTB3L
  "the reason you’re not seeing it fail on the sample dataset is probably because you’re
  using h2 for sample-dataset. it’ll fail the same if you use a postgres one.
  h2 is probably more loose in type so it allows sending a string for id.
  nevertheless, I think you can use cast it to the correct type using the param type.
  I think we did that on the UI where we execute actions from model details page."

* Inline disabled into JSX

* Use a more friendly error message when failed to delete an object because it's referenced by other objects
- See: https://metaboat.slack.com/archives/C057LE0Q4PQ/p1690377421352469?thread_ts=1690208614.530869&cid=C057LE0Q4PQ

* Revert "Use a more friendly error message when failed to delete an object because it's referenced by other objects"

This reverts commit 28327ac9b53ae92300e579d047b7f136d54e581e.

Friendly message is going to be implemented in https://github.com/metabase/metabase/issues/32694

* Rename initialValues back to dashcardParamValues in ActionVizForm

* Tests for basic deletes and updates on object detail views (#32525)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835



* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Add test cases for other types of actions

* Ignore public actions for now

* Add e2e test for actions in object detail view

* Add second step and extract helpers

* Remove duplication by changing hierarchy

* Add step with enabling model actions

* Fix visiting model page

* Remove redundant code

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Add objectId argument and function to open the modal

* Define whole order object to reuse

* Implement assertOrderFormPrefilled

* Assert Created At

* Add assertion to check whether object with new id has been reloaded

* Use all caps for constants

* Verify updating an object

* Fix test name

* Assert toast is shown on update

* Format code

* Use writable tables instead of sample db to avoid persisting updates between tests
- do not mock objects, assert against whatever comes from API

* Format code to wake GitHub up

* Add DeleteObjectModal

* Introduce useActionQuery

* Use useActionQuery in DeleteObjectModal

* Hook action execution

* Fix typo in copy

* Sort exports

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Fix object modal getting closed with Escape key when delete or update modals are open

* Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId

* Navigate to sibling row or close the modal on deletion

* Revert "Navigate to sibling row or close the modal on deletion"

This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845.

* Close object detail on deletion

* Add error handling

* Add error handling

* Greatly simplify DeleteObjectModal
- remove useActionQuery usage
- remove useActionQuery
- remove DeleteObjectModal.styled.tsx

* Improve diff

* Shorten code

* Rename initialValues back to dashcardParamValues in ActionVizForm

* Extract assertScoreUpdatedInTable

* Extract visitModelDetail

* Add deletion and toast assertion

* Remove unused arguments

* Assert delete failed

* Update tests order after starting with writable db

* Move assertions to beginning of the test, remove enableDatabaseActions

* Test disabling model actions

* Add extra assertion

* Update names

* Update the deletion assertion

* Remove unused code

* Wrap tests in another describe, setup dashboard test

* Fix setup, use asAdmin util

* Add assertion for dashboard object view

* Update test names

* Extract actions to a constant

* Add test to open update object modal

* Update assertion order

* Add test to open delete object modal

* Organize tests

* Add a test case for implicit public delete action & implicit archived delete action

* Remove redundant async

* Reuse findActionInActionMenu

* Remove redundant constant

* Fix tests

* Add a test case for databases with disabled actions

* Update wording

* Use dataset instad of a query question

* Revert name change as it does not make sense

* Format code

* Add a test case for users with no write permission

* Add a test case for when showControls is false

* Add a test case for models with clauses

* Use metadata.question() instead of new Question()

* Tests for various number of PKs in a model (#32784)

* Add a test case for 0 PKs in a model

* Add a test case for 2 PKs in a model

* Improve test names

* Fix typo

* Use plural form for "PK"

---------

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* Simplify the code that fixes dashboard tab race condition

Remove a part of dashboard reducer that addressed the race condition
from https://github.com/metabase/metabase/pull/31578/files#r1240203745.

I revert the code back to make it simpler and fix the race condition by
calling certain actions in the right order.

* Update the todo comment to use more standard todo tag

* Prevent fetching a dashcard when the previous API isn't done and is auto-refresh

* Only skip loading new dashcard on dashcoard auto refresh

* fixup! Simplify the code that fixes dashboard tab race condition

* Clean up dashboard action

Rename an action with misleading name

* Make the boolean flag easier to understand

* fixup! Make the boolean flag easier to understand

* Add E2E

* Remove commented out code

* Correct `startTime` behavior

* Fix the case when navigating between dashboards

* Make isRefreshing logic easier to follow

* Fix failed unit tests

#32734 introduced a commit that removed "Chrome" as a predefined browser that Cypress runs on.
This was needed due to frequent failures that were interfering with the release process.

Even if we decide to switch to Electron, let's do it in a dedicated commit for easier git blame.
We'll forget in a month already why a commit called "Disallow new H2 connections" switched E2E tests to Electron.

Breaking change was introduced in #32791.

* when embedded, force showing side nav when top nav is hidden

* don't force open navbar on visible paths

* update e2e tests

* fix types

* Allow selecting time on datepicker at dashboard filter

* Add e2e test

* Rename variable

* Prevent malicious H2 connection string properties

* Disallow new H2 connections

* Fix Kondo lint warning

* Test fix 



---------

Co-authored-by: dan sutton <dan@dpsutton.com>