Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 15, 2024
  2. Jan 13, 2024
  3. Jan 12, 2024
  4. Jan 11, 2024
    • Jerry Huang's avatar
      Backend validation for landing-page to disallow external URLs (#37551) · 6fafcb34
      Jerry Huang authored
      * landing-page backend validation
      
      * fix spacing
      Unverified
      6fafcb34
    • adam-james's avatar
      Handle unknown column-settings keys instead of passing a `nil` key. (#37606) · 3ef4d5df
      adam-james authored
      * Handle unknown column-settings keys instead of passing a `nil` key.
      
      The issue #27941 called out pivot table static-viz failing when a sort was added to the column-viz.
      
      This led to a null pointer exception in a formatter when the table render was attempted.
      Following the chain a bit, I noticed that there's a map of 'db' keys -> 'norm' keys defined in `metabase.shared.models.visualization-settings`
      
      ```clojure
      (def ^:private db->norm-column-settings-keys
        {:column_title       ::column-title
         :date_style         ::date-style
         :date_separator     ::date-separator
         :date_abbreviate    ::date-abbreviate
         :time_enabled       ::time-enabled
         :time_style         ::time-style
         :number_style       ::number-style
         :currency           ::currency
         :currency_style     ::currency-style
         :currency_in_header ::currency-in-header
         :number_separators  ::number-separators
         :decimals           ::decimals
         :scale              ::scale
         :prefix             ::prefix
         :suffix             ::suffix
         :view_as            ::view-as
         :link_text          ::link-text
         :link_url           ::link-url
         :show_mini_bar      ::show-mini-bar})
      ```
      
      Which doesn't contain the key `:pivot_table.column_sort_order`, which is the key added by the frontend when you sort
      the column via the viz settings.
      
      This would cause the transform to leave a `nil` key in its place which ultimately led to the NPE further down the
      line.
      
      I've made the change that any unknown key gets namespaced with `unknown`. So, `:pivot_table.column_sort_order` ->
      `:unknown/pivot_table.column_sort_order`.
      
      This prevents the NPE.
      
      * Use a simpler approach to achieve the same result!
      Unverified
      3ef4d5df
    • Jeff Bruemmer's avatar
      48.3 (#37610) · a3a61704
      Jeff Bruemmer authored
      Unverified
      a3a61704
    • shaun's avatar
      API Keys UI (#37097) · 7d369288
      shaun authored
      
      * API Keys: add auth card and manage page
      
      * update deletion copy
      
      * add groups data to snapshot
      
      * update e2e tests to work with backend
      
      * update strings and formatting
      
      * update e2e tests
      
      * remove e2e tests from other pr
      
      * update unit tests
      
      * e2e test update
      
      * mock api key endpoints in settingsEditor unit tests
      
      * remove console log
      
      * use dumb quotes
      
      * handle monospace better
      
      * better form validation
      
      * no need to wait
      
      * update test to work with validation
      
      * contrain table width
      
      * remove monospace variant
      
      * API Keys: Handle Groups UI (#37099)
      
      * API Keys: Show in Group members table
      
      * API Keys: Show count in Group listing
      
      * tweak and test group settings views for api keys
      
      * fix sad lint rebase sitch
      
      * update group manager tests
      
      * better loading behavior
      
      * handle all users api keys
      
      * update types and tests
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Unverified
      7d369288
    • Mark Bastian's avatar
      Fixing macro scope capture of `with-skip-if-empty-pulse-result` (#37597) · d58bc3e9
      Mark Bastian authored
      As a follow on to #37546, this fixes an issue in which the macroexpansion of `with-skip-if-empty-pulse-result` doesn't capture the scope of the arguments in `skip-if-empty-test`.
      
      The solution is just to _correctly_ wrap all of the `mt/id` functions in `mt/dataset`.
      Unverified
      d58bc3e9
    • Sloan Sparger's avatar
    • metamben's avatar
    • Sloan Sparger's avatar
Loading