Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 20, 2024
    • Kamil Mielnik's avatar
      Align paths in Prettier & ESLint scripts (#38951) · 750638e4
      Kamil Mielnik authored
      * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json
      
      * Handle ts files in e2e tests
      
      * Manually fix ESLint-reported issues
      
      * Format "lint-prettier-pure" script the same way as "prettier"
      
      * Run "yarn eslint-fix"
      
      * Manually fix remaining issues
      
      * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally
      
      * Remove duplicated eslint call
      Unverified
      750638e4
    • Kamil Mielnik's avatar
      Include e2e directory in prettier scripts (#38948) · 22684b87
      Kamil Mielnik authored
      * Include e2e directory in prettier scripts
      
      * Run "yarn prettier"
      Unverified
      22684b87
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  2. Feb 19, 2024
    • Sloan Sparger's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Polish appearance settings (#38713) · 8281abdc
      Mahatthana (Kelvin) Nomsawadi authored
      * Introduce tabs to admin settings
      
      * Change route when changing tabs
      
      * Reorder whitelabel settings according to the new design
      
      * Modify ImageUpload to support value from the setting
      
      * Update colors settings copy and style
      
      * Update copy in appearance/branding page
      
      * Update copy in appearance/conceal-metabase page
      
      * Add toggle grouping description
      
      * disconnect application colors from chart colors
      
      * Update whitelabel/branding copy
      
      * Update whitelabel/conceal-metabase toggles
      
      * Deprecate the old admin text input widget
      
      * Extend the test
      
      * Introduce SettingtextInput which uses metabase/ui component
      
      * Update Admin Select widget
      
      * Convert font Select to metabase/ui
      
      * Fix style conflict causing Select dropdown to overflow the page
      
      * Prevent repression on other settings page than Appearance
      
      * Move landing page (EE) to general settings page
      
      * Fix FE type
      
      * Fix unit tests
      
      * Fix E2E tests
      
      * Fix type
      
      * Removed commented out code
      
      * Fix E2E from master change
      Unverified
      8281abdc
    • Anton Kulyk's avatar
      Add new dashboard analytics events (#38872) · 7fe1620f
      Anton Kulyk authored
      * Implement `dashboard_width_toggled` event
      
      * Implement `dashboard_section_added ` event
      
      * Add a new snowplow schema file (1-1-4)
      
      * Use 1-1-4 schema file
      Unverified
      7fe1620f
  3. Feb 16, 2024
  4. Feb 15, 2024
  5. Feb 14, 2024
  6. Feb 13, 2024
    • metamben's avatar
    • Jesse Devaney's avatar
      Milestone 4: Make Dashboard Header Fixed Width (#38634) · 2f9e8ff3
      Jesse Devaney authored
      * Add fixed width behavior to dashboard header
      
      * refactor fixed width styled component
      
      * adjust margin to match full-app margin
      
      * make styles consistent across public/embed and full-app dashboards
      
      * Make public/embed dashboard headers fixed width
      
      * add fixed width header behavior to x-ray dashboards
      
      * fix dashboard headers button alignment
      
      * add tests
      
      * add parameter to dashboard to test fixed width behavior
      
      * fix tab alignment in public dashboards
      
      * refactor tests
      
      * only render container when dashboardTabs is not null
      
      * improve styled component naming
      
      * make dashboard tabs styling consistent between public/embed and full-app dashboards
      
      * make dashboard info sidebar width consistent with other dashboard sidebars
      
      * align dashboard header and dashboard body position when dashboard sidebar is open
      
      * refactor tests
      Unverified
      2f9e8ff3
  7. Feb 12, 2024
  8. Feb 11, 2024
  9. Feb 09, 2024
    • Oisin Coveney's avatar
      Add snowplow events for embedding setup flow (#37617) · d43863a2
      Oisin Coveney authored
      * Add snowplow events for embedding setup flow
      
      * Fix dashboard model tests
      
      * Fix dashboard tests
      
      * Fix card tests
      
      * Fix dashboard API tests
      
      * Fix type error
      
      * Implement analytics 2/7
      
      1. public_link_copied
      2. public_link_removed
      
      * Fix snowplow schema enum
      
      Removing null as we don't seem to put `null` in `enum`
      
      * Complete the embed_flow snowplow schema
      
      * Modify `initial_published_at` to not be overridden
      
      * Implement analytics 4/7
      
      1. public_link_copied
      2. public_link_removed
      3. public_embed_code_copied
      4. static_embed_published
      5. static_embed_unpublished
      
      * Prevent accidental ESLint log in Cypress
      
      * Differentiate `EmbeddingParametersSettings` from `EmbeddingParametersValues`
      
      We were mixing the type before, as the former one are the type of the
      setting values, not the actual values for the parameters.
      
      * Fix dashboard and card types
      
      * Fix `params` count for `static_embed_published` event
      
      * fixup! Prevent accidental ESLint log in Cypress
      
      * Fix ESlint from the result of upgrading ESLint package
      
      * Fix Snowplow schema enum to include null
      
      * Fully implement `static_embed_code_copied`
      
      * Finish embed_flow snowplow :tada:
      
      
      
      * Fix unit tests because markup change
      
      * Fix E2E tests
      
      * Fix E2E CI failure
      
      Apparently using `.realClick()` on copy button could fail locally,
      but pass on CI and vice-versa. I couldn't replicate this all the time.
      
      I'm not sure why it would fail locally.
      
      * Fix copy to clipboard not working on CI
      
      * Improve test readability
      
      * Remove extra test-id
      
      * Fix refactor `*CodeOptionId`
      
      * Restrict Snowplow schema
      
      * Revert unnecessary change
      
      * Apply Cal's suggestions for BE improvements
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Update src/metabase/util/embed.clj
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      
      * Fix backend linter error, hopefully.
      
      ---------
      
      Co-authored-by: default avatarMahatthana Nomsawadi <mahatthana.n@gmail.com>
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarNicolò Pretto <info@npretto.com>
      Unverified
      d43863a2
    • Jesse Devaney's avatar
      Milestone 3A: Add fixed width behavior to dashboard filters (#38585) · 687b4033
      Jesse Devaney authored
      
      * Migration adding 'width' to Dashboards
      
      3 migrations:
       - 1st adding the width column with default value of 'fixed'
       - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will
       be the 'old' behaviour after the fixed-width project lands).
         - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the
         next rollback anyway
       - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose
       width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case
      
      * Dashboard PUT api endpoint accepts width changes and updates appdb
      
      update-dashboard function now is aware of the :width key so those changes can end up in the transaction.
      
      Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot
      be changed to other values.
      
      * Add width to revision tests
      
      * Fix dashboard revision tests.
      
      :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has
      changed from 'full' to 'fixed' or vice-versa.
      
      * Fix comments/remarks in migration to be accurate
      
      * Attempt to fix default not working mysql/mariadb
      
      * Set default in dashboard model
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Revert default :width 'fixed' value.
      
      * Explicitly add default value 'fixed' for MySQL/MariaDB
      
      * dashboard fixed width FE implementation
      
      * adjust popover shadow styling as the popover was blending in with the header
      
      * adjust extra button popover offset
      
      * add E2E to validate behavior
      
      * add fixed width container to public dashboards
      
      * fix public embedding not respecting dashboard width setting
      
      * add test for public dashboards
      
      * Fix embed test failures
      
      * add fixed width to x-ray dashboards
      
      * reduce code duplication
      
      * move FixedWidthContainer into DashboardGridConnected
      
      - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard
      
      * update E2E tests to reflect actual intended behavior
      
      * fix type errors
      
      * tweak default width of cards to accomodate fixed width
      
      * adjust tooltip button after merging changes from master
      
      * fix bar chart test failure
      
      * fix dashboard filters date test failure
      
      - new ellipsis button in dashboard edit mode broke the test
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * bump funnel default width
      
      * adjust test for new fixed width dashboards
      
      * Fix double overlay for LineAreaBarChart dash-cards
      
      - No longer has an overlay that persists from editing mode to  viewing mode
      - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index.
      
      * Merge FixedWidthContainer with dashboard grid div
      
      * supress brush events while editing timeseries line charts on dashboard
      
      * fix failing test
      
      - test failed because I did not update this assertion based on previous changes
      
      * fix broken link input in editing mode
      
      * initial commit
      
      * fix pointer events issue on text cards in edit mode
      
      * update tests for new dash-card default sizes
      
      * update tabs card moving test because of new default card sizes
      
      * Include apply filters button in fixed width behavior
      
      * tweak - do not need centering if full width
      
      * fix apply filters button
      
      * add fixed width behavior to dashboard filters in edit mode
      
      * remove double border in edit mode
      
      * evenly space parameters/filters in edit mode
      
      * update test to account for moving location of edit mode filters
      
      * Milestone 3B: Fix dashboard tabs and filters order on a public dashboard page (#38574)
      
      * Add `className` prop to `DashboardTabs`
      
      * Fix tab panel position in public dashboards
      
      * adjust filters container padding
      
      * Address feedback
      
      ---------
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      687b4033
    • Oleg Gromov's avatar
      Embedding + required params (#38395) · 140a5322
      Oleg Gromov authored
      Unverified
      140a5322
  10. Feb 08, 2024
    • Kyle Doherty's avatar
      Update default sizes for new dash width (#38450) · d7c4fdd3
      Kyle Doherty authored
      
      * Migration adding 'width' to Dashboards
      
      3 migrations:
       - 1st adding the width column with default value of 'fixed'
       - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will
       be the 'old' behaviour after the fixed-width project lands).
         - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the
         next rollback anyway
       - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose
       width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case
      
      * Dashboard PUT api endpoint accepts width changes and updates appdb
      
      update-dashboard function now is aware of the :width key so those changes can end up in the transaction.
      
      Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot
      be changed to other values.
      
      * Add width to revision tests
      
      * Fix dashboard revision tests.
      
      :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has
      changed from 'full' to 'fixed' or vice-versa.
      
      * Fix comments/remarks in migration to be accurate
      
      * Attempt to fix default not working mysql/mariadb
      
      * Set default in dashboard model
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      
      * Revert default :width 'fixed' value.
      
      * Explicitly add default value 'fixed' for MySQL/MariaDB
      
      * dashboard fixed width FE implementation
      
      * adjust popover shadow styling as the popover was blending in with the header
      
      * adjust extra button popover offset
      
      * add E2E to validate behavior
      
      * add fixed width container to public dashboards
      
      * fix public embedding not respecting dashboard width setting
      
      * add test for public dashboards
      
      * Fix embed test failures
      
      * add fixed width to x-ray dashboards
      
      * reduce code duplication
      
      * move FixedWidthContainer into DashboardGridConnected
      
      - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard
      
      * update E2E tests to reflect actual intended behavior
      
      * fix type errors
      
      * tweak default width of cards to accomodate fixed width
      
      * adjust tooltip button after merging changes from master
      
      * fix bar chart test failure
      
      * fix dashboard filters date test failure
      
      - new ellipsis button in dashboard edit mode broke the test
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * bump funnel default width
      
      * adjust test for new fixed width dashboards
      
      * Fix double overlay for LineAreaBarChart dash-cards
      
      - No longer has an overlay that persists from editing mode to  viewing mode
      - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index.
      
      * Merge FixedWidthContainer with dashboard grid div
      
      * supress brush events while editing timeseries line charts on dashboard
      
      * fix failing test
      
      - test failed because I did not update this assertion based on previous changes
      
      * fix broken link input in editing mode
      
      * fix pointer events issue on text cards in edit mode
      
      * update tests for new dash-card default sizes
      
      * update tabs card moving test because of new default card sizes
      
      ---------
      
      Signed-off-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      d7c4fdd3
    • Anton Kulyk's avatar
      Fix card query endpoint usage on dashboards (#38547) · 83aeb32c
      Anton Kulyk authored
      * Don't reload dashcards in edit mode
      
      * Update and unskip repro
      
      * Extend "duplicate tab" e2e test
      
      * Fix implicit request body schema when fetching dashcard data
      
      * Disable dashcard data refetching in edit mode
      
      * Revert `Dashboard` useEffect changes
      
      * Fix tests
      Unverified
      83aeb32c
    • Nicolò Pretto's avatar
      Meet embedders - minimal version (#38520) · d88d32e5
      Nicolò Pretto authored
      
      * refactor: prepare SettingsPage to have conditionally rendered steps (#38201)
      
      * refactor: prepare SettingsPage to have conditionally rendered steps
      
      * fix tests missing props
      
      * Usage reason question (#38267)
      
      * Invactive -> Inactive
      
      * add question
      
      * fix e2e test
      
      * small refactor
      
      * Update frontend/src/metabase/setup/components/UsageQuestionStep/UsageQuestionStep.tsx
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * Hide "Add your data" step for people interested in embedding (#38390)
      
      * hide 'Add your data' step when user is interested in embedding
      
      * add other test cases
      
      * refactor: create selector
      
      * address pr feedback
      
      * adds minimal embed focused homepage (#38402)
      
      * very minimal homepage
      
      * fixed text color
      
      * minimal e2e + actual logic that i forgot lol
      
      * refactor the list to not have the numbers in the content
      
      * rename util functions
      
      * use button to have cursor when hovering + accessibility
      
      * refactor: move the waitFor inside the submit step
      
      * fix: make sure state is clean on multiple installs in a row
      
      * test: check that the homepage persists reload + removed typos
      
      * rename s to state
      
      * moved util functions up to home/utils.ts
      
      * adds key to avoid react warning
      
      * refactor and tests for [meet embedders] (#38465)
      
      * test: check all numbered steps during the setup flow
      
      * refactor: introduce getSteps and start using the step name instead of a number to identify steps
      
      * refactor: remove map of the steps, use step names directly
      
      * refactor: getNextStep
      
      * include 'hidden' steps in getSteps so that it won't mess up with analytics
      
      * fix after rebase issue
      
      * use full name instead of s, s -> step
      
      * analytics for meet-embedders (#38521)
      
      * refactor: extract schema version and onboarding version into constants
      
      * remove old ga events
      
      * trackUsageReasonSelected
      
      * update trackStepSeen to send the correct index
      
      * copy old schema for better diff
      
      * adds new snowplow event for usage_reason step
      
      * schema and e2e update for usage_reason_selected
      
      * adds utm tag to the link in the minimal embed homepage
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      Unverified
      d88d32e5
    • bryan's avatar
      load analytics only when changed using a checksum (#38280) · 9e1e8e8e
      bryan authored
      * load analytics only when changed using a checksum
      
      - over audit deserialization files
      
      * update docstrings
      
      * fix testing wording
      Unverified
      9e1e8e8e
    • Anton Kulyk's avatar
      Dashboard sections (#38463) · 19ca99e1
      Anton Kulyk authored
      
      * Add `ADD_MANY_CARDS_TO_DASH` action
      
      * Reuse `NewDashCardOpts` type
      
      * Extract `DashboardCardLayoutAttrs` type
      
      * Add basic `DashCardPlaceholder` viz
      
      * Add section layouts
      
      * Add `addSectionToDashboard` redux action
      
      * Add `SectionLayoutPreview` component
      
      * Add "Add section" button to dashboard header
      
      * Allow placeholder cards in `replaceCard`
      
      * Make heading cards transparent by default
      
      * Fix layout fn usage
      
      * Update mapping UI for placeholder cards
      
      * Fix tooltips position
      
      * Add `createMockPlaceholderDashboardCard`
      
      * Test `replaceCard` works with placeholder cards
      
      * Extract common `setup` from cards actions tests
      
      * Add `createMockDashboardTab`
      
      * Add unit tests for `addSectionToDashboard`
      
      * Placeholder cards work for emails/pulses
      
      Dashboards with placeholder cards now properly email rather than throwing an exception. Placeholder cards themselves are not sent as part of the email as they are empty.
      
      * Merge remote-tracking branch 'origin/38209-dashboard-sections' into 38209-dashboard-sections
      
      * Adding tests for placeholder cards and empty dashboards
      
      * Fix parameter mappings UI
      
      * Update section card sizes
      
      * Clean up
      
      * Add button label
      
      * Add E2E test
      
      * Revert
      
      * Reorder
      
      * Fix menu position
      
      * Assert placeholder card doesn't have a button
      
      * Fix menu tooltips
      
      * Fixing unit tests
      
      * Removed dangling code
      
      * Fixing unit tests
      
      * Remove virtual cards handling from `replaceCard`
      
      ---------
      
      Co-authored-by: default avatarMark Bastian <markbastian@gmail.com>
      Unverified
      19ca99e1
  11. Feb 07, 2024
    • Jesse Devaney's avatar
      Milestone 1: Default Dashboard Body to a Fixed Width (#38377) · 2c71bf0d
      Jesse Devaney authored
      
      * dashboard fixed width FE implementation
      
      * adjust popover shadow styling as the popover was blending in with the header
      
      * adjust extra button popover offset
      
      * add E2E to validate behavior
      
      * add fixed width container to public dashboards
      
      * fix public embedding not respecting dashboard width setting
      
      * add test for public dashboards
      
      * Fix embed test failures
      
      * add fixed width to x-ray dashboards
      
      * reduce code duplication
      
      * move FixedWidthContainer into DashboardGridConnected
      
      - We get the fixed-width w/o code duplication across AutomaticDashboardApp, PublicDashboard, and Dashboard
      
      * update E2E tests to reflect actual intended behavior
      
      * fix type errors
      
      * adjust tooltip button after merging changes from master
      
      * fix bar chart test failure
      
      * fix dashboard filters date test failure
      
      - new ellipsis button in dashboard edit mode broke the test
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * adjust test for new fixed width dashboards
      
      * Fix double overlay for LineAreaBarChart dash-cards
      
      - No longer has an overlay that persists from editing mode to  viewing mode
      - Adjust click-behavior tests to account for new grid-width. Old test relied on a dashcard being taller than they will now default to being. i.e. Move the chosen point/row to down an index.
      
      * Merge FixedWidthContainer with dashboard grid div
      
      * supress brush events while editing timeseries line charts on dashboard
      
      * fix failing test
      
      - test failed because I did not update this assertion based on previous changes
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      2c71bf0d
    • Romeo Van Snick's avatar
      Migrate info hover card to mantine (#38433) · 0002d2ca
      Romeo Van Snick authored
      Add HoverCard to metabase/ui and converts FieldInfoPopover to make use of it.
      
      Add DelayGroup helper, which can be used to make sure there are no delays when hovering similar items in the same group.
      Unverified
      0002d2ca
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix ESlint rules (#38458) · 8cd9b604
      Mahatthana (Kelvin) Nomsawadi authored
      * Fix ESlint from the result of upgrading ESLint package
      
      * Support `component` prop on Mantine
      
      * Prevent accidental ESLint log in Cypress
      
      * Upgrade ESLint rule
      Unverified
      8cd9b604
  12. Feb 06, 2024
Loading