This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 26, 2024
-
-
Uladzimir Havenchyk authored
* fix import order in the files with disabled rules * remove hack * minor
-
lbrdnk authored
* Fix DateTimeRange substitution for open ranges * Add E2E repro for #47172 * cljfmt * Add test for datetime column * Update range boundary for open range * Update test names * Apply suggestions from code review Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix e2e --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Aug 23, 2024
-
-
metamben authored
* Strip expression metadata for field expression Fixes #44940.
-
Raphael Krut-Landau authored
feat(admin/performance): In Admin / Performance, add a tab where you can manage the caching policies of dashboards and questions (#42990) Closes #42567
-
Mahatthana (Kelvin) Nomsawadi authored
* Update interactive embedding CTA UTM tags * Make the UTM tags more readable * Update static embed doc UTM tags * Update static embed appearance customization doc UTM tags * Update font upsell UTM tags * Update tests * Fix wrong upgrade URL * Update tests
-
- Aug 22, 2024
-
-
Romeo Van Snick authored
* Use global search for aggregation picker * Add names to aggregation picker items so they can be searched * Render info icon metric descriptions * Add unit tests for global aggregation picker search * Add test for searching metrics * Add a test for metrics descriptions * Sort metrics * Fix e2e test * Use Flex from metabase/ui * Handle markdown in metric description * Add test for sorted metrics * Update Markdown styling in metric description * Fix clojure formatting * Test for markdown in the Metric description * Fix lint * Fix test for markdown * Use simpler equality test * Fix overflow in test
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Aug 21, 2024
-
-
Nemanja Glumac authored
-
Ryan Laurie authored
* QuestionAlertWidget to FC + TS * update e2e tests * use regular alert for unsubscribes * Create Question and Dashboard Sharing Menu * Handle some edge cases * top notch unit tests * more testing and tweaking * fix imports * more tests * add alerts to question sharing menu * add tests for alerts * update e2e tests * use Oisin's toolbarbutton * fix rebase * prompt to save before sharing questions * show prompt to set up notification channels * fix import * update tests and hide on notebook screen * fixes * clean up pulse types * update e2e tests * fix a bunch more tests * more e2e test fixes * maybe green now?
* last one * design updates * make channel setup modal nicer * simpler component props * lint fix * lint fixes -
Oisin Coveney authored
-
Alexander Polyankin authored
-
Romeo Van Snick authored
* Add offset presets * Render OffsetPresets initially * Add BucketInput * Render BucketInput and do not rely on referential equality for Lib.Bucket * Make sure the currently selected bucket shows in the presets * Lift label into CompareAggregations * Fix spacing of label * Fix labels based on comparison type * Use Switch for include current period * Include current bucket in CurrentPeriodInput label * Fix unit tests * Add more unit tests for CompareAggregations * Update e2e test for column compare to handle presets * Group offset tests * Add tests for moving average * Add tests to verify changing the bucket works * Fix type * Make sure temporal columns are buckatable before picking them * Make getPreferredPresets more clear * Add test for temporal expression column * Fix lint
-
- Aug 20, 2024
-
-
Aleksandr Lesnenko authored
* fix echarts tooltip issues * fix types * use another merge-ref package
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Uladzimir Havenchyk authored
* hide terminal-report logs from console * disable html output from testing-library-dom * revert failing code
-
Nicolò Pretto authored
* make the newsletter signup a checkbox instead of a button * update copy on unit test * fix describe nesting * update the ui to be like the design * make tests use userEvent.click to avoid warning about missing act * use the subscribeToNewsletter function * add basic e2e test for newsletter subscription * move wait to the end of the test to see if it passes in ci * remove async to see if it fixes the issue * trying to mock the response * make it clear why we're mocking the response * use getUserEmail as suggested by Sloan * inline var a suggested on code review
-
Nemanja Glumac authored
* Remove `Collections` entity loader * Load collections directly within the component * Add E2E repro for #46221
-
Alexander Polyankin authored
* Fix tests * Add tests * Add tests * Fix types * Fix types
-
- Aug 19, 2024
-
-
bryan authored
* allow `:blocked` to be saved for table level perms * Adds 2 tests for table level blocked permission settings - N.B. these are NOT ENFORCED YET * update test that asserted we cannot set block on tables (we can) * WIP: Pairing on making perms checking less wild * cleanup, update docs, and add a test for view-data perm only - Added a test where we have data permissions, but not create query, and I think it is failing when we have create query and blocked data permissions. - renamed some functions from check-x -> has-x? since they return a value instead of throwing now * Revert "WIP: Pairing on making perms checking less wild" Keep the same behavior, but stick with the saner flow control This reverts commit 63bcb5b4. * update docs * update test to be passing - TODO: make sure it's correct w.r.t. perm settings * Allow schema level blocked setting in permgraph * remove invalid test cases - continue to have a forcing function to test newly added perms * conform function output * ensure a single blocked table blocks native queries to its DB * update error message - we now catch this error in `metabase.models.query.permissions/has-perm-for-query?` * we now check for data permissions to process query for card * add more explanation to what we are testing - to help see why it fails on CI and passes locally * remove excess `def` * Add test for table-level data X collection perms - update test found to be in-error * update param values qp permission check style * set view-data and create-query explicitly * set viewdata and createquery explicitly in qp test * Respond to review comments (which fixes a case) * setting a table to blocked: leave other tables the same * [Permissions] Add "No access" schema/table permission (#46509) * first pass * refactors downgrading native permission logic and updates calculation so that "No access" downgrades native permissions to "No" * stub for permissions help info on table block * modal changes wip, updates downgrading create queries permissions to all happen at a single call site * clean up, sandboxing modal copy changes, removes rekoke/limit access modal changes to make the diff smaller and move code to a seperate PR * updates permissions help section to contain the final copy * sandboxing copy fix and remove modal that was dropped from requirements * adds blocked at the schema level, updates no access copy to blocked, updates permissions help section to contain new blocked and schema level changes * fixes failed unit and e2e tests after sandboxing copy changes * improve the block e2e test to include table blocking * fixes failing blocked test, fixes other schemas create queries permissions getting correct with one schema was droped to blocked view data access, fixes a bug that prevents the save bar from going away when all permissions for group are set to the default values * clean up * remove color changes * prevents parent being set to blocked preventing edits for children entities * add new hasPermissionValueInSubgraph fn, adds modal to warn users we have to upgrade the view data permissions when they upgrade create queries permissions when a child entity is set to blocked * adds test coverage for new modal * removes unused function, adds new updateEntityPermission fn to help consolidate some logic elsewhere * unit test fix and type fix * most pr feedback * updates the confirmation modal copy when changing a parent entity that contains a child with blocked permissions and/or sandboxed children, adds test coverage for that, adds test coverage for permission view data column not appearing in oss * type fix * [Permissions] Add e2e test coverage for blocked permissions enforcements (#46663) * adds test coverage for enforcement of blocked permissions * moves tests around based on pr feedback * copy changes * adds fix to make sure that blocked permissions are not removed from sibling tables that have the create queries permissions upgraded (#46854) * Fix table name lookup for dbs w/ 1 schema per db * add test for blank schema identifiers * Refine sandboxed user perms for query builder access (#46939) * Refine sandboxed user perms for query builder access - Limit create-queries permissions to unblocked tables only - Check user permissions for each table before granting query builder access - Prevent querying of blocked joined tables from query builder for sandboxed users * Adjust permissions for sandboxed users - Grant view-data permissions only for unblocked tables - Revert create-queries permissions to all tables in sandbox - Remove unnecessary intermediate variable * when sandboxing we no longer grant unrestricted view perms for blocked tables * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj remove blank line Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * - make coalesce-test exhaustive (except for sandbox) * Update enterprise/backend/src/metabase_enterprise/sandbox/query_processor/middleware/row_level_restrictions.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * t2/select ... -> database/table-id->database-id * update comment * [Permissions] Prevent "Granular" option in DB View Data options from changing permissions to unrestricted (#46976) * fix * adds back most of the code and limits it to only happen with impersonations, updates test to handle differing logic between the two flows * removes test that is not longer needed * more sandbox join table perms tests --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Kamil Mielnik authored
- use createQuestionAndDashboard helper instead of command - sort imports
-
Kamil Mielnik authored
* Remove unused file * Refactor getCurrentUser command to a TS function util * Refactor createAlert command to a TS function util * Refactor createModerationReview command to a TS function util * Reuse createModerationReview * Refactor createPulse command to a TS function util * Remove references to deleted files * Improve typing
-
- Aug 16, 2024
-
-
Aleksandr Lesnenko authored
* use ECharts tooltip on cartesian charts * fix tooltip lag when changing hovered series * facelift tooltip * fix static viz crashes due to tooltip option * facelift * pie chart echarts tooltip * facelift * facelift * facelift * tweaks * e2e specs * return back the pie other slices tooltip * more specs * specs * fix pie total * fix tooltip overflow * fix specs * fix infinite rerender in embedding mode for charts that have warnings * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Nemanja Glumac authored
* Add sandboxing E2E tests * Fix types * Ignore TS error for now
-
- Aug 15, 2024
-
-
Uladzimir Havenchyk authored
* disable cypress-terminal-report locally * one more check * cleanup
-
- Aug 14, 2024
-
-
metamben authored
* Remove support for questions with metric source * Fix e2e test
-
Nemanja Glumac authored
-
Kamil Mielnik authored
-
Kamil Mielnik authored
* Fix flake * Inline the function
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Add defaultTemporalBucket helper * Add helper to pick default breakout * Move breakout to the front or add one if it does not exist * Add updateQuery to AggregationPicker props * Add tests for creation and reordering of temporal breakouts * Reuse defaultTemporalBucket in withDefaultTemporalBucket * Reorder query operations to make sure the correct names get generated * Remove dependency on referential equality of breakout * Rename updateQuery to onQueryChange * Remove onAddAggregations and onUpdateAggregation for onQueryChange * Extract query update in to separate function * Remove on{Add,Update,Remove}Aggregation in favor of onQueryChange * Remove aggregations from summarize details * Fix e2e tests * Remove conflicting test * Fix recent clause in unit tests * Fix superflouous check for columnAndBucket * Future proof breakout check * Remove reliance on details in the useSummarize hook * Remove details in unit tests * Removal of default summarization should not trigger a query change
-
- Aug 13, 2024
-
-
Nemanja Glumac authored
-
metamben authored
-
Nemanja Glumac authored
* Try to fix dashboard-filters-number flake * Try to fix dashboard-filters-number flake * Intercept all dashboard data requests for number filters
-
Nemanja Glumac authored
Repro #46756: Add/remove a single column in a model with tables joined by themselves adds/removes all columns (#46757)
-
- Aug 12, 2024
-
-
Uladzimir Havenchyk authored
-
Denis Berezin authored
-
Nick Fitzpatrick authored
* Revert "Remove unused humanizeCoercionStrategy and its test suite (#36136)" This reverts commit 5375347e. * humanize coercion strategies, add e2e test * unit test adjustment * pr feedback
-
- Aug 10, 2024
-
-
Aleksandr Lesnenko authored
* conditional dismissal step * check for download status in the container * try fixing flakes again * try again * chartPathWithFillColor already verifies chart has been rendered
-
- Aug 09, 2024
-
-
Oisin Coveney authored
-
Romeo Van Snick authored
Move the compare to the past aggregation to the bottom of the dropdown and hide it when no temporal breakouts are available (#46500) * Move the compare to the past aggregation to the bottom of the dropdown * Fix missing icon property * Hide 'Compare to the past' when there are no temporal columns * Update copy in tests * Add test for questions with no temporal columns * Fix unit test for AggregationPicker * Allow adding a compare aggregation when the first breakout is not temporal too * Rename to 'Compare to the past' in custom column action * Rename to 'Compare to the past' in column drill * Update copy in tests for actions and drills * Move canAddTemporalAggregation to CompareAggregation utils * Use aggregations from the query always * Remove unnecessary displayName check
-