Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Sep 11, 2020
    • Simon Belak's avatar
      Lift dimensions from nested queries (#13202) · f5d209cc
      Simon Belak authored
      * Lift dimensions from nested queries
      
      * Don't try to lift native queries
      
      * Fix tests
      
      * Minor refactor
      
      * Use actual field IDs in tests
      
      * Touchups
      
      * More tests
      
      * Better names
      
      * Add missing require
      
      * add end-to-end test
      
      * Remove stale
      
      * Add breakout support
      
      * Add e2e test for breakout
      
      * Update test [ci drivers]
      
      * Change order [ci drivers]
      
      * Ignore name case [ci drivers]
      
      * make tests portable [ci drivers]
      
      * Ensure vector [ci drivers]
      
      * Test: stable ordering [ci drivers]
      f5d209cc
  2. Aug 28, 2020
    • Robert Roland's avatar
      Slightly rework error handling for site URL (#13173) · 65595fdb
      Robert Roland authored
      Instead of using assert, which throws an exception with confusing detail
      for the users, use a more user-friendly error.
      
      Old error:
      
          Error: Assert failed: Invalid site URL: "https://localhost:3000!"
      (u/url? s)
      
      New error:
      
          Error: Invalid site URL: "http://localhost:3000!"
      
      Resolves #4506
      65595fdb
    • Robert Roland's avatar
      Update mariadb driver to support SYSTEM VERSIONED tables (#13115) · 41447207
      Robert Roland authored
      MariaDB 10.3 adds support for temporal data tables. The JDBC driver
      picks up this support in 2.6.0.
      
      Update to latest JDBC driver, and add a test that a SYSTEM VERSIONED
      table appears in Metabase after a sync.
      
      Resolves #9887
      
      [ci mysql]
      41447207
  3. Aug 12, 2020
  4. Aug 11, 2020
  5. Jul 29, 2020
    • Paul Rosenzweig's avatar
      1f37576c
    • Robert Roland's avatar
      Uppercase certain identifiers for snowflake (#12832) · e360b5d6
      Robert Roland authored
      Snowflake stores warehouse, database and schema names in uppper case.
      When creating the connection details, uppercase them.
      
      Adds a forced-US Locale upper-case function to avoids potential bugs with languages that don't use Latin characters
      
      Resolves #9511
      
      [ci snowflake]
      e360b5d6
    • Robert Roland's avatar
      Support for externally linked tables (#12741) · edf1c036
      Robert Roland authored
      In Redshift (and other databases), foreign tables show up as "EXTERNAL
      TABLE" - allow those to be synced in with Metabase.
      
      Updates the Redshift JDBC driver due to changelog entry from Amazon that
      was occurring and causing immense slowdowns in running the Redshift
      driver tests:
      
          When the Java application uses com.amazon.redshift.api.PGTimestamp directly, an exception occurs.
      
      Resolves #7833
      edf1c036
  6. Jul 28, 2020
  7. Jul 22, 2020
  8. Jul 20, 2020
  9. Jul 17, 2020
  10. Jul 16, 2020
  11. Jul 15, 2020
  12. Jul 09, 2020
  13. Jul 07, 2020
  14. Jul 06, 2020
  15. Jul 02, 2020
  16. Jun 30, 2020
  17. Jun 25, 2020
  18. Jun 24, 2020
  19. Jun 15, 2020
  20. Jun 12, 2020
  21. Jun 08, 2020
    • Walter Leibbrandt's avatar
      Native query snippets (#11965) · 0409161d
      Walter Leibbrandt authored
      
      * Support substituting SQL snippets in queries
      
      * Rename SQL snippets to native query snippets
      
      * Add migration and model for native query snippet table
      
      * Add API endpoints for native query snippets CRUD
      
      Tests are incomplete. Consequently the API is not well tested.
      
      * Cosmetic: Docstring typo and indentation
      
      * Remove pre-delete handler that prevents deletion
      
      It breaks in cases where deletion is reasonable, like during tests. No
      DELETE API endpoint will be added, so no it shouldn't be necessary to
      add any additional safeguards.
      
      * Fix `:database_id` field reference
      
      And remove unused import.
      
      * Test snippets listing via API
      
      * Add more API test stubs
      
      * Refactor snippets listing endpoint for improved readability
      
      * Align NativeQuerySnippet model behavior with Segment model's
      
      * Clean ns
      
      * Fix and test individual snippet read via API
      
      * Fix snippet name schema
      
      * Test creation of snippets via API
      
      * Test update API endpoint for native query snippets
      
      * Handle query snippet model in H2 dump/load commands
      
      * Port load-from-h2 tests to clojure.test
      
      * Deduplicate models list used to dump/load H2 dbs
      
      The failing load-from-h2 test that checks that all models are accounted
      for alerted me that I need to handle the new `NativeQuerySnippet` model.
      However, there was no such test for dump-to-h2. Instead of adding such a
      test, I opted to simply use load-from-h2's list in dump-to-h2 to
      eliminate the problem, rather than testing for it.
      
      * Dump/load collections before models that depend on it
      
      * Linter appeasement
      
      * Use snippet ID and content in query parameter record
      
      * Implement snippet lookup for template tags with ID
      
      * Basic FE support for snippet template tags
      
      * Use shorter "snippet" prefix instead of "native-query-snippet"
      
      * Use simpler `tru` instead of `str` with `deferred-tru`
      
      * Allow whitespace between snippet prefix and name
      
      Also accept any sequence of characters after prefix.
      
      * Don't allow snippet names to start with whitespace
      
      Whitespace is allowed between the `snippet:` template tag prefix and the
      snippet name. That whitespace is trimmed out when extracting the snippet
      name.
      
      * Add database ID to snippet template tags before expanding parameters
      
      * Ensure that snippet db matches query db
      
      * Avoid setting `:template-tags` for native queries without it
      
      * Factor out snippet database ID validation
      
      * Test snippet database ID validation
      
      * Avoid validating nil snippets
      
      * First pass at nested template tags in snippets
      
      * Pass parent query parameters on to nested sub-queries
      
      * Remove unused let-binding
      
      * Added disabled test for reading query param from template tag
      
      * Temporarily disable failing test
      
      * Remove half baked nested snippet support
      
      * Snippet model perms = native query perms
      
      * Rename param k→ks for clarity
      
      * Remove superfluous `some?` call
      
      * Use utility functions to reduce cruft
      
      * Test expansion of multiple snippets in (sub-)query
      
      * Rather use testing utils from metabase.test
      
      * Check for snippet changes only in provided fields
      
      * Deduplicate field checks, with added test case output
      
      * remove unused import from bad merge
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      Co-authored-by: default avatarPaul Rosenzweig <paulrosenzweig@users.noreply.github.com>
      0409161d
Loading