This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 11, 2020
-
-
Simon Belak authored
* Lift dimensions from nested queries * Don't try to lift native queries * Fix tests * Minor refactor * Use actual field IDs in tests * Touchups * More tests * Better names * Add missing require * add end-to-end test * Remove stale * Add breakout support * Add e2e test for breakout * Update test [ci drivers] * Change order [ci drivers] * Ignore name case [ci drivers] * make tests portable [ci drivers] * Ensure vector [ci drivers] * Test: stable ordering [ci drivers]
-
- Aug 28, 2020
-
-
Robert Roland authored
Instead of using assert, which throws an exception with confusing detail for the users, use a more user-friendly error. Old error: Error: Assert failed: Invalid site URL: "https://localhost:3000!" (u/url? s) New error: Error: Invalid site URL: "http://localhost:3000!" Resolves #4506
-
Robert Roland authored
MariaDB 10.3 adds support for temporal data tables. The JDBC driver picks up this support in 2.6.0. Update to latest JDBC driver, and add a test that a SYSTEM VERSIONED table appears in Metabase after a sync. Resolves #9887 [ci mysql]
-
- Aug 12, 2020
- Aug 11, 2020
-
-
Robert Roland authored
This will better handle queries with expressions like [Discount] * [Quantity]
-
- Jul 29, 2020
-
-
Paul Rosenzweig authored
-
Robert Roland authored
Snowflake stores warehouse, database and schema names in uppper case. When creating the connection details, uppercase them. Adds a forced-US Locale upper-case function to avoids potential bugs with languages that don't use Latin characters Resolves #9511 [ci snowflake]
-
Robert Roland authored
In Redshift (and other databases), foreign tables show up as "EXTERNAL TABLE" - allow those to be synced in with Metabase. Updates the Redshift JDBC driver due to changelog entry from Amazon that was occurring and causing immense slowdowns in running the Redshift driver tests: When the Java application uses com.amazon.redshift.api.PGTimestamp directly, an exception occurs. Resolves #7833
-
- Jul 28, 2020
-
-
Robert Roland authored
Fixes an error generating query descriptions with named aggregations and multiple parameters in a aggregation. Resolves #13022
-
- Jul 22, 2020
-
-
Cam Saul authored
-
- Jul 20, 2020
-
-
Robert Roland authored
Adding the missing docstrings to make the linter complain a little less.
-
Robert Roland authored
adds test for coercing all temporal types [ci all]
-
- Jul 17, 2020
-
-
Cam Saul authored
* Fix :user-login activity not being recorded during setup (#12933) * Test fixes
* Fix Database sync not happening at setup (#12826) * Test cleanup. Wow! * More test cleanup * Test/lint fix * test fix * Test fix * Remove unneeded wait * Some more tests & don't instrument log forms * Exclude defmulti/defonce forms from instrumentation; more tests -
Cam Saul authored
-
Cam Saul authored
-
Simon Belak authored
-
- Jul 16, 2020
-
-
Cam Saul authored
* Test refactoring [ci drivers] * Lint fix
-
Robert Roland authored
During startup, we keywordize the name of the Java temporal classes, and during that, we lower-case them. In Turkish, this means minute-of-hour becomes mınute-of-hour (note the i is different) - which causes failures downstream. This moves a test helper into the common test code, and does the lower-casing of the Temporal class names using Locale/US. Resolves #12623 [ci all]
-
Cam Saul authored
* Fix Slack integration * metabase.pulse-test cleanup
* Fixes * Lint fix
-
- Jul 15, 2020
-
-
Simon Belak authored
Don't loose metadata Druid: use placeholder types so we can reuse more code Unambigious default Refactor fallback Add test for 1 and 0 values Create fresh transducer every time Add e2e test for native queries [ci drivers]
-
Simon Belak authored
-
Simon Belak authored
* Fix insights not working on cached results * Make test more robust
-
- Jul 09, 2020
-
-
Cam Saul authored
-
Simon Belak authored
-
Robert Roland authored
Comparing a LocalDateTime to any other time requires assigning a timezone to the datetime. This change removes any reference to the query processor store during the fingerprinting. Adds tests that the fingerprints are also present in the database. [ci all]
-
- Jul 07, 2020
-
-
Cam Saul authored
-
- Jul 06, 2020
-
-
Cam Saul authored
-
Kyle Doherty authored
-
Robert Roland authored
* Test fix
[ci mysql] [ci mariadb] [ci postgres] * object-defaults should always remove created_at/updated_at [ci mysql] [ci mariadb] [ci postgres] Co-authored-by:Cam Saul <github@camsaul.com>
-
Robert Roland authored
* Handle comparing ChronoLocalDateTime and Instants During fingerprinting, we can end up trying to compare two datatypes that are not comparable - ChronoLocalDateTime and Instant. Coerce the ChronoLocalDateTime to a proper Instant for the comparison to work. When earliest / latest are called, the acc parameter must be coerced to a Temporal object also. Resolves #12311 [ci all] * making ->temporal recursive * Get the timezone in an precedence order When converting a LocalTime for fingerprinting, convert to an Instant using the following precedence order: * report timezone * database timezone * system timezone [ci all] * use UTC for timezones
-
Simon Belak authored
-
- Jul 02, 2020
-
-
Simon Belak authored
-
Cam Saul authored
-
- Jun 30, 2020
-
-
Cam Saul authored
* Remove Table.rows entirely * Lots of test updates/modernization * Test fixes
-
- Jun 25, 2020
-
-
Paul Rosenzweig authored
Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Maz Ameli <maz@metabase.com>
-
- Jun 24, 2020
-
-
Simon Belak authored
-
- Jun 15, 2020
-
-
Emmet Murphy authored
-
- Jun 12, 2020
-
-
Damon P. Cortesi authored
* Repro for #12354 * Remove the qbnewb check because that's closed by default now * Fix native -> source query perms handling * Test fix Co-authored-by:
Cam Saul <github@camsaul.com>
-
- Jun 08, 2020
-
-
Walter Leibbrandt authored
* Support substituting SQL snippets in queries * Rename SQL snippets to native query snippets * Add migration and model for native query snippet table * Add API endpoints for native query snippets CRUD Tests are incomplete. Consequently the API is not well tested. * Cosmetic: Docstring typo and indentation * Remove pre-delete handler that prevents deletion It breaks in cases where deletion is reasonable, like during tests. No DELETE API endpoint will be added, so no it shouldn't be necessary to add any additional safeguards. * Fix `:database_id` field reference And remove unused import. * Test snippets listing via API * Add more API test stubs * Refactor snippets listing endpoint for improved readability * Align NativeQuerySnippet model behavior with Segment model's * Clean ns * Fix and test individual snippet read via API * Fix snippet name schema * Test creation of snippets via API * Test update API endpoint for native query snippets * Handle query snippet model in H2 dump/load commands * Port load-from-h2 tests to clojure.test * Deduplicate models list used to dump/load H2 dbs The failing load-from-h2 test that checks that all models are accounted for alerted me that I need to handle the new `NativeQuerySnippet` model. However, there was no such test for dump-to-h2. Instead of adding such a test, I opted to simply use load-from-h2's list in dump-to-h2 to eliminate the problem, rather than testing for it. * Dump/load collections before models that depend on it * Linter appeasement * Use snippet ID and content in query parameter record * Implement snippet lookup for template tags with ID * Basic FE support for snippet template tags * Use shorter "snippet" prefix instead of "native-query-snippet" * Use simpler `tru` instead of `str` with `deferred-tru` * Allow whitespace between snippet prefix and name Also accept any sequence of characters after prefix. * Don't allow snippet names to start with whitespace Whitespace is allowed between the `snippet:` template tag prefix and the snippet name. That whitespace is trimmed out when extracting the snippet name. * Add database ID to snippet template tags before expanding parameters * Ensure that snippet db matches query db * Avoid setting `:template-tags` for native queries without it * Factor out snippet database ID validation * Test snippet database ID validation * Avoid validating nil snippets * First pass at nested template tags in snippets * Pass parent query parameters on to nested sub-queries * Remove unused let-binding * Added disabled test for reading query param from template tag * Temporarily disable failing test * Remove half baked nested snippet support * Snippet model perms = native query perms * Rename param k→ks for clarity * Remove superfluous `some?` call * Use utility functions to reduce cruft * Test expansion of multiple snippets in (sub-)query * Rather use testing utils from metabase.test * Check for snippet changes only in provided fields * Deduplicate field checks, with added test case output * remove unused import from bad merge Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
-