This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 14, 2024
-
-
metamben authored
Fixes #37626.
-
Jeff Bruemmer authored
-
Mark Bastian authored
The `19889-native-query-export-column-order.cy.spec.js` test hasn't flaked in over 30 days per [replay.io](https://app.replay.io/team/dzoyNTM4ZjRmOC05YmFlLTRiYjYtYjljYi1jOGYzOWUyMjRhZWY=/tests/dHJ0OjEyMDIwNjkzMWYyMDExMmUzZmMxNDE0MmMxMWFiY2I3NjlmZTliNDE=?param=dzoyNTM4ZjRmOC05YmFlLTRiYjYtYjljYi1jOGYzOWUyMjRhZWY%3D¶m=tests¶m=dHJ0OjEyMDIwNjkzMWYyMDExMmUzZmMxNDE0MmMxMWFiY2I3NjlmZTliNDE%3D) and I can't make it fail locally after several repeated attempts. At this point I'm just removing the flaky flag and closing until we can get it to flake again. Fixes #36682
-
Cal Herries authored
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
* [Parameters] Cleanup wrong tests * fixup! [Parameters] Cleanup wrong tests
-
Cal Herries authored
-
Raphael Krut-Landau authored
Add an "only show verified models" filter to Browse models
-
Kyle Doherty authored
-
Nicolò Pretto authored
-
Uladzimir Havenchyk authored
* Do not show Unknown field in parameter mappings if there is mapping * Rework to MLv2 * handle virtual cards separately * WIP * fixup * Rework the approach * cleanup * Fix unit test * fixup! Fix unit test * keep only one -1 * Add a test * Split tests into groups * Migrate DashcardCardParameterMapper to TS * Add more types * Add additional check * Improve tests * Move code to utils * Make types more flexible * Better types * Test * Test * Normalize target * Add more tests * Attempt to fix types * Cleanup * Address review * revert unneeded change * Correct types * fixup! Correct types * rely on types :crossfingers:
-
Nicolò Pretto authored
* refactor: extract language step helper * refactor: convert test and util to typescript * fillUserAndContinue and skipWelcomePage * test events sent via snowplow * adds last step "completed" + add step_number in the assertions * adds comment clarifying why we expect 1 event even though we block snoplow * findByTextEnsureVisible().click() can just be findByText.click() as we can't click invisibile things * remove default parameters to fillUserAndContinue * refactor: use findByRole for "Next" button
-
Alexander Polyankin authored
-
- Feb 13, 2024
-
-
adam-james authored
The trend chart email was rendering incorrectly in gmail on iOS for some reason. I think it happened because the Lato font was unavailable in the gmail+iOS context and this new :javascript_visualization (introduced with trend charts for the static-viz rendering pipeline) specified a font family of Lato with no fallbacks. It seems that CSS doesn't inherit font fallbacks from parent elements at all, so even though fallbacks were specified further up the tree, they weren't used. This PR just adds the same fallbacks used elsewhere in static-viz render code.
-
metamben authored
Fixes #37782.
-
Jeff Bruemmer authored
-
Noah Moss authored
-
metamben authored
-
Jesse Devaney authored
* Add fixed width behavior to dashboard header * refactor fixed width styled component * adjust margin to match full-app margin * make styles consistent across public/embed and full-app dashboards * Make public/embed dashboard headers fixed width * add fixed width header behavior to x-ray dashboards * fix dashboard headers button alignment * add tests * add parameter to dashboard to test fixed width behavior * fix tab alignment in public dashboards * refactor tests * only render container when dashboardTabs is not null * improve styled component naming * make dashboard tabs styling consistent between public/embed and full-app dashboards * make dashboard info sidebar width consistent with other dashboard sidebars * align dashboard header and dashboard body position when dashboard sidebar is open * refactor tests
-
Anton Kulyk authored
-
Jeff Bruemmer authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix case where Metabase links are render inside template strings * Add `no-literal-metabase-strings` ESLint rule * Fix all Metabase string errors * Address review: Fix the rule The rule was checking if we have imported the selector `getApplicationName` then ignore all Metabase strings. This is different than `no-unconditional-metabase-links-render` because in that rule, when fixed the Documentation URLs are still in the file, but in this rule, when fixed, there should be no Metabase strings left in the file. * Fix errors from the new lint rule
-
Sloan Sparger authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Do not show Unknown field in parameter mappings if there is mapping * Rework to MLv2 * handle virtual cards separately * WIP * fixup * Rework the approach * cleanup * Fix unit test * fixup! Fix unit test * keep only one -1 * Add a test * Split tests into groups * Improve tests * Move code to utils * Make types more flexible * Test * Test * Normalize target * Add more tests
-
Kamil Mielnik authored
* Removed unused route * Remove invalid test * Remove invalid routes from isNavigationAllowed, update tests * Remove invalid route * Handle /model/:id/notebook route * Migrate Question.prototype.isDataset to Question.prototype.type * Consolidate code * Add missing attribute * Type cards and questions for extra safety * Fix running edited models * Improve diff
-
Chris Truter authored
-
Chris Truter authored
Gotta go fast and gotta stay safe. We have 413 calls to with-redefs, so I'm not going to try get 'em all yet.
-
Romeo Van Snick authored
-
- Feb 12, 2024
-
-
Sloan Sparger authored
* disables password reset button in admin after the user has clicked the button once * add email throttle * fix test --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com>
-
Braden Shepherdson authored
This test has been flaky due to checking its assertion before waiting for the cards on the dashboard to refresh based on the newly added or set filter. This waits for the hourglass icon `loading-spinner` to be gone before checking that the table is properly filtered. [Example failure](https://app.replay.io/recording/e2etestscenariosdashboard-filtersdashboard-filters-idcyspecjs--83043eb8-690e-482e-9108-a24455b4942f)
-
Mark Bastian authored
* Showing currency_in_header options in admin for fields The Table Metadata > Database Name > Table Name > Field Name > Formatting view did not show `Where to display the unit of currency` due to the following previous logic: ``` getHidden: (column, settings, { series }) => settings["number_style"] !== "currency" || series[0].card.display !== "table" ``` The second clause, `series[0].card.display !== "table"`, always returned true since `series[0].card.display` is `undefined`. This has been updated to: ``` getHidden: (column, settings, { series }) => settings["number_style"] !== "currency" && (!series[0].card.display || series[0].card.display === "table") ``` The requirement for hiding this option is now: 1. The series number style must not be currency 2. If the series is currency, the card display type must either be undefined or of type table. Fixes #38021 * Fixing viz settings helper when radiogroup is ambiguous. * add forAdminSettings prop in extraData of column settings --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
Nemanja Glumac authored
* Use "filled" bookmark icon when the item is bookmarked * Update E2E tests * Update the affected unit test * Make dashboard header icons smaller and darker * Make dashboard bookmark icon look like its neighbors * Unify question and dashboard icon's background on hover Question icons have been using `text-medium` unlike dashboard icons that had `text-light`.
-
Uladzimir Havenchyk authored
* Rework findColumnSettingIndexForColumn to MLv2 * WIP * correct test * Update frontend/src/metabase-lib/queries/utils/dataset.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Update frontend/src/metabase-lib/queries/utils/dataset.ts Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Address review --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Braden Shepherdson authored
If present. Also adds these fields to the TS types.
-
Ryan Laurie authored
Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Sloan Sparger authored
-
Sloan Sparger authored
-