Skip to content
Snippets Groups Projects
Select Git revision
20 results
Search by author
  • Any Author
  • Arti Sandeep Dhareshwar Arti Sandeep Dhareshwar adharesh
  • Benjamin Aaron Fleming Benjamin Aaron Fleming bflemin2
  • Brett Edward Caplan Brett Edward Caplan bcaplan2
  • Cedric William Prentice Cedric William Prentice cprentic
  • Chinhnam Dinh Nguyen Chinhnam Dinh Nguyen cn2149
  • Clara Madeleine Rigaux Clara Madeleine Rigaux crigaux
  • Dale Morey Dale Morey dale
  • Daniel Wysling Daniel Wysling wysling
  • David Eisner David Eisner deisner
  • Daya Sagar Daya Sagar dsagar
  • Devon Andrew Lai Devon Andrew Lai dlai12
  • Emily Li Emily Li emilyli5
  • Eric Charles McKinney Eric Charles McKinney emckinne
  • Erica Lee Honadel Erica Lee Honadel ehonade1
  • Jason Alexander Steinberg Jason Alexander Steinberg jsteinb4
  • Jim Zahniser Jim Zahniser zahniser
  • Karthik Valliappan Thiagarajan Karthik Valliappan Thiagarajan kvthiaga
  • Kendrick Maurizio Montecino Kendrick Maurizio Montecino kmtecino
  • Lynne Homann Cure Lynne Homann Cure lhcure
  • Megan Lok-Yi Nee Megan Lok-Yi Nee mnee
20 authors
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 11, 2023
  3. May 10, 2023
    • Natalie's avatar
      docs - rewrite data sandboxes (#30445) · 03e2afba
      Natalie authored
      03e2afba
    • dpsutton's avatar
      Alternative GEOJSON.io fix (#30675) · 37217e7d
      dpsutton authored 
      * Alternative GEOJSON.io fix

rather than not testing, just accept that we might get an expected
location back or we might get nil. This actually represents how the
application will behave and will seamlessly work as the service improves
or continues throwing errors:

```shell
❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
<html>
<head><title>500 Internal Server Error</title></head>
<body>
<center><h1>500 Internal Server Error</h1></center>
<hr><center>openresty</center>
</body>
</html>

❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73"
[{"area_code":"0","organization_name":"GOOGLE","country_code":"US",
  "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8",
  "region":"California","latitude":"34.0544","longitude":"-118.2441",
  "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles",
  "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"},
 {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US",
 "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73",
 "region":"Texas","latitude":"30.2423","longitude":"-97.7672",
 "accuracy":5,"timezone":"America\/Chicago","city":"Austin",
 "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}]
```

Changes are basically

```clojure
(schema= (s/conditional some? <original-expectation-schema>
                        nil?  (s/eq nil)
         response-from-geojson)
```

* Filter to login error messages

```clojure
(into [] (map (fn [[log-level error message]] [log-level (type error) message]))
      error-messages-captured-in-test)
[[:error
  clojure.lang.ExceptionInfo
  "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"]
 [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]]
 ```

* check timestamps with regex

seems like they fixed the service

```shell
curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
[{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}]
```

whereas a few hours ago that returned a 500. And now the timestamps are different

```
;; from schema
"2021-03-18T19:52:41.808482Z"
;; results
"2021-03-18T20:52:41.808482+01:00"
```

kinda sick of dealing with this and don't want to deal with a schema
that matches "near" to a timestamp.

* Restore these

i copied changes over from tim's fix and it included these fixes. But
now the service is fixed and these are the original values from cam's
original fixes
      37217e7d
    • Ryan Laurie's avatar
      add styling to dropzone overlay (#30624) · eba80de4
      Ryan Laurie authored
      eba80de4
    • Jesse Devaney's avatar
      add optional message to error boundaries (#30620) · 118bf803
      Jesse Devaney authored
      118bf803
    • Ryan Laurie's avatar
      add error boundaries to collections (#30587) · ad8126e6
      Ryan Laurie authored
      ad8126e6
    • Ryan Laurie's avatar
      Update upload button tooltip (#30606) · 622ee635
      Ryan Laurie authored 
      * update upload button tooltip

* add upload tooltip subtitle

* update test
      622ee635
    • Nemanja Glumac's avatar
      Fix wrong operator formatting in filter popover header (#30318) · 2c9394b2
      Nemanja Glumac authored 
      * Fix wrong operator formatting in filter popover header

* Replace custom `field.displayName` implementations

* Improve displayName `metabase-lib` method

* Evaluate to an actual display name value

* Add repro for #27104

* Guard against the missing table
      2c9394b2
    • Alexander Polyankin's avatar
      Add back button to return to the active dashboard (#30584) · bba77f97
      Alexander Polyankin authored
      bba77f97
  5. May 09, 2023
  7. May 08, 2023