This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 01, 2024
-
-
metamben authored
* Generate unique user name in table-privileges-test
-
Jesse Devaney authored
* fix click behavior for routing to a new tab on the same dashboard * update changes * add test to validate behavior
-
Nemanja Glumac authored
-
Case Nelson authored
* Fix snowflake ssh tunnel * Put test where it will run in CI * Override incorporate-ssh-tunnel * Revert snowflake in util.ssh-test * Move tunnel connection tests to sql_jdbc * Add mock-server fixture * Exclude drivers from tunnel test * Fix up reconnection tests * Exclude more drivers * Address PR feedback
-
Anton Kulyk authored
* Fix dashboard tabs drop animation * Remove animation delay from an e2e test
-
Nicolò Pretto authored
* adds /api/setup/token-check and add license-token to POST /api/setup (#38858) * adds /api/setup/token-check and add license-token to POST /api/setup * refactor tests * license-token => license_token for consistency * fixed test message * fix nesting in test * Add the step in the FE and pass the token to the setup api call (#38953) * refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer * Revert "refactor: go back to saving the index for the step, to avoid having to use a selector that needs global state in the reducer" This reverts commit ee7e44f48788528e059c3f1f8816a73b675e082b. * feat: adds UI and token api logic * test structure for paid features * initSetup action as workaround * pass token to the /setup endpoint * add jest tests for ee without token case * add warning comment on getIsPaidPlan * copy old schema for better diff * add license_token step seen event in the schema * update e2e tests to make them pass * should make e2e pass * explicitly check that the license activation step is not rendered * useStep hook * refactor: simplify logic in step_number * refactor: getInactiveStepTitle * fix too many slashes in import * refactor: rename selectThisStep to handleStepSelect * use isSetupCompleted from useStep * adds expect().toBeInTheDocument * remove waitFor in favor of await findBy * add submit snowplow event and increase the onboarding version in the events (#39151) * trackLicenseTokenStepSubmitted * adds a test and makes sure we're passing the token as undefined, not as null * clean up * remove waitFor * goToNextStep in all thunks (#39103) * Revert "initSetup action as workaround" This reverts commit 0318a55b. * goToNextStep thunk * Change the Next button to skip for the license activation step (#39292) * change the Next button to be Skip * trim token input * fix e2e test * fix quotes * hide error when the user changes the token (#39440) * keep token visible when going back (#39443)
-
Anton Kulyk authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* Utilize diagnoseExpression to detect expression errors * Add expressionPosition * Replace boolean with filter for startRule * Revert "Replace boolean with filter for startRule" This reverts commit 9d4cca4734a7a14021a2669a54f58584b0c5c7c9. * Remove console * Fix comments
-
Alexander Polyankin authored
-
Denis Berezin authored
* Remove unused global css * More clean-up * Review fixes
-
Chris Truter authored
* Vague uncertainty from 5 years ago - gone * Remove obsolete TODO * Link to issue for incomplete date formatting
-
Chris Truter authored
-
Ryan Laurie authored
* notify slack on cross-version test failure * update name
-
Nemanja Glumac authored
* Treat `dismissed-browse-models-banner` as a user-setting * Treat `dismissed-custom-dashboard-toast` as a user-setting
-
Uladzimir Havenchyk authored
* canRun is expensive, reduce number of calls * Drop unused variables * do not calculate TimeSeriesChrome in notebook mode * Do not re-render ColumnNotebookCellItem unnecessary * Do not re-render notebook steps unnecessary * Revert "Do not re-render ColumnNotebookCellItem unnecessary" This reverts commit 09cca64684c42b60f2b44f48d397b554130eea94. * Do not render main in notebook mode
-
Kamil Mielnik authored
* Revert "Fix missing result metadata (#39201)" This reverts commit d26b7820. * Move resultsMetadata mapping to getSubmittableQuestion * Bring back the test
-
- Feb 29, 2024
-
-
bryan authored
* [AS+BCM] fix first 3 todos * [AS+BCM] add issues * add jdbc proxy issue * driver/driver-features -> driver/features * killing more todos and remove `supports?` * add more issues * dont let people who dont have snippet perms access snippets * adding more issues * replace calls to support? in mongo driver * fix namespace sorting * whitespace
-
Mark Bastian authored
* Fixing E2E Cross-version Tests E2E cross version tests were broken for multiple reasons, primarily due to changes made in UI layout, cypress testing, and data changes. Overall, the basic workflows still work, but subtle click order differences and other small changes made the entire job consistently fail. To fix this, this PR: - Provides a function, `parseVersionString`, which computes version information provided a test version string. This information includes the raw string version, the edition (ee or oss), and the major, minor, and patch version of the version string. - In the same file, `cross-version-helpers.js`, adds constants identifying versions in which certain breaking UI or Cypress changes occurred. - Finally, a set of exported functions are provided which take a version object and execute conditional logic based on the provided version so that behavior is consistent across Metabase versions. The versions are computed in `cross-version-source-helpers.js` and `cross-version-target-helpers.js` and are used in js files as shown: ```js import { visualize } from "e2e/support/helpers"; import { fillAreaUnderLineChart, newQuestion, saveQuestion, } from "e2e/test/scenarios/cross-version/helpers/cross-version-helpers.js"; ``` This then allows logic like the below, where the high level call is made and the right logic is dispatched based on the version information. ```js it("should create questions", () => { cy.signInAsAdmin(); cy.visit("/question/new"); newQuestion(version); // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage cy.findByText("Orders").click(); }) ``` Other smaller changes were also made that created a more universal sequence of UI actions. Fixes #39229 * clear -> click * Fixing area icon selection * Restoring scheduling to align with master * fe lint
-
Alexander Solovyov authored
-
Chris Truter authored
-
Nick Fitzpatrick authored
* Dashboard Header FC, using entity, select, and dispatch hooks * resolving types * updating other use of getDashboardActions * PR feedback
-
Nick Fitzpatrick authored
-
metamben authored
* Hack test case to unblock Oracle tests In metabase.query-processor-test.implicit-joins-test/implicit-joins-with-expressions-test we calculate an interval by going back from today a number of years to arrive at 2019. On February 29, this calculation fails with Oracle because there was no February 29 in 2019. This hack changes 2019 to 2020 and makes Oracle happy. breakout-on-temporally-bucketed-implicitly-joined-column-inside-source-query-test had to be adjusted too.
-
Alexander Solovyov authored
-
bryan authored
* wip * SLO works with auth slo handler route * move slo handling endpoint to /auth/sso/handle_slo * fix slo redirect url * SLO works, and the sso-handle-slo for saml is where it belongs - a ton of cleanup * fix api/session namespace + add docstrings * cleaning up logout action * add slo logout test along with slo response xml * whitespace + linter * add docstring * update exclusions in deps.edn * un-require metabase-enterprise ns from oss ns * add docs for how to setup SLO to metabase docs * docs: clarify that setting up SLO is optional * move slo logout endpoint into ee code - removes sso-info defenterprise since it is no longer needed * use current version of saml20-clj --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
dpsutton authored
* Don't delete "off" persisted_info records If they are off, they are "eligible" models for persistence that we do not want to persist. And to remember that use choice to not persist them we need to keep the record around. This was handled previously, but https://github.com/metabase/metabase/pull/39219 was a bit too blunt. We had a bunch of records in a "creating" state that we weren't removing, so i deleted them regardless of state. But we want to make sure that the "off" ones are not deleted. On stats, a bunch of ones that were set to off are now slated to be persisted after the prune job deleted the persisted_info records. * unused local. whoops
-
Jesse Devaney authored
* improve error messages * update error message
-
Nicolò Pretto authored
-
Jeff Bruemmer authored
* filter notes * usage insights notes
-
Nemanja Glumac authored
* Create and use new action `updateUserSetting` * Add E2E reproduction for #39221 Fixes #39221.
-
Ryan Laurie authored
* Make a more versatile and easy-to-use list virtualizer * use new virtualized list in archive app * update archive tests * better mock
-
Ryan Laurie authored
-
Uladzimir Havenchyk authored
-
Alexander Solovyov authored
-
Ryan Laurie authored
* translate object action select strings * import order fix
-
Uladzimir Havenchyk authored
-
Kyle Doherty authored
* add content from Notion documentation to storybook guidlines for Modal * clean up examples a bit
-
Anton Kulyk authored
-
Uladzimir Havenchyk authored
* Drop duplicated composes * De-compose flex * De-compose flex-full * De-compose justify-center * De-compose align-center * De-compose flex-1-quarter * De-compose text-centered * De-compose full * De-compose relative * De-compose flex-no-shrink * De-compose block * De-compose inline-block * De-compose flex-row * De-compose ml-auto * De-compose mr-auto * De-compose full-height * De-compose absolute * De-compose top * De-compose align-self-start * De-compose no-decoration * De-compose flex-half * De-compose cursor-pointer * De-compose flex-aligh-right
-