Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 17, 2023
  2. Aug 02, 2023
    • Jesse Devaney's avatar
      Enable parameter mapping for heading dash-cards (#32462) · 84537554
      Jesse Devaney authored
      
      * add parameter mapping to heading cards
      
      * update unit tests for new props
      
      * memoize parameter mapped content
      
      * add heading card tests to text parameters spec
      
      * update test descriptions
      
      * add BE for params/substitute_tags
      
      * fix tests
      
      * fix test
      
      * update FE parameter substitution to use optional flag
      
      * heading cards should not escape characters
      
      * add test for dashboard sub
      
      * remove invalid specs -> desired behavior changed
      
      - enabled parameter mapping for heading cards
        - in parameter editing mode, we should display the option to map a parameter to a heading text variable, so we should not display the original text
      
      * fix react hook dependencies
      
      * improve parameterValues type
      
      * refactor E2E test to a unit test
      
      * address nits
      
      * fix spacing
      
      * update types and add unit tests
      
      * fix type errors
      
      ---------
      
      Co-authored-by: default avatarJerry Huang <jhuang37050@gmail.com>
      Unverified
      84537554
  3. May 29, 2023
  4. May 24, 2023
  5. May 17, 2023
  6. May 15, 2023
  7. May 08, 2023
    • Anton Kulyk's avatar
      Remove deprecated types (#30585) · 1490fd9c
      Anton Kulyk authored
      * Remove `metabase-types/types/Collection`
      
      * Remove `metabase-types/types/Dashboard`
      
      * Remove `metabase-types/types/Dataset`
      
      * Remove `metabase-types/types/Auto`
      
      * Remove `metabase-types/types/Label`
      
      * Remove `metabase-types/types/Revision`
      
      * Remove `metabase-types/types/Snippet`
      
      * Remove `metabase-types/types/User`
      
      * Remove `metabase-types/types/Metadata`
      
      * Remove `metabase-types/types/redux`
      
      * Remove `metabase-types/types/Segment`
      
      * Remove `metabase-types/types/Metric`
      
      * Remove `metabase-types/types/Visualization`
      
      * Remove `metabase-types/Field`
      
      * Remove `metabase-types/types/Table`
      
      * Remove `metabase-types/types/Database`
      
      * Remove `metabase-types/types/index`
      
      * Remove `metabase-types/types/Query`
      
      * Remove `metabase-types/types/Parameters`
      
      * Remove `metabase-types/types/Card`
      
      * Remove irrelevant remapped column test
      
      * Fix type
      Unverified
      1490fd9c
  8. Apr 19, 2023
    • Braden Shepherdson's avatar
      [MLv2] Change how `TemplateTag.widget-type` works for field filters (#30191) · 86688e10
      Braden Shepherdson authored
      The current state is a collection of hacks to preserve some legacy
      behavior (eg. normalization sets a blank `widget-type` to `"category"`)
      and it doesn't work properly right now.
      
      An example of a currently-broken case:
      - `SELECT * FROM Orders WHERE {{tag}}`
      - Set it to a Field Filter and select People > LONGITUDE
        - Or some other field for which type we don't have a widget.
      - It shows "None" as the widget type, and the widget isn't shown at the
        top.
      - Save the question and reopen it.
      - Now the widget is visible (and a bit broken) as a `"category"` type.
      
      This is because on reading from the appdb it gets normalized.
      
      This PR uses `"none"` properly for cases where there are no widget
      options for the field type (eg. longitude), and updates all the usage
      sites to properly handle `"none"` rather than missing/undefined.
      
      Existing saved questions with a blank `widget-type` will continue to
      "work" as they currently do.
      Unverified
      86688e10
  9. Apr 17, 2023
  10. Apr 14, 2023
  11. Mar 22, 2023
  12. Mar 16, 2023
  13. Feb 09, 2023
  14. Feb 02, 2023
  15. Jan 31, 2023
  16. Jan 26, 2023
  17. Jan 23, 2023
    • Ryan Laurie's avatar
      Actions on dashboards (redux) (#27815) · 9ca4af5b
      Ryan Laurie authored
      
      * update dashboard + card + parameters to support actions
      
      * Add ActionViz Components
      
      * add ActionParameterInputForm
      
      * Add AddActionSidebar and ActionPicker
      
      * move ActionParametersInputModal
      
      * remove page and app references
      
      * reorganize utils
      
      * update types
      
      * check dashboard eligibility for actions access
      
      * fix typos
      
      * remove reference to list viz
      
      * show all models in action picker
      
      * allow delete actions to submit with no form fields
      
      * remove unused testing functions
      
      * add ActionViz unit tests
      
      * add ActionParametersInputForm unit tests
      
      * update dashboard + card + parameters to support actions
      
      * add ActionParameterInputForm
      
      * move ActionParametersInputModal
      
      * check dashboard eligibility for actions access
      
      * Fix native query editor mock in `ActionCreator` tests (#27794)
      
      * Update `NativeQueryEditor` mock
      
      * Mock `NativeQueryEditor` before registering viz
      
      * more cleanup
      
      * add more tests
      
      * move api mock to setup function
      
      * click the correct click icons
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      9ca4af5b
  18. Jan 21, 2023
  19. Jan 20, 2023
    • Ryan Laurie's avatar
      Actions on Dashboards 1: Import UI from `data-apps-main` (#27756) · 68dc2e0f
      Ryan Laurie authored
      
      * update dashboard + card + parameters to support actions
      
      * Add ActionViz Components
      
      * add ActionParameterInputForm
      
      * Add AddActionSidebar and ActionPicker
      
      * move ActionParametersInputModal
      
      * remove page and app references
      
      * reorganize utils
      
      * update types
      
      * check dashboard eligibility for actions access
      
      * fix typos
      
      * remove reference to list viz
      
      * show all models in action picker
      
      * allow delete actions to submit with no form fields
      
      * remove unused testing functions
      
      * add ActionViz unit tests
      
      * add ActionParametersInputForm unit tests
      
      * update dashboard + card + parameters to support actions
      
      * add ActionParameterInputForm
      
      * move ActionParametersInputModal
      
      * check dashboard eligibility for actions access
      
      * Fix native query editor mock in `ActionCreator` tests (#27794)
      
      * Update `NativeQueryEditor` mock
      
      * Mock `NativeQueryEditor` before registering viz
      
      * more cleanup
      
      * add more tests
      
      * move api mock to setup function
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      68dc2e0f
  20. Jan 19, 2023
  21. Jan 17, 2023
  22. Jan 16, 2023
  23. Jan 12, 2023
  24. Jan 10, 2023
  25. Jan 09, 2023
    • Anton Kulyk's avatar
      Add `eslint-plugin-jest` (#27574) · fb88dbef
      Anton Kulyk authored
      * Install `eslint-plugin-jest`
      
      * Enable `eslint-plugin-jest`
      
      * Run eslint auto fix
      
      * Fix linter issues
      
      * Fix get-column-key
      
      * Fix extra space
      
      * Fix ChartSettingFieldPicker
      
      * Fix eslint issues
      
      * Remove redundant describe
      Unverified
      fb88dbef
  26. Jan 05, 2023
    • Anton Kulyk's avatar
      Improve sample state fixture (#27399) · 22c19cb6
      Anton Kulyk authored
      * Remove not used `StaticEntitiesProvider`
      
      * Fix typos
      
      * Convert sample database fixture to TypeScript
      
      * Fix `EnhancedState` typing
      
      * Remove global eslint comment
      
      * Fix invalid import
      
      * Fix incorrect type
      Unverified
      22c19cb6
  27. Dec 22, 2022
  28. Dec 20, 2022
  29. Dec 09, 2022
  30. Nov 23, 2022
    • Anton Kulyk's avatar
      Convert `DashCard` to TypeScript (#26672) · 0c894937
      Anton Kulyk authored
      * Add `query_average_duration` to `Card` type
      
      * Add missing props to `DashboardOrderedCard` type
      
      * Use up-to-date Card type for DashboardOrderedCard
      
      * Extend `Series` type
      
      * Convert `DashCard` to TypeScript
      Unverified
      0c894937
  31. Nov 10, 2022
  32. Oct 27, 2022
  33. Oct 26, 2022
Loading