This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 10, 2024
-
-
Nick Fitzpatrick authored
* Migrate Model Indexes to RTK * Sorting out types... I think? * remove unneeded comment * replacing the selector with an initiate to ensure that there is data * catching and throwing error * Updating unit tests
-
Jeff Bruemmer authored
-
John Swanson authored
This introduces a new metadata on commands, `:requires-init`. If set, we'll run `metabase.core/init!` before running the command. `init!` will initialize the database and run our normal startup, though it won't actually start the Metabase server. This allows you to use ``` env MB_CONFIG_FILE_PATH=... java -jar metabase.jar import /my/metabase/export ``` We'll run the normal init process (creating the internal user, loading from the config file, etc), then run the command. On my machine this adds about 2-3 seconds to the time it takes to run an `import`.
-
adam-james authored
* start adding some util fns to download-exports-test ns * wip improving test util fns * add subscription attachment util fn * add tests to catch download/export differences * viz-settings from card and dashcard merged properly * revert these changes which probably aren't needed * split test: downloads can be parallel, email attachments cannot * normalize viz-settings no matter their origin * Update test/metabase/api/downloads_exports_test.clj Co-authored-by:
Alexander Solovyov <alexander@solovyov.net> * Incorporate some review feedback * rendered table cards also respect column names * Clean up table render tests and remove unhelpful render test utils The big removal of code in the render test utils namespace is a clean up task that could've happened sooner, but this table test adjustment is the perfect opportunity to clean up. I had made the test utils before I truly knew how best to use `mt/with-temp`, so it had a lot of poorly implemented 'generators' that were doing a poor job of creating mock data for the rendering functions anyway. So, reworking a few table tests here to just use a temp card is way more inline with the rest of the codebase, and actually improves confidence that the tests are testing on well-formed data to begin with. --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
Noah Moss authored
-
bryan authored
* add admin-only user-local setting that controls perms tutorial * Adding modal and banner, user setting for dismissable banner * copy changes * adjust so modal only appears on data permission page * e2e adjustments, adding banner test * never show the modal or banner on new instances * add test * e2e adjustments, copy update * more PR feedback * move modal/banner settings & tests + clarify tests * query for v50 migration execution works on mysql - move changelog lookup into metabase.db.liquibase * no race conditions in changelog-table-name The previous implementation of this function was hitting this liquibase issue: https://github.com/liquibase/liquibase/issues/2966 * revert changelog-table-name - simply lookup the changlog row --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
Cal Herries authored
-
Nemanja Glumac authored
* Reproduce #45036 * Add repro for #44910
-
Kamil Mielnik authored
* Add a test verifying that fonts are loaded * Verify font is mentioned in HTML * Bring back working assertions * Add wait * Disable speedy * Disable CSP and emotion cache * Revert "Disable CSP and emotion cache" This reverts commit 573e99bfa4c99b8c695a624e1d5d1e230833cc62. * Revert "Disable speedy" This reverts commit 6f9962b869834cecdbe270e87e065ed41adf49b4. * Don't use local fonts * Revert "Don't use local fonts" This reverts commit 17c58aa73d22603241de8b6bf84b7390ad1b9410. * Force Lato * Fix storybook file name * ESLint * Add more !important * Revert !important * Add font-family assertion * Move test
-
Tim Macdonald authored
-
Nemanja Glumac authored
-
Chris Truter authored
A bunch of small improvements, notably a timeout and support for MSSQL square bracket quotes.
-
Ryan Laurie authored
* try fixing cross-version tests * restore legacy metrics * its not legacy in v43 * Dont got echarts either * newfangled echarts * run cross-version tests on code changes in the tests * enable slack message * don't always run cross-version tests * whitespace
-
github-automation-metabase authored
-
Chris Truter authored
-
Phoomparin Mano authored
* add refresh auth token function * provide a default implementation for refreshing auth tokens * rename getRequestToken to fetchRequestToken * add docs on customizing jwt authentication * clarify docs, add error handling and failing tests * update tests to pass * re-export FetchRequestTokenFn type * re-export EmbeddingSessionToken type
-
Cal Herries authored
-
- Jul 09, 2024
-
-
Denis Berezin authored
* feat(sdk): Add Dashboard loading event handlers * Refactor to redux state * Fix logic with load with cards data * Fix nasty e2e fails * Fix nasty e2e fails * Add global events * Fix issue with loading event * Fix issue with loading event * Review fixes * Add unit tests * Fix unit tests
-
Cal Herries authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Uladzimir Havenchyk authored
* perf: pass uuid to BE to enable metadata caching during fetching dashboard * fixup! perf: pass uuid to BE to enable metadata caching during fetching dashboard * Add wildcard on interceptions * Add tests
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
-
Alexander Solovyov authored
-
Noah Moss authored
-
John Swanson authored
Prevent anything from being moved to the trash, or created in the trash.
-
Alex Yarosh authored
-
Aleksandr Lesnenko authored
-
Phoomparin Mano authored
-
dpsutton authored
Before ==== ``` 2024-07-04 15:54:39,084 INFO metabase.server :: Shutting Down Embedded Jetty Webserver Exception in thread "Thread-9" java.util.IllegalFormatConversionException: f != java.lang.Long 2024-07-04 15:54:39,122 WARN db.liquibase :: (#object[liquibase.Liquibase 0x2b7e6614 liquibase.Liquibase@2b7e6614]) at java.base/java.util.Formatter$FormatSpecifier.failConversion(Unknown Source) at java.base/java.util.Formatter$FormatSpecifier.printFloat(Unknown Source) at java.base/java.util.Formatter$FormatSpecifier.print(Unknown Source) at java.base/java.util.Formatter.format(Unknown Source) at java.base/java.util.Formatter.format(Unknown Source) at java.base/java.lang.String.format(Unknown Source) at clojure.core$format.invokeStatic(core.clj:5770) at clojure.core$format.doInvoke(core.clj:5764) at clojure.lang.RestFn.invoke(RestFn.java:423) at metabase.db.liquibase$wait_for_all_locks.invokeStatic(liquibase.clj:258) at metabase.db.liquibase$wait_for_all_locks.invoke(liquibase.clj:251) at metabase.db.setup$release_migration_locks_BANG_.invokeStatic(setup.clj:175) at metabase.db.setup$release_migration_locks_BANG_.invoke(setup.clj:170) at metabase.db$release_migration_locks_BANG_.invokeStatic(db.clj:91) at metabase.db$release_migration_locks_BANG_.invoke(db.clj:86) at metabase.core$destroy_BANG_.invokeStatic(core.clj:90) at metabase.core$destroy_BANG_.invoke(core.clj:81) at clojure.lang.AFn.run(AFn.java:22) at java.base/java.lang.Thread.run(Unknown Source) ``` And now it will correctly log ``` 2024-07-09 16:04:28,345 INFO db.liquibase :: Waiting for migration lock(s) to be released (max 0.4 secs) ``` Why no tests? ==== There _is_ a test that would have caught this. And in fact running at the repl will catch it: ```clojure liquibase=> (do (require 'clojure.test 'metabase.db.liquibase-test) (clojure.test/run-test metabase.db.liquibase-test/wait-for-all-locks-test)) Testing metabase.db.liquibase-test ERROR in (wait-for-all-locks-test) (Formatter.java:4515) :h2 Will timeout if a lock is not released expected: (= :timed-out (liquibase/wait-for-all-locks sleep-ms timeout-ms)) actual: java.util.IllegalFormatConversionException: f != clojure.lang.Ratio ``` But this _passes_ in CI: ``` ❯ clj -X:dev:test :only metabase.db.liquibase-test/wait-for-all-locks-test Finding tests took 23.5 s. Running 1 tests Running before-run hooks... Ran 1 tests in 1.461 seconds 3 assertions, 0 failures, 0 errors. {:test 1, :pass 3, :fail 0, :error 0, :type :summary, :duration 1461.175042, :single-threaded 1} Ran 0 tests in parallel, 1 single-threaded. Finding and running tests took 25.0 s. All tests passed. Running after-run hooks... ``` And that's because the log level in testing is FATAL and this is an INFO level log. Discussed ways to improve this like adding a null logger during CI but we aren't ready to increase CI times for that just yet.
-
Nick Fitzpatrick authored
* move subtext to command palette item generation. Support model-indexes * changing text, adding unit tests * PR Feedback
-
Nicolò Pretto authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
* Add the default pinned metric description * Expand unit tests to repro #45270
-
Oisin Coveney authored
-
Cal Herries authored
-
Nemanja Glumac authored
* Enable "Add to dashboard" for metrics v2 * Add repro for #44220
-
Romeo Van Snick authored
-
Alexander Solovyov authored
-