* Updating to cypress 12

* updating deps

* Updating Tests. Be Green Plz

* removing custom test id from select button

* Select Button Tuning

* adding hover states, switching icons for buttons

* ChartSettingFieldsPicker unit tests

* fixing background hover state

* using userEvent.click instead of fireEvent

* adjusting e2e tests

* Register new E2E path alias

* Move E2E support files

* Move E2E runner files

* Move E2E snapshot related files

* Move E2E visual regression tests

* Move E2E `downloads` scenarios

* Move E2E `admin` scenarios

* Move E2E `auditing` scenarios

* Move E2E `bining` scenarios

* Move E2E `ccollections` scenarios

* Move E2E `cross-version` scenarios

* Move E2E `custom-column` scenarios

* Move E2E `dashboard` scenarios

* Move E2E `dashboard-filters` scenarios

* Move E2E `dashboard` reproductions

* Move E2E `embedding` scenarios

* Move E2E `filters` scenarios

* Move E2E `joins` scenarios

* Move E2E `models` scenarios

* Move E2E `native-filters` scenarios

* Move E2E `native` scenarios

* Move E2E `onboarding` scenarios

* Move E2E `organization` scenarios

* Move E2E `permissions` scenarios

* Move E2E `question` scenarios

* Move E2E `visualizations` scenarios

* Move E2E `sharing` scenarios

* Move E2E `docker-compose`

* Fix commands imports

* Fix helpers imports

* Fix downloads reproductions imports

* Fix integration imports

* Move visual regression tests

* Various fixes

* Move `validate-e2e-files` script

* Add eslint rules for E2E folder

* Improve file paths

* Move `cross-version` tests into scenarios

* Path fixes

* Register E2E alias in tsconfig

* Fix failing tests after rebase

* Revert "Fixing Table isValid check (#28411)"

This reverts commit 5e18759f.

* Revert "GH 28304 and GH 28311 (#28314)"

This reverts commit 47bad0d3.

* revert column settings changes

* object detail view

* adjusting e2e tests

---------

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* behavior logic

* restructure Chart Settings HTML

* adjusting e2e tests

* adjusting unit tests

* Removing pivot-grouping column when checking isSensible

* fixing footer button sizing, unit test

* adjusting e2e tests

* rename onShowWidget

* temp

* POC

* temp

* Rework logic to use dimensions rather than pass around mbql

* PR Cleanup and feedback

* adjusting e2e tests

* Add unit tests

* cleaning up unit tests

* Hiding disabled columns from sorting list

* breaking down field options function

* passing  to settings def and column editor component

* Adding e2e tests, adjusting to fix 13455

* shame

* removing unneeded import

* Updating Eye Icons

* Updating Tests

* Refactor DataReference

* Don't show card tags in the sidebar

* Refactor template tag regexes

* Add models to DatabaseSchemasPane

* Restyle SchemaPane

* Anton's suggestions

* Rename show to onItemClick

* Remove another ternary

* Add openDataReferenceAtCard action, but not opening the sidebar yet

* Fix useEffect static analysis

* Types

* Get opening the sidebar at a model working, at the expense of model autocomplete

* Change icon of ModelPane if it's a question

* Tidy

* Refactor DatabasePane

* Move onItemClick and back callback logic to redux actions

* Add e2e test

* Add back autocomplete

* Load question tables correctly

* Restore autocomplete

* Fix card tag autocomplete on the first character of the tag name

* Update template tag editor visibility test to not test for card tags

* Fix tests for cardIdFromTagName

* Tidy tag editor

* Typo

* Fix undefined error

* Tidy NativeQueryEditor.cardTagId

* Tidy nextCompleters

* Tidy

* Update unit tests for tag editor visibility

* Tidy

* Tidy

* Add test for models

* Check fields have loaded before displaying table fields

* Tidy

* Rename ModelPane to QuestionPane

* Rename card to question

* Remove unused files

* Tidy

* Fix renaming

* Fix renaming

* Make variable template tag names non-empty

* Fix test flakiness

* Tidy

* Tidy

* Remove is_saved_questions check

* Rename

* Replace setDataReferenceStack action with selector and fix test

* Initialize dataReferenceStack to null as an "uninitialized" state to fix the back button

* Update e2e tests

* Update e2e tests

* Replace long ternaries

* Allow slugs in question template tags, like `{{#123-a-question}}`

* Update CardTagEditor to add slug names to the query text, instead of IDs

* Fix dispatchApiErrorEvent prop for entity object loader

* Ignore errors loading names of referenced questions

* Fix e2e tests

* Implement autocomplete for model slugs

* Prioritize models above questions

* Make the ace_autocomplete popup slightly wider to account for longer question names

* Reorder requires

* Remove unnecessary ? from endpoint string

* Add e2e test for card tag autocomplete

* Fix NativeQueryEditor not swapping back to standard completers

* Refactor replaceCardSlug

* Add e2e test for updating tags when card name is changed

* Refactor updateReferencedQuestionNames

* Add slug method to Question class

* Use map for autocomplete API results

* Rename endpoint path

* Rename for consistency

* Add docstrings

* Update slug() to guard against undefined names

* Fix read permissions for the endpoint

* Add backend test

* Fix unit tests

* Fix permissions error

* Make regex simpler

* Undo change of value on QuestionPicker

* Fix tests

* Fix models e2e test

* Simplify updateReferencedQuestionNames

* Fix bugs in updateReferencedQuestionNames

* Rename variable

* Move NativeQuery methods to new native-query utils module

* Fix typescript errors

* Fix e2e tests

* Fix e2e test

* Fix BE tests

* Actually fix BE test

* Refactor updateQuestionTagNames

* Align comments

* Reorder autocomplete results

* Refactor: move all query text tag utils in one place

* Add tests for regex

* Add unit tests for cardIdFromTagName

* Add schema to autocomplete_suggestions endpoints

* Add perms checks to autocomplete tests

* Add unit test for updateCardTagNames

* Rename updateQuestionTagNames -> updateCardTagNames

* Tidy card-autocomplete-suggestions-test

* Rename questionReference-> cardTag for consistency

* Rename card-reference -> card-tag for consistency

* Use ternary operator for comprehension

* Fix broken swapCompleters

* Use prefix match on name for 123-foo case

* bulk filter modal v3

* update prettier

* update prettier styling

* hide filter sidebar button

* Prototype new nav skeleton (#20875)

* yarn

* begin basic layout flip

* rough in collections list

* position query builder

* remove fitViewport from QB to fix layout quirks

* extract search

* clean up props

* position search / style

* fix dashboard layout

* fix search icon

* move ProfileLink

* tweak spacing

* fix burger

* add basic toggle

* tweak layout for sidebar toggle

* tweak style

* tweak sidebar sizing

* Quick fix to prototype starting points init (#20922)

* fix scroll overflow on sidebar

Co-authored-by: Gustavo Saiani <gustavo@poe.ma>

* add currentUser to profile link

* move footer items out of collection sidebar

* tweak footer style

* fix hover style

* clean up footer

* fixup

* remove un-needed overflow hidden

* hide app bar when in admin mode

* merge sidebar header into new color scheme / nav layout

* clean up headers

* fix root collection spacing

* smaller font size for nav items

* provide flex context, fixes metadata editing

* fix login page

* Remove console logs

* Put user's personal collection under Our analytics (#21061)

* Browsing | Handle long item names in the sidebar (#21063)

* Handle long names in the nav sidebar

* Show tooltip with a full item name if its cut

* Browsing | Fix data reference & admin permissions layout (#21101)

* Remove admin navbar CSS fix

* Handle admin navbar in root App component

* Extract styled components

* Fix data reference layout

* Fix main container height

* Browsing | Hide sidebar for questions, models and dashboards on page open (#21064)

* Manage default sidebar visibility

* Handle ad-hoc questions better

* Move nav elements based on feedback (#21190)

* scoot buttons around

* move logo to appbar, scoot search

* remove user footer, home link [ci skip]

* review feedback [ci skip]

* fix accidental removal of links (minimalism was a fad anyway) (#21192)

* add button classes to new button (#21213)

* Nav visual changes (#21223)

* switch nav bg + move styling to NavRoot

* readable text

* increase contrast

* selected icon color

* remove bottom padding

* search bar color

* restructure sidebar position

* fix sidebar header color

* move to fixed when small

* fix multiple scrollbars

* fix sidebar width

* home as own item, gear below

* fix admin nav

* extract nav constant, fix types

* remove unused constant [ci skip]

* New nav - get base colors in order (#21262)

* new sidebar button

* nav bg to bg-light

* fix link track, remove extra home link

* color tweaks

* swap colors

* Fix E2E tests for new navigation UI (#21196)

* Use `main` HTML tag for main page content

* Add extra UI helpers for Cypress

* Fix tests failing due to nav UI changes

* Remove not needed NavBar code

* Fix loading databases list

* Use `navigationSidebar` helper for collections

* Use `navigationSidebar` for collection tests

* Close sidebar in SQL filters tests

* Extract AppBar component to `metabase/nav`

* Fix test

* Fix test

* Skip sidebar visibility control test

* Fix JSON engine DB check

* Fix DatasetEditor edit bar colors

* Fix global containers heights

* Fix tests scrolling target

* Fix styles

* Fix navbar cypress helpers

* [ci nocache]

* Fix scroll in e2e test

* Browsing | Manage sidebar state with redux (#21226)

* Move navbar state to redux

* Hide sidbebar using CSS

* Fix native E2E test

* Fix native e2e test

* Fix model tests

* Use more accurate element getters

* Fix e2e tests

* Browsing | Fix dashboard UI (#21233)

* Fix parameter widgets event listeners

* Attach scroll events to "main" instead of window

* Resize filters panel when navigation sidebar open

* Reorder imports at App

* Hide AppBar and NavBar when editing dashboard

* Fix navbar & appbar visibility

* Fix filter positions

* Extract `getMainElement` helper

* Update unit tests

* Fix test

* Browse fix bulk actions (#21320)

* make bulk action bar aware of sidebar, remove extraneous layout components

* clean up styling

* convert BulkActionBar to tsx

* Fix types

Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com>
Co-authored-by: Gustavo Saiani <gustavo@poe.ma>
Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>

* Upgrade Cypress to the latest version (9.4.1)

* Fix collections tests failures after upgrade

* Fix binning tests failures after upgrade

* Fix dashboard test failures after upgrade

* Fix models test failures after upgrade

* Fix admin test failures after upgrade

* Fix visualizations test failures after upgrade

* Rewrite and fix repro for 17397

Added the missing issue reference.

* Fix question test failures after upgrade

* Fix interception handlers in metabase-visual tests

* Fix the rest of the binning tests after upgrade

* rewrite cypressWaitAll helper with a simple recursion

* Updating to 9.5.0

* Upgrade Cypress to v9.5.1

* Fix repro for 13332

* Fix pinned items `collections` test failures

* Speed `collection-pinned-overview` spec up using the API

* Fix failing localization test

Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Co-authored-by: Diogo Mendes <diogo@metabase.com>

* Add e2e helpers for bi-basics

* Apply `summarize` helper to the related tests

* Apply `filter` helper to the related tests

* Add E2E tests

* Allow adding models to dashboards

* Allow using models in native queries

* Fix last edit info vertical alignment

* Change picker's copy

* Handle undefiend question

* simplify nav options [ci skip]

* icon tweaks [ci skip]

* dismiss when clicking items [ci skip]

* lint

* Prototype/create button (#19587)

* fix create menu not closing

* update specs

* lint

* fix more specs

* fix specs

* specs

* clean up

* specs

Co-authored-by: Alexander Lesnenko <alxnddr@users.noreply.github.com>
Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>

* Remove not used `noLink` prop

* Namespace URL generators

* Fix HeaderBreadcrumbs font-size in "head" mode

* Add unit-tests for QuestionDataSource

* Allow using react nodes in breadcrumbs

* Use func declaration for QuestionDataSource

* Add prop-types

* Simplify query assignment expr

* Don't swallow errors in QuestionDataSource tests

* Add repro for #17961 (unit)

* Allow passing custom divider for HeaderBreadcrumbs

* Fix join tables breadcrumb links

* Add extra saved question utils

* Add tests for nested questions

* Fix source question link

* Don't show source question's schema

* Fix breadcrumb colors

* Fix tests

* Fix breadcrumb colors

* Use saved-questions lib utils for DataSelector

* Extract repro for #12228 into a separate file

* Extract repro for #15444 into a separate file

* Extract repro for #15460 into a separate file

* Extract repro for #15700 into a separate file

* Extract repro for #15981 into a separate file

* Extract repro for #16739 into a separate file

* Extract repro for #13961 into a separate file

* Extract repro for #14145 into a separate file

* Extract repro for #12581 into a separate file

* Extract repro for #14302 into a separate file

* Extract repro for #15163 into a separate file

* Extract repro for #11580 into a separate file

* Extract repro for #11480 into a separate file

* Extract repro for #9357 into a separate file

* Add Cypress helper function `filterWidget`

* Apply `filterWidget` helper to the related specs

* Annotate the function using JSDoc

* Enable #16739 repro

* Fix isResultDirty selector when filter is empty

* Enable repro for #16811

* Add new Cypress helper function `openNativeEditor`

- exports the function
- documents the function using JSDoc

* Apply new helper function to the related tests

#16739 Repro: Filter feature flag causes Run-overlay of results in Native editor unless editor is expanded (#16753)

* Fix incorrect question variable links

* Extract method building question URL

* refetch card on RELOAD_CARD action

* fetch via question entity to update cache

* unskip & fix cy test

* exclude parameters from isDirty check

* prevent calling methods on null originalQuestion

* rmv Save reliance in e2e test

* code refactor

* unskip repro

* rmv #520 workaround test because bug is fixed

* revert to previous sandbox.cy.spec.js

* skip workaround test

* add explanatory comment

* Cleanup from dump-load-entities-test (#16281)

Updating dump-load-entities-test test so that dump dir is actually deleted at the end

* Revamp Cypress custom commands (#16292)

* Extract UI custom commands

* Extract user related custom commands

* Extract overwrites

* Extract permissions related custom commands

* Extract API custom commands

* Extract helpers custom commands

* Extract database related custom commands

* Rename `helpers` group to `visibility`

* Rename custom command `isInViewport` to `isRenderedWithinViewport`

* Unskip repro for #15119 (#16297)

* Create composite Cypress custom command `cy.createQuestionAndDashboard` (#16294)

* Add composite Cypress custom command `createQuestionAndDashboard`

* Refactor the existing test to use new Cypress custom command

* Refactor repro for #13062 using the new Cypress custom command

* Use the `describe` block instead of using `forEach` for complex repro

* Add space between test cases

* #12629 Repro: Human-readable number formatting not working properly (#16231)

* Fix `nosql` user's email address (#16306)

* Generate correct SQL for columns from joins inside other joins or source queries (#16254)

* Fix joining a join inside a nested queries (#12928)

* Code cleanup & dox

* Tests for #13649

* Test fixes 



* Remove unit tests snapshots (#16321)

* Remove snapshots from `Calendar.unit.spec.js`

* Remove snapshots from `DashCard.unit.spec.js`

* Remove snapshots generated for "internal" components

* Remove unused import

* Remove snapshot related command from `scripts`

* Remove `noSnapshotTest` from internal components

* Remove `react-test-renderer`

* filter nulls out of histograms (#16345)

* #15993 Repro: Click behavior with filter pass-thru does not show filters defined on question (#16342)

* #16334 Repro: Click Behavior targeting a question with filter mapped causes the visualization type to change (#16343)

* Add repro for #16334

* Expand test assertion

* #16327 Repro: Double binning menu for date fields when using Saved Question (Native) (#16359)

* #16322 Repro: "Custom mapping" is only available, when "A list of all values" is set (and after a browser refresh) (#16361)

* #16226 Repro: LDAP/Email settings gets cleared if validation fails (#16364)

* Add repro for #16226

* Extract email settings into a separate file

* Add repro for #16226 (Email)

* switch to column settings when sidebar is already open (#16368)

* align labels on non-bars in combo charts (#16369)

* #16378 Repro: Cannot enable JWT authentication (#16384)

* Fix JS error on JWT settings form (#16394)

* fix default updateSettings function in SettingsBatchForm

* unskip repro

* #12128 Repro: Can't change label on empty row value (#16426)

* Post-merge fix

* Post-merge fix 2
I didn't solve this merge conflict properly in the original merge.

Co-authored-by: Jeff Evans <jeff303@users.noreply.github.com>
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

* Parse number filter inputs

The frontend feels a bit off on this. It's sending `"string/="`
instead of `"number/="` but the backend code knows that number filters
can ignore it. It's also sending strings from the text inputs when it
should be sending number types.

We've had a convention that the types come across as they should be:
numbers come in as numbers and strings as strings. This seems to break
that convention.

* Unskip the "number" part of the repro for #15981

* use normalized parameter values when diffing for dirtiness

* update tag parameter parsing fns to handle number --> number/= types

* tweak & unskip cypress repro test

* wrap fn in parens to invoke it?

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
Co-authored-by: Dalton Johnson <daltojohnso@users.noreply.github.com>